RecommendationService became and interface.

Old RecommendationService is now RecommendationServiceImpl.

Author: yasinuygun

src/main/java/com/trendyol/recomengine/webservice/controllers/RecommendationController.java

@@ -24,7 +24,6 @@ class RecommendationController {
      * @param userId The user's id who sends the GET request.
      * @return If there is a recommendation list for the user in the database, returns it. Otherwise, returns a default
      * recommendation list using generateDefaultRecommendations.
-     * @see RecommendationController#generateDefaultRecommendations(String)
      */
     @GetMapping("/users/{userId}/recommendations")
     Recommendation getRecommendation(@PathVariable String userId) {

src/main/java/com/trendyol/recomengine/webservice/services/RecommendationService.java

@@ -6,27 +6,6 @@
 import org.springframework.stereotype.Service;
 
 @Service
-public class RecommendationService {
-    @Autowired
-    private RecommendationRepository repository;
-
-    public Recommendation getRecommendations(String userId) {
-        Recommendation fetched = repository.findBy_id(userId);
-        return fetched == null ? generateDefaultRecommendations(userId) : fetched;
-    }
-
-    /**
-     * Generates a default recommendation list for the user. For now, it returns 10 products' ids but default
-     * recommendations could be generated based on a criterion.
-     *
-     * @param userId The user id of the user that is to be recommended.
-     * @return A list of recommendations that is generated for the user.
-     * @see Recommendation
-     */
-    private Recommendation generateDefaultRecommendations(String userId) {
-        return new Recommendation(userId, new String[]{
-                "100", "101", "102", "103", "104",
-                "105", "106", "107", "108", "109"
-        });
-    }
+public interface RecommendationService {
+    Recommendation getRecommendations(String userId);
 }

src/main/java/com/trendyol/recomengine/webservice/services/impl/RecommendationServiceImpl.java

@@ -0,0 +1,33 @@
+package com.trendyol.recomengine.webservice.services.impl;
+
+import com.trendyol.recomengine.webservice.repositories.RecommendationRepository;
+import com.trendyol.recomengine.webservice.resource.Recommendation;
+import com.trendyol.recomengine.webservice.services.RecommendationService;
+import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.stereotype.Service;
+
+@Service
+public class RecommendationServiceImpl implements RecommendationService {
+    @Autowired
+    private RecommendationRepository repository;
+
+    public Recommendation getRecommendations(String userId) {
+        Recommendation fetched = repository.findBy_id(userId);
+        return fetched == null ? generateDefaultRecommendations(userId) : fetched;
+    }
+
+    /**
+     * Generates a default recommendation list for the user. For now, it returns 10 products' ids but default
+     * recommendations could be generated based on a criterion.
+     *
+     * @param userId The user id of the user that is to be recommended.
+     * @return A list of recommendations that is generated for the user.
+     * @see Recommendation
+     */
+    private Recommendation generateDefaultRecommendations(String userId) {
+        return new Recommendation(userId, new String[]{
+                "100", "101", "102", "103", "104",
+                "105", "106", "107", "108", "109"
+        });
+    }
+}

src/test/java/com/trendyol/recomengine/webservice/controllers/RecommendationControllerTests.java

@@ -13,6 +13,7 @@
 import org.springframework.test.web.servlet.MockMvc;
 
 import static org.hamcrest.Matchers.hasItems;
+import static org.hamcrest.Matchers.hasSize;
 import static org.mockito.BDDMockito.given;
 import static org.springframework.test.web.servlet.ResultMatcher.matchAll;
 import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;