All tests run properly.

Author: yasinuygun

pom.xml

@@ -48,18 +48,6 @@
             <version>1.11.3</version>
             <scope>test</scope>
         </dependency>
-        <dependency>
-            <groupId>org.junit.jupiter</groupId>
-            <artifactId>junit-jupiter-api</artifactId>
-            <version>RELEASE</version>
-            <scope>test</scope>
-        </dependency>
-        <dependency>
-            <groupId>org.junit.jupiter</groupId>
-            <artifactId>junit-jupiter-api</artifactId>
-            <version>RELEASE</version>
-            <scope>test</scope>
-        </dependency>
     </dependencies>
 
     <build>

src/test/java/com/trendyol/recomengine/webservice/controller/BaseMongoIntegrationTest.java

@@ -1,12 +1,6 @@
 package com.trendyol.recomengine.webservice.controller;
 
-import com.trendyol.recomengine.webservice.model.Recommendation;
-import com.trendyol.recomengine.webservice.repository.RecommendationRepository;
-import com.trendyol.recomengine.webservice.service.RecommendationService;
-import org.junit.Assert;
-import org.junit.Test;
 import org.junit.runner.RunWith;
-import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.boot.test.util.TestPropertyValues;
 import org.springframework.context.ApplicationContextInitializer;
@@ -22,26 +16,12 @@
 @SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.NONE)
 @ActiveProfiles("test")
 @ContextConfiguration(initializers = BaseMongoIntegrationTest.Initializer.class)
-public class BaseMongoIntegrationTest {
+public abstract class BaseMongoIntegrationTest {
     private static final int MONGO_PORT = 27017;
 
     private static GenericContainer mongoContainer = new GenericContainer("mongo:latest")
             .withExposedPorts(MONGO_PORT)
             .waitingFor(Wait.forListeningPort());
-    @Autowired
-    RecommendationRepository recommendationRepository;
-    @Autowired
-    RecommendationService recommendationService;
-
-    @Test
-    public void dummyTest() {
-        String userId = "3";
-        String[] recommendations = new String[]{"1", "2", "3", "4", "5", "6", "7", "8", "9", "10"};
-
-        Recommendation recommendation = new Recommendation(userId, recommendations);
-        recommendationRepository.save(recommendation);
-        Assert.assertEquals(recommendationService.getRecommendations(userId).get_id(), userId);
-    }
 
     static class Initializer implements ApplicationContextInitializer<ConfigurableApplicationContext> {
         @Override

src/test/java/com/trendyol/recomengine/webservice/controller/RecommendationControllerIntegrationTests.java

@@ -3,40 +3,23 @@
 import com.trendyol.recomengine.webservice.model.Recommendation;
 import com.trendyol.recomengine.webservice.repository.RecommendationRepository;
 import com.trendyol.recomengine.webservice.service.RecommendationService;
+import org.junit.Assert;
 import org.junit.Test;
-import org.junit.runner.RunWith;
 import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.boot.test.context.SpringBootTest;
-import org.springframework.test.context.ActiveProfiles;
-import org.springframework.test.context.ContextConfiguration;
-import org.springframework.test.context.junit4.SpringRunner;
-import org.springframework.test.context.support.AnnotationConfigContextLoader;
-import org.testcontainers.containers.GenericContainer;
 
-@RunWith(SpringRunner.class)
-@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.NONE)
-@ActiveProfiles("test")
-public class RecommendationControllerIntegrationTests {
+public class RecommendationControllerIntegrationTests extends BaseMongoIntegrationTest {
     @Autowired
-    RecommendationRepository recommendationRepository;
-
+    private RecommendationRepository recommendationRepository;
     @Autowired
-    RecommendationService recommendationService;
+    private RecommendationService recommendationService;
 
     @Test
-    public void contextLoad() {
-
-    }
-
-    @Test
-    public void givenUserObject_whenSave_thenCreateNewUser() {
+    public void getRecommendationShouldReturnTheRelevantUsersRecommendation() {
         String userId = "3";
         String[] recommendations = new String[]{"1", "2", "3", "4", "5", "6", "7", "8", "9", "10"};
 
         Recommendation recommendation = new Recommendation(userId, recommendations);
         recommendationRepository.save(recommendation);
-        assert (recommendationService.getRecommendations(userId).get_id().equals(userId));
+        Assert.assertEquals(recommendationService.getRecommendations(userId).get_id(), userId);
     }
-
 }
-

src/test/java/com/trendyol/recomengine/webservice/controller/ReviewControllerUnitTests.java

@@ -2,7 +2,6 @@
 
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.trendyol.recomengine.webservice.model.Review;
-import com.trendyol.recomengine.webservice.repository.RecommendationRepository;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -14,12 +13,10 @@
 import org.springframework.test.context.junit4.SpringRunner;
 import org.springframework.test.web.servlet.MockMvc;
 
-import java.io.Serializable;
 import java.sql.Timestamp;
 import java.text.SimpleDateFormat;
 import java.util.TimeZone;
 
-import static org.mockito.BDDMockito.given;
 import static org.springframework.test.web.servlet.ResultMatcher.matchAll;
 import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post;
 import static org.springframework.test.web.servlet.result.MockMvcResultHandlers.print;
@@ -36,6 +33,14 @@ public class ReviewControllerUnitTests {
     @MockBean
     private KafkaTemplate<String, String> kafkaTemplate;
 
+    public static String asJsonString(final Object obj) {
+        try {
+            return new ObjectMapper().writeValueAsString(obj);
+        } catch (Exception e) {
+            throw new RuntimeException(e);
+        }
+    }
+
     @Test
     public void createReviewShouldReturnTheGivenReviewBack() throws Exception {
         String userId = "3";
@@ -102,14 +107,6 @@ public void createReviewShouldReturnBadRequestSinceAllFieldsDoNotExist() throws
                 .andExpect(status().isBadRequest());
     }
 
-    public static String asJsonString(final Object obj) {
-        try {
-            return new ObjectMapper().writeValueAsString(obj);
-        } catch (Exception e) {
-            throw new RuntimeException(e);
-        }
-    }
-
     private String getTimeStringFormatted(Timestamp time) {
         String timeStringFormatted;
         SimpleDateFormat sdf = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSSZ");