Regex check is added but pathvariable cannot be validated.

Author: yasinuygun

src/main/java/com/trendyol/recomengine/webservice/controller/ReviewController.java

@@ -9,6 +9,8 @@
 import org.springframework.web.bind.annotation.RestController;
 
 import javax.validation.Valid;
+import javax.validation.constraints.NotBlank;
+import javax.validation.constraints.Pattern;
 
 /**
  * Handles POST requests that contain user reviews, validates the data that comes from requests and sends them to Kafka.
@@ -33,7 +35,13 @@ public class ReviewController {
      * @see ReviewWithoutUserId
      */
     @PostMapping(value = "/users/{userId}/reviews")
-    public Object createReview(@Valid @RequestBody ReviewWithoutUserId requestBody, @PathVariable String userId) {
+    public Object createReview(@Valid @RequestBody ReviewWithoutUserId requestBody,
+                               @PathVariable
+                               @Valid
+                               @NotBlank
+                               @Pattern(regexp = "^[a-zA-Z0-9]+$"
+                                       , message = "userId must only contain alphanumeric characters.")
+                                       String userId) {
         Review review = new Review(userId, requestBody);
 
         String dataToSendToKafka = String.format("%s,%s,%.1f,%d", userId, requestBody.getProductId(),

src/main/java/com/trendyol/recomengine/webservice/model/Review.java

@@ -1,6 +1,7 @@
 package com.trendyol.recomengine.webservice.model;
 
 import javax.validation.constraints.NotBlank;
+import javax.validation.constraints.Pattern;
 import java.sql.Timestamp;
 
 /**
@@ -9,6 +10,7 @@
 public class Review extends ReviewWithoutUserId {
 
     @NotBlank
+    @Pattern(regexp = "^[a-zA-Z0-9]+$", message = "userId must only contain alphanumeric characters.")
     private final String userId;
 
     /**

src/main/java/com/trendyol/recomengine/webservice/model/ReviewWithoutUserId.java

@@ -1,9 +1,6 @@
 package com.trendyol.recomengine.webservice.model;
 
-import javax.validation.constraints.DecimalMin;
-import javax.validation.constraints.Max;
-import javax.validation.constraints.NotBlank;
-import javax.validation.constraints.NotNull;
+import javax.validation.constraints.*;
 import java.sql.Timestamp;
 
 /**
@@ -12,6 +9,7 @@
 public class ReviewWithoutUserId {
 
     @NotBlank
+    @Pattern(regexp = "^[a-zA-Z0-9]+$", message = "productId must only contain alphanumeric characters.")
     private final String productId;
 
     @DecimalMin(value = "0.5")

src/main/java/com/trendyol/recomengine/webservice/repository/RecommendationRepository.java

@@ -2,12 +2,14 @@
 
 import com.trendyol.recomengine.webservice.model.Recommendation;
 import org.springframework.data.mongodb.repository.MongoRepository;
+import org.springframework.stereotype.Repository;
 
 /**
  * Used to fetch recommendations of a specific user from MongoDB. Extends interface MongoRepository that is needed to
  * configure the Spring Boot application to retrieve data from MongoDB. Required confifgurations are made in the
  * application.yml file.
  */
+@Repository
 public interface RecommendationRepository extends MongoRepository<Recommendation, String> {
 
     /**

src/test/java/com/trendyol/recomengine/webservice/controller/ReviewControllerTests.java

@@ -2,6 +2,7 @@
 
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.trendyol.recomengine.webservice.model.Review;
+import com.trendyol.recomengine.webservice.repository.RecommendationRepository;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.springframework.beans.factory.annotation.Autowired;