Skip to content

Commit 0a96548

Browse files
committed
add some comments to the weaver config
1 parent 4ed0bc6 commit 0a96548

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

scripts/semconv/templates/registry/ts-experimental/weaver.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,16 @@
1+
# ts-experimental/... generates the "semantic-conventions/src/experimental_*.ts"
2+
# files.
3+
14
# Notes:
25
# - Use `""` and `null` with `exclude_stability` to skip attributes/metrics that
36
# accidentally do not have a stability set
47
# (e.g. https://github.com/open-telemetry/semantic-conventions/issues/1777).
58
templates:
69
- pattern: attributes.ts.j2
710
file_name: "experimental_attributes.ts"
11+
# This "exclude_stability" does *not* exclude "stable" because it needs
12+
# to process *stable* enums that might have *unstable* members. (e.g.,
13+
# `db.system.name` is stable, but some of its enum values are not.)
814
filter: >
915
semconv_attributes({
1016
"exclude_stability": ["", null]

scripts/semconv/templates/registry/ts-stable/weaver.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
# ts-stable/... generates the "semantic-conventions/src/stable_*.ts" files.
2+
13
templates:
24
- pattern: attributes.ts.j2
35
file_name: "stable_attributes.ts"

0 commit comments

Comments
 (0)