feat(core)!: remove unused/obsolete functions and types (open-telemetry#5444)

Author: pichlermarc

CHANGELOG.md

@@ -80,6 +80,18 @@ For semantic convention package changes, see the [semconv CHANGELOG](packages/se
 * chore!: Raise the minimum supported Node.js version to `^18.19.0 || >=20.6.0`. Support for Node.js 14, 16, and early minor versions of 18 and 20 have been dropped. This applies to all packages except the 'api' and 'semantic-conventions' packages. [#5395](https://github.com/open-telemetry/opentelemetry-js/issues/5395) @trentm
 * feat(core)!: remove TracesSamplerValues from exports [#5406](https://github.com/open-telemetry/opentelemetry-js/pull/5406) @pichlermarc
   * (user-facing): TracesSamplerValues was only consumed internally and has been removed from exports without replacement
+* feat(core)!: remove unused and obsolete functions and types [#5444](https://github.com/open-telemetry/opentelemetry-js/pull/5444) @pichlermarc
+  * (user-facing): `VERSION` was an internal constant that was unintentionally exported. It has been removed without replacement.
+  * (user-facing): `isWrapped` has been removed in favor of `isWrapped` from `@opentelemetry/instrumentation`
+  * (user-facing): `ShimWrapped` has been removed in favor of `ShimWrapped` from `@opentelemetry/instrumentation`
+  * (user-facing): `hexToBase64` was a utility function that is not used by the SDK anymore. It has been removed without replacement.
+  * (user-facing): `hexToBinary` was a utility function that now internal to `@opentelemetry/otlp-tranformer`. It has been removed without replacement.
+  * (user-facing): `baggageUtils.getKeyParis` was an internal utility function that was unintentionally exported. It has been removed without replacement.
+  * (user-facing): `baggageUtils.serializeKeyPairs` was an internal utility function that was unintentionally exported. It has been removed without replacement.
+  * (user-facing): `baggageUtils.parseKeyPairsIntoRecord,` has been removed in favor of `parseKeyPairsIntoRecord`
+  * (user-facing): `baggageUtils.parsePairKeyValue` was an internal utility function that was unintentionally exported. It has been removed without replacement.
+  * (user-facing): `TimeOriginLegacy` has been removed without replacement.
+  * (user-facing): `isAttributeKey` was an internal utility function that was unintentionally exported. It has been removed without replacement.
 
 ### :rocket: (Enhancement)
 

experimental/packages/opentelemetry-instrumentation-xml-http-request/test/xhr.test.ts

@@ -14,8 +14,11 @@
  * limitations under the License.
  */
 import * as api from '@opentelemetry/api';
-import { otperformance as performance, isWrapped } from '@opentelemetry/core';
-import { registerInstrumentations } from '@opentelemetry/instrumentation';
+import { otperformance as performance } from '@opentelemetry/core';
+import {
+  registerInstrumentations,
+  isWrapped,
+} from '@opentelemetry/instrumentation';
 import {
   B3Propagator,
   B3InjectEncoding,

experimental/packages/otlp-exporter-base/src/configuration/otlp-http-env-configuration.ts

@@ -13,7 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import { baggageUtils } from '@opentelemetry/core';
+import { parseKeyPairsIntoRecord } from '@opentelemetry/core';
 import { diag } from '@opentelemetry/api';
 import { getSharedConfigurationFromEnvironment } from './shared-env-configuration';
 import { OtlpHttpConfiguration } from './otlp-http-configuration';
@@ -27,10 +27,10 @@ function getStaticHeadersFromEnv(
   const nonSignalSpecificRawHeaders =
     process.env['OTEL_EXPORTER_OTLP_HEADERS']?.trim();
 
-  const signalSpecificHeaders = baggageUtils.parseKeyPairsIntoRecord(
+  const signalSpecificHeaders = parseKeyPairsIntoRecord(
     signalSpecificRawHeaders
   );
-  const nonSignalSpecificHeaders = baggageUtils.parseKeyPairsIntoRecord(
+  const nonSignalSpecificHeaders = parseKeyPairsIntoRecord(
     nonSignalSpecificRawHeaders
   );
 
@@ -45,8 +45,8 @@ function getStaticHeadersFromEnv(
   // the non-specific ones.
   return Object.assign(
     {},
-    baggageUtils.parseKeyPairsIntoRecord(nonSignalSpecificRawHeaders),
-    baggageUtils.parseKeyPairsIntoRecord(signalSpecificRawHeaders)
+    parseKeyPairsIntoRecord(nonSignalSpecificRawHeaders),
+    parseKeyPairsIntoRecord(signalSpecificRawHeaders)
   );
 }
 

experimental/packages/otlp-grpc-exporter-base/src/configuration/otlp-grpc-env-configuration.ts

@@ -15,7 +15,7 @@
  */
 import { UnresolvedOtlpGrpcConfiguration } from './otlp-grpc-configuration';
 import type { ChannelCredentials, Metadata } from '@grpc/grpc-js';
-import { baggageUtils } from '@opentelemetry/core';
+import { parseKeyPairsIntoRecord } from '@opentelemetry/core';
 import {
   createEmptyMetadata,
   createInsecureCredentials,
@@ -47,10 +47,10 @@ function getMetadataFromEnv(signalIdentifier: string): Metadata | undefined {
   const nonSignalSpecificRawHeaders =
     process.env['OTEL_EXPORTER_OTLP_HEADERS']?.trim();
 
-  const signalSpecificHeaders = baggageUtils.parseKeyPairsIntoRecord(
+  const signalSpecificHeaders = parseKeyPairsIntoRecord(
     signalSpecificRawHeaders
   );
-  const nonSignalSpecificHeaders = baggageUtils.parseKeyPairsIntoRecord(
+  const nonSignalSpecificHeaders = parseKeyPairsIntoRecord(
     nonSignalSpecificRawHeaders
   );
 

packages/opentelemetry-core/src/common/hex-to-binary.ts renamed to experimental/packages/otlp-transformer/src/common/hex-to-binary.ts

@@ -16,7 +16,8 @@
 
 import type { OtlpEncodingOptions, Fixed64, LongBits } from './internal-types';
 import { HrTime } from '@opentelemetry/api';
-import { hexToBinary, hrTimeToNanoseconds } from '@opentelemetry/core';
+import { hrTimeToNanoseconds } from '@opentelemetry/core';
+import { hexToBinary } from './hex-to-binary';
 
 export function hrTimeToNanos(hrTime: HrTime): bigint {
   const NANOSECONDS = BigInt(1_000_000_000);

experimental/packages/otlp-transformer/src/common/utils.ts

@@ -14,10 +14,10 @@
  * limitations under the License.
  */
 
-import { hexToBinary } from '@opentelemetry/core';
 import { toAnyValue } from '../src/common/internal';
 import * as assert from 'assert';
 import { getOtlpEncoder } from '../src/common/utils';
+import { hexToBinary } from '../src/common/hex-to-binary';
 
 const traceId = 'abcdef01234567890000000000000000';
 const spanId = '12341234abcdabcd';

experimental/packages/otlp-transformer/test/common.test.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 import { HrTime, TraceFlags } from '@opentelemetry/api';
-import { InstrumentationScope, hexToBinary } from '@opentelemetry/core';
+import { InstrumentationScope } from '@opentelemetry/core';
 import { Resource } from '@opentelemetry/resources';
 import * as assert from 'assert';
 import { ReadableLogRecord } from '@opentelemetry/sdk-logs';
@@ -29,6 +29,7 @@ import {
 import { createExportLogsServiceRequest } from '../src/logs/internal';
 import { ProtobufLogsSerializer } from '../src/logs/protobuf';
 import { JsonLogsSerializer } from '../src/logs/json';
+import { hexToBinary } from '../src/common/hex-to-binary';
 
 function createExpectedLogJson(
   options: OtlpEncodingOptions

experimental/packages/otlp-transformer/test/logs.test.ts

@@ -15,7 +15,7 @@
  */
 import * as root from '../src/generated/root';
 import { SpanKind, SpanStatusCode, TraceFlags } from '@opentelemetry/api';
-import { TraceState, hexToBinary } from '@opentelemetry/core';
+import { TraceState } from '@opentelemetry/core';
 import { Resource } from '@opentelemetry/resources';
 import { ReadableSpan } from '@opentelemetry/sdk-trace-base';
 import * as assert from 'assert';
@@ -25,6 +25,7 @@ import { ESpanKind, EStatusCode } from '../src/trace/internal-types';
 import { createExportTraceServiceRequest } from '../src/trace/internal';
 import { ProtobufTraceSerializer } from '../src/trace/protobuf';
 import { JsonTraceSerializer } from '../src/trace/json';
+import { hexToBinary } from '../src/common/hex-to-binary';
 
 function createExpectedSpanJson(options: OtlpEncodingOptions) {
   const useHex = options.useHex ?? false;

experimental/packages/otlp-transformer/test/trace.test.ts

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { hexToBinary } from '@opentelemetry/core';
+import { hexToBinary } from '../src/common/hex-to-binary';
 
 /**
  * utility function to convert a string representing a hex value to a base64 string