Add AI configuration json view

Author: nelsonkopliku

lib/trento_web/controllers/v1/ai_configuration_json.ex

@@ -0,0 +1,15 @@
+defmodule TrentoWeb.V1.AIConfigurationJSON do
+  def ai_configuration(%{ai_configuration: ai_configuration}),
+    do: ai_configuration_entry(ai_configuration)
+
+  def ai_configuration_entry(%{
+        provider: provider,
+        model: model
+      }),
+      do: %{
+        provider: provider,
+        model: model
+      }
+
+  def ai_configuration_entry(_), do: nil
+end

lib/trento_web/controllers/v1/profile_json.ex

@@ -1,5 +1,9 @@
 defmodule TrentoWeb.V1.ProfileJSON do
-  alias TrentoWeb.V1.{AbilityJSON, PersonalAccessTokensJSON}
+  alias TrentoWeb.V1.{
+    AbilityJSON,
+    AIConfigurationJSON,
+    PersonalAccessTokensJSON
+  }
 
   def profile(%{
         user: %{
@@ -32,7 +36,7 @@ defmodule TrentoWeb.V1.ProfileJSON do
         created_at: created_at,
         analytics_enabled: analytics_enabled_at != nil,
         analytics_eula_accepted: analytics_eula_accepted_at != nil,
-        ai_configuration: ai_configuration(ai_configuration),
+        ai_configuration: AIConfigurationJSON.ai_configuration_entry(ai_configuration),
         idp_user: length(user_identities) > 0,
         updated_at: updated_at
       }
@@ -49,15 +53,4 @@ defmodule TrentoWeb.V1.ProfileJSON do
         }
       }),
       do: %{secret: Base.encode32(secret, padding: false), secret_qr_encoded: secret_qr_encoded}
-
-  defp ai_configuration(%{
-         provider: provider,
-         model: model
-       }),
-       do: %{
-         provider: provider,
-         model: model
-       }
-
-  defp ai_configuration(_), do: nil
 end

test/trento_web/views/v1/ai_configuration_view_json_test.exs

@@ -0,0 +1,42 @@
+defmodule TrentoWeb.V1.AIConfigurationJSONTest do
+  use ExUnit.Case
+
+  import Trento.Factory
+
+  alias TrentoWeb.V1.AIConfigurationJSON
+
+  describe "rendering AI Configuration" do
+    test "AI configuration" do
+      %{
+        provider: provider,
+        model: model
+      } = ai_user_configuration = build(:ai_user_configuration)
+
+      scenarios = [
+        %{
+          ai_configuration: ai_user_configuration,
+          expected_ai_configuration: %{
+            provider: provider,
+            model: model
+          }
+        },
+        %{
+          ai_configuration: nil,
+          expected_ai_configuration: nil
+        },
+        %{
+          ai_configuration: "foo",
+          expected_ai_configuration: nil
+        }
+      ]
+
+      for %{
+            ai_configuration: ai_configuration,
+            expected_ai_configuration: expected_ai_configuration
+          } <- scenarios do
+        assert AIConfigurationJSON.ai_configuration(%{ai_configuration: ai_configuration}) ==
+                 expected_ai_configuration
+      end
+    end
+  end
+end

test/trento_web/views/v1/profile_view_json_test.exs

@@ -73,39 +73,21 @@ defmodule TrentoWeb.V1.ProfileJSONTest do
     end
 
     test "should render a user profile with AI configuration" do
-      %{
-        provider: provider,
-        model: model
-      } = ai_user_configuration = build(:ai_user_configuration)
-
       scenarios = [
-        %{
-          user: build(:user, abilities: [], user_identities: [], ai_configuration: nil),
-          expected_ai_configuration: nil
-        },
-        %{
-          # not providing ai_configuration results in an Ecto.Association.NotLoaded
-          user: build(:user, abilities: [], user_identities: []),
-          expected_ai_configuration: nil
-        },
-        %{
-          user:
-            build(:user,
-              abilities: [],
-              user_identities: [],
-              ai_configuration: ai_user_configuration
-            ),
-          expected_ai_configuration: %{
-            provider: provider,
-            model: model
-          }
-        }
+        # not providing ai_configuration results in an Ecto.Association.NotLoaded
+        build(:user, abilities: [], user_identities: []),
+        build(:user, abilities: [], user_identities: [], ai_configuration: nil),
+        build(:user,
+          abilities: [],
+          user_identities: [],
+          ai_configuration: build(:ai_user_configuration)
+        )
       ]
 
-      for %{user: user, expected_ai_configuration: expected_ai_configuration} <- scenarios do
-        rendered_user = ProfileJSON.profile(%{user: user})
-
-        assert rendered_user.ai_configuration == expected_ai_configuration
+      for user <- scenarios do
+        assert %{user: user}
+               |> ProfileJSON.profile()
+               |> Map.has_key?(:ai_configuration)
       end
     end
   end