Skip to content

Commit ecb3839

Browse files
committed
Remove check about feature being enabled in AI entrypoint module
1 parent 50d20f2 commit ecb3839

File tree

3 files changed

+10
-41
lines changed

3 files changed

+10
-41
lines changed

lib/trento/ai.ex

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -19,26 +19,16 @@ defmodule Trento.AI do
1919
2020
See `Trento.AI.Configurations.create_user_configuration/2` for more details.
2121
"""
22-
def create_user_configuration(user, attrs) do
23-
execute_if_enabled(fn -> configurations().create_user_configuration(user, attrs) end)
24-
end
22+
def create_user_configuration(user, attrs),
23+
do: configurations().create_user_configuration(user, attrs)
2524

2625
@doc """
2726
Updates a user configuration for AI.
2827
2928
See `Trento.AI.Configurations.update_user_configuration/2` for more details.
3029
"""
31-
def update_user_configuration(user, attrs) do
32-
execute_if_enabled(fn -> configurations().update_user_configuration(user, attrs) end)
33-
end
34-
35-
defp execute_if_enabled(function) do
36-
if enabled?() do
37-
function.()
38-
else
39-
{:error, :ai_features_disabled}
40-
end
41-
end
30+
def update_user_configuration(user, attrs),
31+
do: configurations().update_user_configuration(user, attrs)
4232

4333
defp configurations,
4434
do: Keyword.get(ApplicationConfigLoader.load(), :configurations, Configurations)

lib/trento/ai/user_configuration.ex

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -35,18 +35,10 @@ defmodule Trento.AI.UserConfiguration do
3535
|> foreign_key_constraint(:user_id, message: "User does not exist")
3636
end
3737

38-
defp maybe_update_provider(attrs) do
39-
case Map.has_key?(attrs, :model) do
40-
true -> Map.put(attrs, :provider, get_model_provider(attrs))
41-
false -> attrs
42-
end
43-
end
38+
defp maybe_update_provider(%{model: model} = attrs),
39+
do: Map.put(attrs, :provider, LLMRegistry.get_model_provider(model))
4440

45-
defp get_model_provider(attrs) do
46-
attrs
47-
|> Map.get(:model)
48-
|> LLMRegistry.get_model_provider()
49-
end
41+
defp maybe_update_provider(attrs), do: attrs
5042

5143
defp validate_model(_model_field_atom, model) do
5244
if LLMRegistry.model_supported?(model) do

test/trento/ai_test.exs

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -27,22 +27,9 @@ defmodule Trento.AITest do
2727
end
2828
end
2929

30-
describe "enabling/disabling features" do
31-
test "features are disabled" do
32-
expect(Trento.AI.ApplicationConfigLoader.Mock, :load_config, 2, fn -> [enabled: false] end)
33-
user = build(:user)
34-
35-
attrs = %{
36-
model: "foo",
37-
api_key: "bar"
38-
}
39-
40-
assert AI.create_user_configuration(user, attrs) == {:error, :ai_features_disabled}
41-
assert AI.update_user_configuration(user, attrs) == {:error, :ai_features_disabled}
42-
end
43-
44-
test "features are enabled" do
45-
expect(Trento.AI.ApplicationConfigLoader.Mock, :load_config, 4, fn ->
30+
describe "delegating creation and update to configurations module" do
31+
test "should delegate to configurations module" do
32+
expect(Trento.AI.ApplicationConfigLoader.Mock, :load_config, 2, fn ->
4633
[
4734
enabled: true,
4835
configurations: DummyConfigurations

0 commit comments

Comments
 (0)