analysed-controller-statistics

[pilot7777]

We just upgraded our e-series to 11.80.1R3 and started seeing this error.
msg="Response error" code=404 body="{\n"servlet":"Storage Manager REST API",\n"message": │
│ "Not Found",\n"url":"/devmgr/v2/storage-systems/1/analysed-controller-statistics",\n"status":"404"\n}"

Seems the API path had been changed to storage-systems/1/analyzed/controller-statistics. Wondering if this can be modified to be suitable for the different versions.

[treydock]

#25 mentions similar issue and I believe they may have found a solution in a fork. I no longer have ESeries hardware at my site so I'm no longer able to test exporter changes.

Do these API URLs look correct? https://github.com/NetAppDocs/e-series/blob/main/web-services-proxy/polling-intro-concept.adoc. I'm not sure where the official API docs live now but looks like it might be:

/storage-systems/{id}/analysed-drive-statistics/

Since I can't test this myself I can update the URL but if the data structure changed then I'd need the official API schema docs or an example data dump to update the exporter.

[pilot7777]

The API doc on Netapp site seems out dated. https://docs.netapp.com/us-en/e-series/pdfs/sidebar/Web_services_proxy.pdf

After posting here yesterday, I tried to modify the code. I have little knowlege of GO. I made it work. Here is the diff.

diff --git a/collector/collector.go b/collector/collector.go
index 8098696..b65661b 100644
--- a/collector/collector.go
+++ b/collector/collector.go
@@ -88,7 +88,8 @@ func sliceContains(slice []string, str string) bool {
 func getRequest(target config.Target, path string, logger log.Logger) ([]byte, error) {
        rel := &url.URL{Path: path}
        u := target.BaseURL.ResolveReference(rel)
-       req, err := http.NewRequest("GET", u.String(), nil)
+        unescaped, err := url.PathUnescape(u.String())
+       req, err := http.NewRequest("GET", unescaped, nil)
        if err != nil {
                return nil, err
        }
diff --git a/collector/controller-statistics.go b/collector/controller-statistics.go
index ddb8386..cf81f7b 100644
--- a/collector/controller-statistics.go
+++ b/collector/controller-statistics.go
@@ -265,7 +265,7 @@ func (c *ControllerStatisticsCollector) collect() ([]AnalysedControllerStatistic
        }()
        go func() {
                defer wg.Done()
-               analyzedStatisticsBody, analyzedStatisticsErr = getRequest(c.target, fmt.Sprintf("/devmgr/v2/storage-systems/%s/analysed-controller-statistics", c.target.Name), c.logger)
+               analyzedStatisticsBody, analyzedStatisticsErr = getRequest(c.target, fmt.Sprintf("/devmgr/v2/storage-systems/%s/analyzed/controller-statistics?statisticsFetchTime=60", c.target.Name), c.logger)
        }()
        go func() {
                defer wg.Done()
@@ -285,7 +285,10 @@ func (c *ControllerStatisticsCollector) collect() ([]AnalysedControllerStatistic
        if err != nil {
                return nil, nil, err
        }
-       err = json.Unmarshal(analyzedStatisticsBody, &analyzedStatistics)
+       var objmap map[string]json.RawMessage
+       err = json.Unmarshal(analyzedStatisticsBody, &objmap)
+
+       err = json.Unmarshal(objmap["statistics"], &analyzedStatistics)
        if err != nil {
                return nil, nil, err
        }

Here is output from storage-systems/1/analyzed/controller-statistics?statisticsFetchTime=60

{
  "statistics": [
    {
      "observedTime": "2024-11-26T21:57:20.000+00:00",
      "observedTimeInMS": "1732658240000",
      "sourceController": "070000000000000000000001",
      "readIOps": 0.7266666666666667,
      "writeIOps": 53.18333333333333,
      "otherIOps": 0.0,
      "combinedIOps": 53.91,
      "readThroughput": 0.005442301432291667,
      "writeThroughput": 48.47357432047526,
      "combinedThroughput": 48.479016621907554,
      "readResponseTime": 14.865036521661295,
      "readResponseTimeStdDev": 104.05525565162907,
      "writeResponseTime": 23.61092608337285,
      "writeResponseTimeStdDev": 165.27648258360995,
      "combinedResponseTime": 23.46799015546998,
      "combinedResponseTimeStdDev": 164.27593108828987,
      "averageReadOpSize": 7853.211009174312,
      "averageWriteOpSize": 955717.2046380445,
      "readOps": 218.0,
      "writeOps": 15955.0,
      "readPhysicalIOps": 0.76,
      "writePhysicalIOps": 47.97666666666667,
      "controllerId": "070000000000000000000001",
      "cacheHitBytesPercent": 6.353052881998769,
      "randomIosPercent": 25.919742781178506,
      "mirrorBytesPercent": 100.0,
      "fullStripeWritesBytesPercent": 83.84501315148512,
      "maxCpuUtilization": 36.0,
      "maxCpuUtilizationPerCore": [
        36.0,
        8.0,
        3.0,
        14.0,
        3.0,
        4.0,
        5.0
      ],
      "cpuAvgUtilization": 5.843809523809524,
      "cpuAvgUtilizationPerCore": [
        33.25,
        1.4166666666666667,
        1.13,
        1.6833333333333333,
        1.1,
        1.1733333333333333,
        1.1533333333333333
      ],
      "cpuAvgUtilizationPerCoreStdDev": [
        1.8794946129212575,
        0.9181805680559546,
        0.34607320998116425,
        1.678210025261704,
        0.29999999999999977,
        0.46542692468552144,
        0.45072780650361005
      ],
      "raid0BytesPercent": 0.0,
      "raid1BytesPercent": 0.0,
      "raid5BytesPercent": 0.0,
      "raid6BytesPercent": 0.0,
      "ddpBytesPercent": 99.98877390299656,
      "readHitResponseTime": 0.0,
      "readHitResponseTimeStdDev": 0.0,
      "writeHitResponseTime": 8.876404854021343,
      "writeHitResponseTimeStdDev": 8.876404854021343,
      "combinedHitResponseTime": 8.876404854021343,
      "combinedHitResponseTimeStdDev": 8.876404854021343,
      "maxPossibleBpsUnderCurrentLoad": 4.965224E+9,
      "maxPossibleIopsUnderCurrentLoad": 208484.0
    },
    {
      "observedTime": "2024-11-26T21:57:20.000+00:00",
      "observedTimeInMS": "1732658240000",
      "sourceController": "070000000000000000000001",
      "readIOps": 1.0433333333333332,
      "writeIOps": 56.723333333333336,
      "otherIOps": 0.0,
      "combinedIOps": 57.766666666666666,
      "readThroughput": 0.009015401204427084,
      "writeThroughput": 50.43546040852865,
      "combinedThroughput": 50.44447580973307,
      "readResponseTime": 12.71670279470852,
      "readResponseTimeStdDev": 101.73362235766815,
      "writeResponseTime": 55.47316587106724,
      "writeResponseTimeStdDev": 443.7853269685379,
      "combinedResponseTime": 54.674714713871936,
      "combinedResponseTimeStdDev": 437.3977177109755,
      "averageReadOpSize": 9060.702875399362,
      "averageWriteOpSize": 932339.6603396604,
      "readOps": 313.0,
      "writeOps": 17017.0,
      "readPhysicalIOps": 0.8500000000000001,
      "writePhysicalIOps": 35.44333333333333,
      "controllerId": "070000000000000000000002",
      "cacheHitBytesPercent": 6.324495256628558,
      "randomIosPercent": 24.764872194333854,
      "mirrorBytesPercent": 100.0,
      "fullStripeWritesBytesPercent": 74.60124480449052,
      "maxCpuUtilization": 40.0,
      "maxCpuUtilizationPerCore": [
        40.0,
        9.0,
        3.0,
        17.0,
        3.0,
        4.0,
        4.0
      ],
      "cpuAvgUtilization": 6.985714285714286,
      "cpuAvgUtilizationPerCore": [
        37.02333333333333,
        2.46,
        1.13,
        4.78,
        1.0633333333333332,
        1.23,
        1.2133333333333334
      ],
      "cpuAvgUtilizationPerCoreStdDev": [
        0.35041245538488336,
        0.8991106717195613,
        0.3648287269390943,
        1.644668152951632,
        0.25688302569241334,
        0.4869291529575941,
        0.47027178902795724
      ],
      "raid0BytesPercent": 0.0,
      "raid1BytesPercent": 0.0,
      "raid5BytesPercent": 0.0,
      "raid6BytesPercent": 0.0,
      "ddpBytesPercent": 99.98212807039877,
      "readHitResponseTime": 0.0,
      "readHitResponseTimeStdDev": 0.0,
      "writeHitResponseTime": 21.412985184277623,
      "writeHitResponseTimeStdDev": 21.412985184277623,
      "combinedHitResponseTime": 21.412985184277623,
      "combinedHitResponseTimeStdDev": 21.412985184277623,
      "maxPossibleBpsUnderCurrentLoad": 4.965216E+9,
      "maxPossibleIopsUnderCurrentLoad": 208440.0
    }
  ],
  "tokenId": null
}

[pilot7777]

/storage-systems/{system-id}/analyzed/controller-statistics has a required parameter

statisticsFetchTime *integer($int64)(query) | The number of seconds of historical statistics data to retrieve. After the initial query has started (a token has been provided), this value is ignored.

[pilot7777]

Thanks for the quick response! Feel free to close this issue.