Merge pull request #19 from triblespace/codex/remove-quickwit-feature-and-related-code

Remove quickwit feature

Author: somethingelseentirely

CHANGELOG.md

@@ -14,6 +14,7 @@ have been removed to keep the changelog focused on Yeehaw's history.
 - handle unknown column codes gracefully in `ColumnarReader::iter_columns`.
 
 ## Features/Improvements
+- remove `quickwit` feature flag and related async code.
 - add docs/example and Vec<u32> values to sstable [#2660](https://github.com/quickwit-oss/yeehaw/pull/2660)(@PSeitz)
 - Add string fast field support to `TopDocs`. [#2642](https://github.com/quickwit-oss/yeehaw/pull/2642)(@stuhood)
 - update edition to 2024 [#2620](https://github.com/quickwit-oss/yeehaw/pull/2620)(@PSeitz)

Cargo.toml

@@ -116,7 +116,7 @@ stopwords = []
 lz4-compression = ["lz4_flex"]
 zstd-compression = ["zstd"]
 
-# enable zstd-compression in columnar (and sstable)
+# enable zstd-compression in columnar
 columnar-zstd-compression = ["columnar/zstd-compression"]
 
 failpoints = ["fail", "fail/failpoints"]

INVENTORY.md

@@ -57,3 +57,5 @@ This inventory captures the direction of the rewrite and the major tasks require
     - Replace `unwrap` usage with a fallible API that reports unknown column types.
 14. **Replace nightly benches using `test::Bencher`**
     - Migrate inline benchmarks to a stable harness so the `unstable` feature can be tested on stable Rust.
+15. **Evaluate removing sstable term dictionary and crate now that `quickwit` feature is gone**
+    - Determine whether the `sstable` crate should remain in the workspace or be extracted.

src/compat_tests.rs

@@ -33,7 +33,6 @@ fn path_for_version(version: &str) -> String {
     format!("./tests/compat_tests_data/index_v{version}/")
 }
 
-/// feature flag quickwit uses a different dictionary type
 #[test]
 fn test_format_6() {
     let path = path_for_version("6");
@@ -43,7 +42,6 @@ fn test_format_6() {
     assert_date_time_precision(&index, DateTimePrecision::Microseconds);
 }
 
-/// feature flag quickwit uses a different dictionary type
 #[test]
 fn test_format_7() {
     let path = path_for_version("7");

src/core/executor.rs

@@ -12,6 +12,12 @@ pub enum Executor {
     ThreadPool(Arc<rayon::ThreadPool>),
 }
 
+impl From<Arc<rayon::ThreadPool>> for Executor {
+    fn from(thread_pool: Arc<rayon::ThreadPool>) -> Self {
+        Executor::ThreadPool(thread_pool)
+    }
+}
+
 impl Executor {
     /// Creates an Executor that performs all task in the caller thread.
     pub fn single_thread() -> Executor {

src/query/range_query/range_query.rs

@@ -173,7 +173,6 @@ pub struct InvertedIndexRangeWeight {
 
 impl InvertedIndexRangeWeight {
     /// Creates a new RangeWeight
-    ///
     pub fn new(
         field: Field,
         lower_bound: &Bound<Term>,