chore: run go fix ./... (#923)

* chore: run go fix ./...

---------

Signed-off-by: Chris Randles <randles.chris@gmail.com>

Author: crandles

Makefile

@@ -117,10 +117,12 @@ style:
 LINT_FLAGS ?= 
 .PHONY: lint
 lint:
+	@go fix -diff ./...
 	@go tool golangci-lint run $(LINT_FLAGS) -c .golangci.yml
 
 .PHONY: lint-fix
 lint-fix:
+	@go fix ./...
 	@LINT_FLAGS="--fix" $(MAKE) lint
 	@go tool golangci-lint fmt -c .golangci.yml
 

pkg/backends/healthcheck/target_test.go

@@ -264,8 +264,7 @@ func TestProbe(t *testing.T) {
 		}, ts.Client())
 		require.NoError(t, err)
 		// start probe loop
-		ctx, cancel := context.WithCancel(context.Background())
-		defer cancel()
+		ctx := t.Context()
 		target.Start(ctx)
 		time.Sleep((intervalMS + windowMS) * time.Millisecond)
 		// verify results

pkg/locks/locks_test.go

@@ -31,13 +31,11 @@ func TestLocks(t *testing.T) {
 
 	nl, _ := lk.Acquire("test")
 	wg := sync.WaitGroup{}
-	wg.Add(1)
-	go func() {
+	wg.Go(func() {
 		nl2, _ := lk.Acquire("test")
 		testVal += 10
 		nl2.Release()
-		wg.Done()
-	}()
+	})
 	testVal++
 	if testVal != 1 {
 		t.Errorf("expected 1 got %d", testVal)
@@ -123,7 +121,7 @@ func TestLocksUpgradePileup(t *testing.T) {
 		errLock.Unlock()
 	}
 
-	for i := 0; i < size; i++ {
+	for range size {
 		go func() {
 			nl, err := lk.RAcquire(testKey)
 			if err != nil {
@@ -159,7 +157,7 @@ func TestLocksConcurrent(t *testing.T) {
 		errLock.Unlock()
 	}
 
-	for i := 0; i < size; i++ {
+	for i := range size {
 		go func(j int) {
 			time.Sleep(time.Duration(rand.Int63()%5000000) * time.Nanosecond)
 			if j%3 == 0 {
@@ -221,13 +219,11 @@ func TestLockReadAndWrite(t *testing.T) {
 		t.Error("expected error for invalid key name")
 	}
 
-	wg.Add(1)
-	go func() {
+	wg.Go(func() {
 		nl1, _ := lk.RAcquire("test")
 		j = i
 		nl1.RRelease()
-		wg.Done()
-	}()
+	})
 
 	i = 10
 	nl.Release()

pkg/proxy/engines/progressive_collapse_forwarder_test.go

@@ -129,7 +129,7 @@ func TestPCFReadWriteGetBody(t *testing.T) {
 
 func TestPCFWaits(t *testing.T) {
 	var testStringLong string
-	for i := 0; i < 32000; i++ {
+	for range 32000 {
 		testStringLong += "DEADBEEF"
 	}
 	w := bytes.NewBuffer(make([]byte, 0, len(testStringLong)))

pkg/proxy/ranges/byterange/multipart_test.go

@@ -36,7 +36,7 @@ const (
 	testPart2Body     = `{ "body": "ABCDEFGHIJKLMNOPQRSTUVWXYZABCDEFGHIJ" }`
 )
 
-var content = []byte(fmt.Sprintf(`--%s
+var content = fmt.Appendf(nil, `--%s
 Content-Type: %s
 Content-Range: bytes %s/%s
 
@@ -48,7 +48,7 @@ Content-Range: bytes %s/%s
 %s
 --%s--`, testSeparator, testContentType1, testRange1, testContentLength,
 	testPart1Body, testSeparator, testContentType1, testRange2, testContentLength,
-	testPart2Body, testSeparator))
+	testPart2Body, testSeparator)
 
 func TestParseMultipartRangeResponseBody(t *testing.T) {
 	reader := io.NopCloser(bytes.NewBuffer(content))

pkg/proxy/ranges/byterange/range_test.go

@@ -224,7 +224,7 @@ func TestRangesFilter(t *testing.T) {
 		if len(bs0) != len(bs1) {
 			return fmt.Errorf("slice lengths %d and %d not eq", len(bs0), len(bs1))
 		}
-		for i := 0; i < len(bs0); i++ {
+		for i := range bs0 {
 			if bs0[i] != bs1[i] {
 				return fmt.Errorf("slices not eq at %d, got %b and %b", i, bs0[i], bs1[i])
 			}

pkg/timeseries/dataset/point_test.go

@@ -75,7 +75,7 @@ func testPoints3() Points {
 
 func genTestPoints(baseEpoch, n int) Points {
 	points := make(Points, n)
-	for i := 0; i < n; i++ {
+	for i := range n {
 		points[i] = Point{
 			Epoch:  epoch.Epoch((i * 10 * timeseries.Second) + baseEpoch),
 			Size:   27,

pkg/timeseries/extent_list_test.go

@@ -1146,7 +1146,7 @@ func genBenchmarkExtentList(len int, step time.Duration) (el ExtentList, start,
 	end = time.Now()
 	start = end.Add(time.Duration(-1*len) * step)
 	el = make(ExtentList, len)
-	for i := 0; i < len; i++ {
+	for i := range len {
 		el[i] = Extent{
 			Start: start.Add(time.Duration(i) * step),
 			End:   start.Add(time.Duration(i+1) * step),