Skip to content

Commit 55664b3

Browse files
authored
Merge pull request feathersjs-ecosystem#473 from feathers-plus/cache
Fixed cache to ignore find calls with
2 parents 8226e48 + c65d48f commit 55664b3

File tree

4 files changed

+12
-9
lines changed

4 files changed

+12
-9
lines changed

lib/services/cache.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ module.exports = function (cacheMap, keyFieldName, options = {}) {
1616
if (context.type === 'after') {
1717
if (context.method === 'remove') return;
1818

19+
const $select = (context.params.query || {}).$select;
20+
if (context.method === 'find' && $select) return;
21+
1922
items.forEach(item => {
2023
const idName = getIdName(keyFieldName, item);
2124
const key = makeCacheKey(item[idName]);
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11

2-
if (process.version.substr(0, 2) >= 'v8') {
3-
require('../../tests-async/act-on-dispatch.test');
2+
if (process.version.substr(0, 2) !== 'v1' && process.version.substr(0, 2) !== 'v8') {
3+
console.log('\n...act-on-dispatch test ignored. Node version is v8.');
44
} else {
5-
console.log('\n...act-on-dispatch test ignored. Node version is prior to v8.');
5+
require('../../tests-async/act-on-dispatch.test');
66
}
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11

2-
if (process.version.substr(0, 2) >= 'v8') {
3-
require('../../tests-async/fast-join-cache.test');
4-
} else {
2+
if (process.version.substr(0, 2) !== 'v1' && process.version.substr(0, 2) !== 'v8') {
53
console.log('\n...fast-join-stub test ignored. Node version is prior to v8.');
4+
} else {
5+
require('../../tests-async/fast-join-cache.test');
66
}

tests/services/fast-join-stub.test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11

2-
if (process.version.substr(0, 2) >= 'v8') {
3-
require('../../tests-async/fast-join.test');
4-
} else {
2+
if (process.version.substr(0, 2) !== 'v1' && process.version.substr(0, 2) !== 'v8') {
53
console.log('\n...fastJoin test ignored. Node version is prior to v8.');
4+
} else {
5+
require('../../tests-async/fast-join.test');
66
}

0 commit comments

Comments
 (0)