Merge pull request feathersjs-ecosystem#448 from j2L4e/typings/fastJoin

Typings: Add context to resolver callback arguments.

Author: eddyystop

types/index.d.ts

@@ -161,16 +161,20 @@ export function discardQuery(...fieldNames: string[]): Hook;
  */
 export function existsByDot(object: any, path: string): boolean;
 
-export type SimpleResolver<T> = (...args: any[]) => (item: T) => Promise<any>;
+export interface ResolverContext<T = any> extends HookContext<T> {
+    _loaders: any;
+}
+
+export type SimpleResolver<T> = (...args: any[]) => (item: T, context: ResolverContext) => Promise<any>;
 
 export interface RecursiveResolver<T> {
     resolver: SimpleResolver<T>;
     joins: ResolverMap<any>;
 }
 
 export interface ResolverMap<T> {
-    after?: AsyncContextFunction<void>;
-    before?: AsyncContextFunction<void>;
+    after?: (context: ResolverContext) => void | Promise<void>;
+    before?: (context: ResolverContext) => void | Promise<void>;
     joins: {
         [property: string]: SimpleResolver<T> | RecursiveResolver<T>;
     };

types/tests.ts

@@ -181,6 +181,21 @@ const postResolvers: ResolverMap<any> = {
     }
 };
 
+const userResolvers: ResolverMap<any> = {
+    joins: {
+        memberships: () => async (user, context) => {
+            const memberships: any = (await context.app!.service
+            ('memberships').find({query: {
+                    user: user._id,
+                    $populate: 'role',
+                }}));
+            user.memberships = memberships.data;
+        }
+    }
+};
+
+// $ExpectType Hook
+fastJoin(userResolvers);
 // $ExpectType Hook
 fastJoin(postResolvers);
 // $ExpectType Hook