Fix testcontainers cleanup (#2023)

* update testcontainers packages

* increase cleanup timeout and add better logs

* small tweaks

* decrease docker network size so we can have more of them

* add a test flow to check this all works

* await all engine.quit calls

* add docker diagnostics

* reduce number of test runs

* improve network attachment output

* add setup logs

* log redis setup errors

* add cleanup log type

* stop redis container if setup fails

* disable ipv6

* tidy things up a bit

* fix unit tests workflow

* decrease container cleanup timeout

* fix types

* fix webapp typecheck

Author: nicktrn

.github/workflows/unit-tests.yml

@@ -8,6 +8,32 @@ jobs:
     name: "🧪 Unit Tests"
     runs-on: ubuntu-latest
     steps:
+      - name: 🔧 Disable IPv6
+        run: |
+          sudo sysctl -w net.ipv6.conf.all.disable_ipv6=1
+          sudo sysctl -w net.ipv6.conf.default.disable_ipv6=1
+          sudo sysctl -w net.ipv6.conf.lo.disable_ipv6=1
+
+      - name: 🔧 Configure docker address pool
+        run: |
+          CONFIG='{
+            "default-address-pools" : [
+              {
+                "base" : "172.17.0.0/12",
+                "size" : 20
+              },
+              {
+                "base" : "192.168.0.0/16",
+                "size" : 24
+              }
+            ]
+          }'
+          mkdir -p /etc/docker
+          echo "$CONFIG" | sudo tee /etc/docker/daemon.json
+
+      - name: 🔧 Restart docker daemon
+        run: sudo systemctl restart docker
+
       - name: ⬇️ Checkout repo
         uses: actions/checkout@v4
         with:

apps/webapp/tsconfig.check.json

@@ -1,6 +1,8 @@
 {
   "extends": "./tsconfig.json",
   "compilerOptions": {
+    "lib": ["DOM", "DOM.Iterable", "DOM.AsyncIterable", "ES2022"],
+    "target": "ES2022",
     "noEmit": true,
     "paths": {
       "~/*": ["./app/*"],

internal-packages/run-engine/src/engine/tests/attemptFailures.test.ts

@@ -155,7 +155,7 @@ describe("RunEngine attempt failures", () => {
       expect(executionData4.run.attemptNumber).toBe(2);
       expect(executionData4.run.status).toBe("COMPLETED_SUCCESSFULLY");
     } finally {
-      engine.quit();
+      await engine.quit();
     }
   });
 
@@ -266,7 +266,7 @@ describe("RunEngine attempt failures", () => {
       expect(executionData3.run.attemptNumber).toBe(1);
       expect(executionData3.run.status).toBe("COMPLETED_WITH_ERRORS");
     } finally {
-      engine.quit();
+      await engine.quit();
     }
   });
 
@@ -375,7 +375,7 @@ describe("RunEngine attempt failures", () => {
       expect(executionData3.run.attemptNumber).toBe(1);
       expect(executionData3.run.status).toBe("CRASHED");
     } finally {
-      engine.quit();
+      await engine.quit();
     }
   });
 
@@ -482,7 +482,7 @@ describe("RunEngine attempt failures", () => {
       expect(executionData.run.attemptNumber).toBe(1);
       expect(executionData.run.status).toBe("CRASHED");
     } finally {
-      engine.quit();
+      await engine.quit();
     }
   });
 
@@ -639,7 +639,7 @@ describe("RunEngine attempt failures", () => {
       expect(executionData4.run.attemptNumber).toBe(2);
       expect(executionData4.run.status).toBe("COMPLETED_SUCCESSFULLY");
     } finally {
-      engine.quit();
+      await engine.quit();
     }
   });
 
@@ -803,7 +803,7 @@ describe("RunEngine attempt failures", () => {
       expect(finalExecutionData.run.attemptNumber).toBe(2);
       expect(finalExecutionData.run.status).toBe("CRASHED");
     } finally {
-      engine.quit();
+      await engine.quit();
     }
   });
 });

internal-packages/run-engine/src/engine/tests/batchTrigger.test.ts

@@ -177,7 +177,7 @@ describe("RunEngine batchTrigger", () => {
       });
       expect(batchAfter2?.status).toBe("COMPLETED");
     } finally {
-      engine.quit();
+      await engine.quit();
     }
   });
 });

internal-packages/run-engine/src/engine/tests/batchTriggerAndWait.test.ts

@@ -352,7 +352,7 @@ describe("RunEngine batchTriggerAndWait", () => {
       });
       expect(batchAfter?.status === "COMPLETED");
     } finally {
-      engine.quit();
+      await engine.quit();
     }
   });
 
@@ -570,7 +570,7 @@ describe("RunEngine batchTriggerAndWait", () => {
         );
         expect(parentAfterTriggerAndWait.batch).toBeUndefined();
       } finally {
-        engine.quit();
+        await engine.quit();
       }
     }
   );

internal-packages/run-engine/src/engine/tests/cancelling.test.ts

@@ -220,7 +220,7 @@ describe("RunEngine cancelling", () => {
         );
         expect(envConcurrencyCompleted).toBe(0);
       } finally {
-        engine.quit();
+        await engine.quit();
       }
     }
   );
@@ -321,7 +321,7 @@ describe("RunEngine cancelling", () => {
       );
       expect(envConcurrencyCompleted).toBe(0);
     } finally {
-      engine.quit();
+      await engine.quit();
     }
   });
 

internal-packages/run-engine/src/engine/tests/checkpoints.test.ts

@@ -1375,7 +1375,7 @@ describe("RunEngine checkpoints", () => {
       });
       expect(batchAfter?.status === "COMPLETED");
     } finally {
-      engine.quit();
+      await engine.quit();
     }
   });
 });

internal-packages/run-engine/src/engine/tests/delays.test.ts

@@ -86,7 +86,7 @@ describe("RunEngine delays", () => {
       assertNonNullable(executionData2);
       expect(executionData2.snapshot.executionStatus).toBe("QUEUED");
     } finally {
-      engine.quit();
+      await engine.quit();
     }
   });
 
@@ -183,7 +183,7 @@ describe("RunEngine delays", () => {
       assertNonNullable(executionData3);
       expect(executionData3.snapshot.executionStatus).toBe("QUEUED");
     } finally {
-      engine.quit();
+      await engine.quit();
     }
   });
 
@@ -287,7 +287,7 @@ describe("RunEngine delays", () => {
 
       expect(run3.status).toBe("EXPIRED");
     } finally {
-      engine.quit();
+      await engine.quit();
     }
   });
 
@@ -398,7 +398,7 @@ describe("RunEngine delays", () => {
       expect(executionData4.snapshot.executionStatus).toBe("FINISHED");
       expect(executionData4.run.status).toBe("CANCELED");
     } finally {
-      engine.quit();
+      await engine.quit();
     }
   });
 });

internal-packages/run-engine/src/engine/tests/dequeuing.test.ts

@@ -77,7 +77,7 @@ describe("RunEngine dequeuing", () => {
 
       expect(dequeued.length).toBe(5);
     } finally {
-      engine.quit();
+      await engine.quit();
     }
   });
 
@@ -169,7 +169,7 @@ describe("RunEngine dequeuing", () => {
         const queueLength3 = await engine.runQueue.lengthOfEnvQueue(authenticatedEnvironment);
         expect(queueLength3).toBe(12);
       } finally {
-        engine.quit();
+        await engine.quit();
       }
     }
   );

internal-packages/run-engine/src/engine/tests/pendingVersion.test.ts

@@ -158,7 +158,7 @@ describe("RunEngine pending version", () => {
         );
         expect(queueLength2).toBe(2);
       } finally {
-        engine.quit();
+        await engine.quit();
       }
     }
   );
@@ -319,7 +319,7 @@ describe("RunEngine pending version", () => {
         );
         expect(queueLength3).toBe(1);
       } finally {
-        engine.quit();
+        await engine.quit();
       }
     }
   );