logs-page-fixes (#2889)

* Removed EVENT_REPOSITORY_CLICKHOUSE_ROLLOUT_PERCENT
* Added hasLogsPageAccess featureFlag for logs page
* Replaced attributes with attributes_text for logs to reduce memory
usage and improve query performance
* Added support for event_v1 for logs, now depending on the settings the
logs are fetched either from `task_events_v1` or `task_events_v2`
* Show an error in the interface in cast the repository store is
`postgres`

Author: mpcgrid

apps/webapp/app/components/logs/LogsTable.tsx

@@ -27,7 +27,6 @@ import { PopoverMenuItem } from "~/components/primitives/Popover";
 
 type LogsTableProps = {
   logs: LogEntry[];
-  hasFilters: boolean;
   searchTerm?: string;
   isLoading?: boolean;
   isLoadingMore?: boolean;
@@ -59,7 +58,6 @@ function getLevelBorderColor(level: LogEntry["level"]): string {
 
 export function LogsTable({
   logs,
-  hasFilters,
   searchTerm,
   isLoading = false,
   isLoadingMore = false,
@@ -126,11 +124,7 @@ export function LogsTable({
           </TableRow>
         </TableHeader>
         <TableBody>
-          {logs.length === 0 && !hasFilters ? (
-            <TableBlankRow colSpan={6}>
-              {!isLoading && <NoLogs title="No logs found" />}
-            </TableBlankRow>
-          ) : logs.length === 0 ? (
+          {logs.length === 0 ? (
             <BlankState isLoading={isLoading} onRefresh={() => window.location.reload()} />
           ) : (
             logs.map((log) => {
@@ -214,14 +208,6 @@ export function LogsTable({
   );
 }
 
-function NoLogs({ title }: { title: string }) {
-  return (
-    <div className="flex items-center justify-center">
-      <Paragraph className="w-auto">{title}</Paragraph>
-    </div>
-  );
-}
-
 function BlankState({ isLoading, onRefresh }: { isLoading?: boolean; onRefresh?: () => void }) {
   if (isLoading) return <TableBlankRow colSpan={6}></TableBlankRow>;
 

apps/webapp/app/components/navigation/SideMenu.tsx

@@ -269,7 +269,7 @@ export function SideMenu({
               to={v3DeploymentsPath(organization, project, environment)}
               data-action="deployments"
             />
-            {(isAdmin || user.isImpersonating) && (
+            {(user.admin || user.isImpersonating || featureFlags.hasLogsPageAccess) && (
               <SideMenuItem
                 name="Logs"
                 icon={LogsIcon}

apps/webapp/app/env.server.ts

@@ -1220,7 +1220,6 @@ const EnvironmentSchema = z
       .number()
       .int()
       .default(60_000 * 5), // 5 minutes
-    EVENT_REPOSITORY_CLICKHOUSE_ROLLOUT_PERCENT: z.coerce.number().optional(),
     EVENT_REPOSITORY_DEFAULT_STORE: z
       .enum(["postgres", "clickhouse", "clickhouse_v2"])
       .default("postgres"),

apps/webapp/app/presenters/v3/LogDetailPresenter.server.ts

@@ -2,6 +2,8 @@ import { type ClickHouse } from "@internal/clickhouse";
 import { type PrismaClientOrTransaction } from "@trigger.dev/database";
 import { convertClickhouseDateTime64ToJsDate } from "~/v3/eventRepository/clickhouseEventRepository.server";
 import { kindToLevel } from "~/utils/logUtils";
+import { getConfiguredEventRepository } from "~/v3/eventRepository/index.server";
+import { ServiceValidationError } from "~/v3/services/baseService.server";
 
 export type LogDetailOptions = {
   environmentId: string;
@@ -24,8 +26,20 @@ export class LogDetailPresenter {
   public async call(options: LogDetailOptions) {
     const { environmentId, organizationId, projectId, spanId, traceId, startTime } = options;
 
-    // Build ClickHouse query
-    const queryBuilder = this.clickhouse.taskEventsV2.logDetailQueryBuilder();
+    // Determine which store to use based on organization configuration
+    const { store } = await getConfiguredEventRepository(organizationId);
+
+    // Throw error if postgres is detected
+    if (store === "postgres") {
+      throw new ServiceValidationError(
+        "Log details are not available for PostgreSQL event store. Please contact support."
+      );
+    }
+
+    const isClickhouseV2 = store === "clickhouse_v2";
+    const queryBuilder = isClickhouseV2
+      ? this.clickhouse.taskEventsV2.logDetailQueryBuilder()
+      : this.clickhouse.taskEvents.logDetailQueryBuilder();
 
     // Required filters - spanId, traceId, and startTime uniquely identify the log
     // Multiple events can share the same spanId (span, span events, logs), so startTime is needed
@@ -55,29 +69,16 @@ export class LogDetailPresenter {
 
     const log = records[0];
 
-    // Parse metadata and attributes
-    let parsedMetadata: Record<string, unknown> = {};
+
     let parsedAttributes: Record<string, unknown> = {};
     let rawAttributesString = "";
 
-    try {
-      if (log.metadata) {
-        parsedMetadata = JSON.parse(log.metadata) as Record<string, unknown>;
-      }
-    } catch {
-      // Ignore parse errors
-    }
 
     try {
-      // Handle attributes which could be a JSON object or string
-      if (log.attributes) {
-        if (typeof log.attributes === "string") {
-          parsedAttributes = JSON.parse(log.attributes) as Record<string, unknown>;
-          rawAttributesString = log.attributes;
-        } else if (typeof log.attributes === "object") {
-          parsedAttributes = log.attributes as Record<string, unknown>;
-          rawAttributesString = JSON.stringify(log.attributes);
-        }
+      // Handle attributes_text which is a string
+      if (log.attributes_text) {
+        parsedAttributes = JSON.parse(log.attributes_text) as Record<string, unknown>;
+        rawAttributesString = log.attributes_text;
       }
     } catch {
       // Ignore parse errors
@@ -97,10 +98,8 @@ export class LogDetailPresenter {
       status: log.status,
       duration: typeof log.duration === "number" ? log.duration : Number(log.duration),
       level: kindToLevel(log.kind, log.status),
-      metadata: parsedMetadata,
       attributes: parsedAttributes,
       // Raw strings for display
-      rawMetadata: log.metadata,
       rawAttributes: rawAttributesString,
     };
   }

apps/webapp/app/presenters/v3/LogsListPresenter.server.ts

@@ -2,12 +2,11 @@ import { z } from "zod";
 import { type ClickHouse, type LogsListResult } from "@internal/clickhouse";
 import { MachinePresetName } from "@trigger.dev/core/v3";
 import {
-  type PrismaClient,
   type PrismaClientOrTransaction,
   type TaskRunStatus,
   TaskRunStatus as TaskRunStatusEnum,
-  TaskTriggerSource,
 } from "@trigger.dev/database";
+import { getConfiguredEventRepository } from "~/v3/eventRepository/index.server";
 
 // Create a schema that validates TaskRunStatus enum values
 const TaskRunStatusSchema = z.array(z.nativeEnum(TaskRunStatusEnum));
@@ -18,11 +17,12 @@ import { findDisplayableEnvironment } from "~/models/runtimeEnvironment.server";
 import { getAllTaskIdentifiers } from "~/models/task.server";
 import { RunsRepository } from "~/services/runsRepository/runsRepository.server";
 import { ServiceValidationError } from "~/v3/services/baseService.server";
+import { kindToLevel, type LogLevel, LogLevelSchema } from "~/utils/logUtils";
+import { BasePresenter } from "~/presenters/v3/basePresenter.server";
 import {
   convertDateToClickhouseDateTime,
   convertClickhouseDateTime64ToJsDate,
 } from "~/v3/eventRepository/clickhouseEventRepository.server";
-import { kindToLevel, type LogLevel, LogLevelSchema } from "~/utils/logUtils";
 
 export type { LogLevel };
 
@@ -131,9 +131,7 @@ function decodeCursor(cursor: string): LogCursor | null {
 }
 
 // Convert display level to ClickHouse kinds and statuses
-function levelToKindsAndStatuses(
-  level: LogLevel
-): { kinds?: string[]; statuses?: string[] } {
+function levelToKindsAndStatuses(level: LogLevel): { kinds?: string[]; statuses?: string[] } {
   switch (level) {
     case "DEBUG":
       return { kinds: ["DEBUG_EVENT", "LOG_DEBUG"] };
@@ -150,7 +148,6 @@ function levelToKindsAndStatuses(
   }
 }
 
-
 function convertDateToNanoseconds(date: Date): bigint {
   return BigInt(date.getTime()) * 1_000_000n;
 }
@@ -168,11 +165,13 @@ function formatNanosecondsForClickhouse(ns: bigint): string {
   return padded.slice(0, 10) + "." + padded.slice(10);
 }
 
-export class LogsListPresenter {
+export class LogsListPresenter extends BasePresenter {
   constructor(
     private readonly replica: PrismaClientOrTransaction,
     private readonly clickhouse: ClickHouse
-  ) {}
+  ) {
+    super(undefined, replica);
+  }
 
   public async call(
     organizationId: string,
@@ -242,10 +241,7 @@ export class LogsListPresenter {
       (search !== undefined && search !== "") ||
       !time.isDefault;
 
-    const possibleTasksAsync = getAllTaskIdentifiers(
-      this.replica,
-      environmentId
-    );
+    const possibleTasksAsync = getAllTaskIdentifiers(this.replica, environmentId);
 
     const bulkActionsAsync = this.replica.bulkActionGroup.findMany({
       select: {
@@ -264,31 +260,26 @@ export class LogsListPresenter {
       take: 20,
     });
 
-    const [possibleTasks, bulkActions, displayableEnvironment] =
-      await Promise.all([
-        possibleTasksAsync,
-        bulkActionsAsync,
-        findDisplayableEnvironment(environmentId, userId),
-      ]);
-
-    if (
-      bulkId &&
-      !bulkActions.some((bulkAction) => bulkAction.friendlyId === bulkId)
-    ) {
-      const selectedBulkAction =
-        await this.replica.bulkActionGroup.findFirst({
-          select: {
-            friendlyId: true,
-            type: true,
-            createdAt: true,
-            name: true,
-          },
-          where: {
-            friendlyId: bulkId,
-            projectId,
-            environmentId,
-          },
-        });
+    const [possibleTasks, bulkActions, displayableEnvironment] = await Promise.all([
+      possibleTasksAsync,
+      bulkActionsAsync,
+      findDisplayableEnvironment(environmentId, userId),
+    ]);
+
+    if (bulkId && !bulkActions.some((bulkAction) => bulkAction.friendlyId === bulkId)) {
+      const selectedBulkAction = await this.replica.bulkActionGroup.findFirst({
+        select: {
+          friendlyId: true,
+          type: true,
+          createdAt: true,
+          name: true,
+        },
+        where: {
+          friendlyId: bulkId,
+          projectId,
+          environmentId,
+        },
+      });
 
       if (selectedBulkAction) {
         bulkActions.push(selectedBulkAction);
@@ -371,7 +362,22 @@ export class LogsListPresenter {
       }
     }
 
-    const queryBuilder = this.clickhouse.taskEventsV2.logsListQueryBuilder();
+    // Determine which store to use based on organization configuration
+    const { store } = await getConfiguredEventRepository(organizationId);
+
+    // Throw error if postgres is detected
+    if (store === "postgres") {
+      throw new ServiceValidationError(
+        "Logs are not available for PostgreSQL event store. Please contact support."
+      );
+    }
+
+    // Get the appropriate query builder based on store type
+    const isClickhouseV2 = store === "clickhouse_v2";
+
+    const queryBuilder = isClickhouseV2
+      ? this.clickhouse.taskEventsV2.logsListQueryBuilder()
+      : this.clickhouse.taskEvents.logsListQueryBuilder();
 
     queryBuilder.prewhere("environment_id = {environmentId: String}", {
       environmentId,
@@ -382,12 +388,17 @@ export class LogsListPresenter {
     });
     queryBuilder.where("project_id = {projectId: String}", { projectId });
 
-    // Time filters - inserted_at in PREWHERE for partition pruning, start_time in WHERE
+    // Time filters - inserted_at in PREWHERE only for v2, start_time in WHERE for both
     if (effectiveFrom) {
       const fromNs = convertDateToNanoseconds(effectiveFrom);
-      queryBuilder.prewhere("inserted_at >= {insertedAtStart: DateTime64(3)}", {
-        insertedAtStart: convertDateToClickhouseDateTime(effectiveFrom),
-      });
+
+      // Only use inserted_at for partition pruning if v2
+      if (isClickhouseV2) {
+        queryBuilder.prewhere("inserted_at >= {insertedAtStart: DateTime64(3)}", {
+          insertedAtStart: convertDateToClickhouseDateTime(effectiveFrom),
+        });
+      }
+
       queryBuilder.where("start_time >= {fromTime: String}", {
         fromTime: formatNanosecondsForClickhouse(fromNs),
       });
@@ -396,9 +407,14 @@ export class LogsListPresenter {
     if (effectiveTo) {
       const clampedTo = effectiveTo > new Date() ? new Date() : effectiveTo;
       const toNs = convertDateToNanoseconds(clampedTo);
-      queryBuilder.prewhere("inserted_at <= {insertedAtEnd: DateTime64(3)}", {
-        insertedAtEnd: convertDateToClickhouseDateTime(clampedTo),
-      });
+
+      // Only use inserted_at for partition pruning if v2
+      if (isClickhouseV2) {
+        queryBuilder.prewhere("inserted_at <= {insertedAtEnd: DateTime64(3)}", {
+          insertedAtEnd: convertDateToClickhouseDateTime(clampedTo),
+        });
+      }
+
       queryBuilder.where("start_time <= {toTime: String}", {
         toTime: formatNanosecondsForClickhouse(toNs),
       });
@@ -428,7 +444,6 @@ export class LogsListPresenter {
       );
     }
 
-
     if (levels && levels.length > 0) {
       const conditions: string[] = [];
       const params: Record<string, string[]> = {};
@@ -477,7 +492,6 @@ export class LogsListPresenter {
 
     queryBuilder.where("NOT (kind = 'SPAN' AND status = 'PARTIAL')");
 
-
     // Cursor pagination
     const decodedCursor = cursor ? decodeCursor(cursor) : null;
     if (decodedCursor) {
@@ -525,11 +539,11 @@ export class LogsListPresenter {
       let displayMessage = log.message;
 
       // For error logs with status ERROR, try to extract error message from attributes
-      if (log.status === "ERROR" && log.attributes) {
+      if (log.status === "ERROR" && log.attributes_text) {
         try {
-          let attributes = log.attributes as ErrorAttributes;
+          const attributes = JSON.parse(log.attributes_text) as ErrorAttributes;
 
-          if (attributes?.error?.message && typeof attributes.error.message === 'string') {
+          if (attributes?.error?.message && typeof attributes.error.message === "string") {
             displayMessage = attributes.error.message;
           }
         } catch {