Skip to content

Commit 10f2365

Browse files
committed
A couple of improvements
1 parent 1ce1260 commit 10f2365

File tree

2 files changed

+18
-7
lines changed

2 files changed

+18
-7
lines changed

apps/webapp/app/utils/requestIdempotency.server.ts

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { json } from "@remix-run/server-runtime";
2+
import { tryCatch } from "@trigger.dev/core/utils";
23
import { logger } from "~/services/logger.server";
34
import { requestIdempotency } from "~/services/requestIdempotencyInstance.server";
45
import { startActiveSpan } from "~/v3/tracer.server";
@@ -78,7 +79,18 @@ export async function saveRequestIdempotency(
7879
return;
7980
}
8081

81-
await requestIdempotency.saveRequest(requestType, requestIdempotencyKey, {
82-
id: entityId,
83-
});
82+
const [error] = await tryCatch(
83+
requestIdempotency.saveRequest(requestType, requestIdempotencyKey, {
84+
id: entityId,
85+
})
86+
);
87+
88+
if (error) {
89+
logger.error("request-idempotency: error saving request", {
90+
error,
91+
requestIdempotencyKey,
92+
requestType,
93+
entityId,
94+
});
95+
}
8496
}

apps/webapp/app/v3/services/triggerTask.server.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,12 @@
11
import { TriggerTaskRequestBody } from "@trigger.dev/core/v3";
22
import { RunEngineVersion, TaskRun } from "@trigger.dev/database";
3+
import { env } from "~/env.server";
34
import { IdempotencyKeyConcern } from "~/runEngine/concerns/idempotencyKeys.server";
45
import { DefaultPayloadProcessor } from "~/runEngine/concerns/payloads.server";
56
import { DefaultQueueManager } from "~/runEngine/concerns/queues.server";
7+
import { DefaultRunChainStateManager } from "~/runEngine/concerns/runChainStates.server";
68
import { DefaultRunNumberIncrementer } from "~/runEngine/concerns/runNumbers.server";
9+
import { DefaultTraceEventsConcern } from "~/runEngine/concerns/traceEvents.server";
710
import { RunEngineTriggerTaskService } from "~/runEngine/services/triggerTask.server";
811
import { DefaultTriggerTaskValidator } from "~/runEngine/validators/triggerTaskValidator";
912
import { AuthenticatedEnvironment } from "~/services/apiAuth.server";
@@ -12,10 +15,6 @@ import { eventRepository } from "../eventRepository.server";
1215
import { tracer } from "../tracer.server";
1316
import { WithRunEngine } from "./baseService.server";
1417
import { TriggerTaskServiceV1 } from "./triggerTaskV1.server";
15-
import { DefaultTraceEventsConcern } from "~/runEngine/concerns/traceEvents.server";
16-
import { DefaultRunChainStateManager } from "~/runEngine/concerns/runChainStates.server";
17-
import { env } from "~/env.server";
18-
import { Evt } from "evt";
1918

2019
export type TriggerTaskServiceOptions = {
2120
idempotencyKey?: string;

0 commit comments

Comments
 (0)