refactor(webapp): modularize reconciliation logic and move tests to conventional location

Author: bharathkumar39293

apps/webapp/app/presenters/v3/RunPresenter.server.ts

@@ -220,16 +220,6 @@ export class RunPresenter {
         let nDuration = n.data.duration;
         let nIsError = n.data.isError;
 
-        // NOTE: Clickhouse trace ingestion is eventually consistent.
-        // When a run is marked finished in Postgres, we reconcile the
-        // root span to reflect completion even if telemetry is still partial.
-        // This is a deliberate UI-layer tradeoff to prevent stale or "stuck"
-        // run states in the dashboard.
-        if (isRoot && runData.isFinished && nIsPartial) {
-          nIsPartial = false;
-          nDuration = Math.max(nDuration ?? 0, postgresRunDuration);
-          nIsError = isFailedRunStatus(runData.status);
-        }
 
         //only let non-debug events extend the total duration
         if (!n.data.isDebug) {

apps/webapp/test/RunPresenter.test.ts …senters/v3/reconcileTrace.server.test.tsapps/webapp/test/RunPresenter.test.ts renamed to apps/webapp/app/presenters/v3/reconcileTrace.server.test.ts apps/webapp/test/RunPresenter.test.ts renamed to apps/webapp/app/presenters/v3/reconcileTrace.server.test.ts

@@ -1,30 +1,5 @@
-import { vi, describe, it, expect } from "vitest";
-
-vi.mock("../app/env.server", () => ({
-    env: {
-        MAXIMUM_LIVE_RELOADING_EVENTS: 1000,
-    },
-}));
-
-vi.mock("../app/db.server", () => ({
-    prisma: {},
-    $replica: {},
-    $transaction: vi.fn(),
-}));
-
-vi.mock("../app/v3/eventRepository/index.server", () => ({
-    resolveEventRepositoryForStore: vi.fn(),
-}));
-
-vi.mock("../app/v3/taskEventStore.server", () => ({
-    getTaskEventStoreTableForRun: vi.fn(),
-}));
-
-vi.mock("../app/utils/username", () => ({
-    getUsername: vi.fn(),
-}));
-
-import { reconcileTraceWithRunLifecycle } from "../app/presenters/v3/reconcileTrace.server";
+import { describe, it, expect } from "vitest";
+import { reconcileTraceWithRunLifecycle } from "./reconcileTrace.server";
 import { millisecondsToNanoseconds } from "@trigger.dev/core/v3";
 
 describe("reconcileTraceWithRunLifecycle", () => {

apps/webapp/vitest.config.ts

@@ -3,7 +3,7 @@ import tsconfigPaths from "vite-tsconfig-paths";
 
 export default defineConfig({
   test: {
-    include: ["test/**/*.test.ts"],
+    include: ["test/**/*.test.ts", "app/**/*.test.ts"],
     globals: true,
     pool: "forks",
   },