Skip to content

Commit 18a0282

Browse files
committed
set the jobkey as event:event.id
1 parent ef1a1ff commit 18a0282

File tree

3 files changed

+17
-11
lines changed

3 files changed

+17
-11
lines changed

apps/webapp/app/routes/api.v1.events.$eventId.cancel.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ export async function action({ request, params }: ActionArgs) {
4444

4545
return json(updatedEvent);
4646
} catch (err) {
47-
//send the error
4847
logger.error("CancelEventService.call() error", {
4948
error: err,
5049
});

apps/webapp/app/services/events/cancelEvent.server.ts

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
1-
import type { EventDispatcher, EventRecord } from "@trigger.dev/database";
2-
import type { EventFilter } from "@trigger.dev/core";
3-
import { EventFilterSchema, eventFilterMatches } from "@trigger.dev/core";
1+
import type { EventRecord } from "@trigger.dev/database";
42
import { $transaction, PrismaClientOrTransaction, prisma } from "~/db.server";
5-
import { logger } from "~/services/logger.server";
63
import { workerQueue } from "../worker.server";
74
import { AuthenticatedEnvironment } from "../apiAuth.server";
85

@@ -13,17 +10,21 @@ export class CancelEventService {
1310
this.#prismaClient = prismaClient;
1411
}
1512

16-
public async call(environment: AuthenticatedEnvironment, eventId: string): Promise<EventRecord | undefined> {
13+
public async call(
14+
environment: AuthenticatedEnvironment,
15+
eventId: string
16+
): Promise<EventRecord | undefined> {
1717
return await $transaction(
1818
this.#prismaClient,
1919
async (tx) => {
20-
const event = await tx.eventRecord.findFirst({
20+
const event = await tx.eventRecord.findUnique({
2121
select: {
2222
id: true,
2323
name: true,
2424
createdAt: true,
2525
updatedAt: true,
2626
environmentId: true,
27+
cancelledAt: true,
2728
runs: {
2829
select: {
2930
id: true,
@@ -34,23 +35,29 @@ export class CancelEventService {
3435
},
3536
},
3637
where: {
37-
id: eventId,
38-
environmentId: environment.id,
38+
eventId_environmentId: {
39+
eventId: eventId,
40+
environmentId: environment.id,
41+
},
3942
},
4043
});
4144

4245
if (!event) {
4346
return;
4447
}
4548

49+
if (event.cancelledAt) {
50+
return event;
51+
}
52+
4653
//update the cancelledAt column in the eventRecord table
4754
const updatedEvent = await prisma.eventRecord.update({
4855
where: { id: event.id },
4956
data: { cancelledAt: new Date() },
5057
});
5158

5259
// Dequeue the event after the db has been updated
53-
await workerQueue.dequeue(event.id, { tx: prisma });
60+
await workerQueue.dequeue(`event:${event.id}`, { tx: prisma });
5461

5562
return updatedEvent;
5663
},

apps/webapp/app/services/events/ingestSendEvent.server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ export class IngestSendEvent {
8888
{
8989
id: eventLog.id,
9090
},
91-
{ runAt: eventLog.deliverAt, tx, jobKey: eventLog.id }
91+
{ runAt: eventLog.deliverAt, tx, jobKey: `event:${eventLog.id}` }
9292
);
9393
}
9494

0 commit comments

Comments
 (0)