rename snapshot manager stop

Author: nicktrn

packages/cli-v3/src/entryPoints/managed/execution.ts

@@ -1034,8 +1034,7 @@ export class RunExecution {
     this.shutdownReason = reason;
 
     this.snapshotPoller?.stop();
-    this.snapshotManager?.dispose();
-
+    this.snapshotManager?.stop();
     this.notifier?.stop();
 
     this.taskRunProcess?.unsafeDetachEvtHandlers();

packages/cli-v3/src/entryPoints/managed/snapshot.test.ts

@@ -313,7 +313,7 @@ describe("SnapshotManager", () => {
     expect(manager.queueLength).not.toBe(0);
 
     // Dispose manager before any promises complete
-    manager.dispose();
+    manager.stop();
 
     expect(manager.queueLength).toBe(0);
 

packages/cli-v3/src/entryPoints/managed/snapshot.ts

@@ -371,12 +371,12 @@ export class SnapshotManager {
     }
   }
 
-  public dispose() {
-    this.sendDebugLog("dispose");
+  public stop() {
+    this.sendDebugLog("stop");
 
     // Clear any pending changes
     for (const item of this.changeQueue) {
-      item.reject(new Error("SnapshotManager disposed"));
+      item.reject(new Error("SnapshotManager stopped"));
     }
     this.changeQueue = [];
   }