Some tweaks to the rules and how they are installed

Author: ericallam

packages/cli-v3/src/commands/install-rules.ts

@@ -497,24 +497,25 @@ async function resolveRulesFileContentsForTarget(
       return $output(
         frontmatter({
           description: option.label,
-          globs: "**/trigger/**/*.ts",
-          alwaysApply: true,
+          globs: option.applyTo ?? "**/trigger/**/*.ts",
+          alwaysApply: false,
         }),
         option.contents
       );
     }
     case "vscode": {
       return $output(
         frontmatter({
-          applyTo: "**/trigger/**/*.ts",
+          applyTo: option.applyTo ?? "**/trigger/**/*.ts",
         }),
         option.contents
       );
     }
     case "windsurf": {
       return $output(
         frontmatter({
-          trigger: "manual",
+          trigger: "glob",
+          globs: option.applyTo ?? "**/trigger/**/*.ts",
         }),
         option.contents
       );

packages/cli-v3/src/rules/manifest.ts

@@ -19,6 +19,7 @@ const RulesManifestDataSchema = z.object({
           tokens: z.number(),
           client: z.string().optional(),
           installStrategy: z.string().optional(),
+          applyTo: z.string().optional(),
         })
       ),
     })
@@ -35,6 +36,7 @@ export type RulesManifestVersionOption = {
   tokens: number;
   client: string | undefined;
   installStrategy: RulesFileInstallStrategy;
+  applyTo: string | undefined;
 };
 
 export type ManifestVersion = {

rules/4.0.0/basic-tasks.md

@@ -129,6 +129,8 @@ export const childTask = task({
 });
 ```
 
+> Never wrap triggerAndWait or batchTriggerAndWait calls in a Promise.all or Promise.allSettled as this is not supported in Trigger.dev tasks.
+
 ## Waits
 
 ```ts
@@ -160,6 +162,8 @@ export const taskWithWaits = task({
 });
 ```
 
+> Never wrap wait calls in a Promise.all or Promise.allSettled as this is not supported in Trigger.dev tasks.
+
 ## Key Points
 
 - **Result vs Output**: `triggerAndWait()` returns a `Result` object with `ok`, `output`, `error` properties - NOT the direct task output

rules/4.0.0/claude-code-agent.md

@@ -7,6 +7,8 @@ color: green
 
 You are an elite Trigger.dev framework expert with deep knowledge of building production-grade background job systems. You specialize in designing reliable, scalable workflows using Trigger.dev's async-first architecture. Tasks deployed to Trigger.dev generally run in Node.js 21+ and use the `@trigger.dev/sdk` package, along with the `@trigger.dev/build` package for build extensions and the `trigger.dev` CLI package to run the `dev` server and `deploy` command.
 
+> Never use `node-fetch` in your code, use the `fetch` function that's built into Node.js.
+
 ## Design Principles
 
 When creating Trigger.dev solutions, you will:
@@ -17,6 +19,9 @@ When creating Trigger.dev solutions, you will:
 - When triggering a task from inside another task, consider whether to use the `triggerAndWait`/`batchTriggerAndWait` pattern or just the `trigger`/`batchTrigger` function. Use the "andWait" variants when the parent task needs the results of the child task.
 - When triggering a task, especially from inside another task, always consider whether to pass the `idempotencyKey` property to the `options` argument. This is especially important when inside another task and that task can be retried and you don't want to redo the work in children tasks (whether waiting for the results or not).
 - Use the `logger` system in Trigger.dev to log useful messages at key execution points.
+- Group subtasks that are only used from a single other task into the same file as the parent task, and don't export them.
+
+> Important: Never wrap triggerAndWait or batchTriggerAndWait calls in a Promise.all or Promise.allSettled as this is not supported in Trigger.dev tasks.
 
 ## Triggering tasks
 
@@ -183,12 +188,7 @@ When setting up Trigger.dev projects, you will configure the `trigger.config.ts`
 ```ts
 import { defineConfig } from "@trigger.dev/sdk";
 import { playwright } from "@trigger.dev/build/extensions/playwright";
-import {
-  ffmpeg,
-  aptGet,
-  additionalPackages,
-  additionalFiles,
-} from "@trigger.dev/build/extensions/core";
+import { ffmpeg, aptGet, additionalFiles } from "@trigger.dev/build/extensions/core";
 import { prismaExtension } from "@trigger.dev/build/extensions/prisma";
 import { pythonExtension } from "@trigger.dev/python/extension";
 import { lightpanda } from "@trigger.dev/build/extensions/lightpanda";
@@ -197,7 +197,7 @@ import { sentryEsbuildPlugin } from "@sentry/esbuild-plugin";
 
 export default defineConfig({
   project: "<project ref>",
-  // Your other config settings...
+  machine: "small-1x", // optional, default is small-1x
   build: {
     extensions: [
       playwright(),
@@ -209,9 +209,6 @@ export default defineConfig({
       }),
       pythonExtension(),
       lightpanda(),
-      additionalPackages({
-        packages: ["wrangler"],
-      }),
       esbuildPlugin(
         sentryEsbuildPlugin({
           org: process.env.SENTRY_ORG,
@@ -234,8 +231,8 @@ export default defineConfig({
 You will produce code that:
 
 - Uses modern TypeScript with strict type checking
+- When catching errors, remember that the type of the error is `unknown` and you need to check `error instanceof Error` to see if it's a real error instance
 - Follows Trigger.dev's recommended project structure
-- Implements comprehensive error handling and recovery
-- Includes inline documentation for complex logic
+- Don't go overboard with error handling
+- Write some inline documentation for complex logic
 - Uses descriptive task IDs following the pattern: 'domain.action.target'
-- Maintains separation between task logic and business logic

rules/4.0.0/config.md

@@ -27,7 +27,6 @@ export default defineConfig({
 
   // Build configuration
   build: {
-    external: ["header-generator"], // Exclude from bundling
     autoDetectExternal: true,
     keepNames: true,
     minify: false,
@@ -177,12 +176,14 @@ extensions: [
 
 #### Additional NPM Packages
 
+Only use this for installing CLI tools, NOT packages you import in your code.
+
 ```ts
 import { additionalPackages } from "@trigger.dev/build/extensions/core";
 
 extensions: [
   additionalPackages({
-    packages: ["wrangler", "[email protected]"], // CLI tools and specific versions
+    packages: ["wrangler"], // CLI tools and specific versions
   }),
 ];
 ```
@@ -337,7 +338,7 @@ extensions: [
 ## Best Practices
 
 - **Use specific versions**: Pin extension versions for reproducible builds
-- **External packages**: Add native modules to `external` array
+- **External packages**: Add modules with native addons to the `build.external` array
 - **Environment sync**: Use `syncEnvVars` for dynamic secrets
 - **File paths**: Use glob patterns for flexible file inclusion
 - **Debug builds**: Use `--log-level debug --dry-run` for troubleshooting

rules/manifest.json

@@ -22,9 +22,10 @@
         {
           "name": "config",
           "title": "Configuring Trigger.dev",
-          "label": "How to configure Trigger.dev",
+          "label": "Configure your Trigger.dev project with a trigger.config.ts file",
           "path": "4.0.0/config.md",
-          "tokens": 1900
+          "tokens": 1900,
+          "applyTo": "**/trigger.config.ts"
         },
         {
           "name": "scheduled-tasks",