Skip to content

Commit 2241270

Browse files
committed
fix fail deployment id param
1 parent f44c86a commit 2241270

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

apps/webapp/app/v3/services/failDeployment.server.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,24 +15,25 @@ const FINAL_DEPLOYMENT_STATUSES: WorkerDeploymentStatus[] = [
1515
export class FailDeploymentService extends BaseService {
1616
public async call(
1717
authenticatedEnv: AuthenticatedEnvironment,
18-
id: string,
18+
friendlyId: string,
1919
params: FailDeploymentRequestBody
2020
) {
2121
const deployment = await this._prisma.workerDeployment.findFirst({
2222
where: {
23-
friendlyId: id,
23+
friendlyId,
2424
environmentId: authenticatedEnv.id,
2525
},
2626
});
2727

2828
if (!deployment) {
29-
logger.error("Worker deployment not found", { id });
29+
logger.error("Worker deployment not found", { friendlyId });
3030
return;
3131
}
3232

3333
if (FINAL_DEPLOYMENT_STATUSES.includes(deployment.status)) {
3434
logger.error("Worker deployment already in final state", {
3535
id: deployment.id,
36+
friendlyId,
3637
status: deployment.status,
3738
});
3839
return;

apps/webapp/app/v3/services/finalizeDeployment.server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export class FinalizeDeploymentService extends BaseService {
3939
logger.error("Worker deployment does not have a worker", { id });
4040

4141
const failService = new FailDeploymentService();
42-
await failService.call(authenticatedEnv, deployment.id, {
42+
await failService.call(authenticatedEnv, deployment.friendlyId, {
4343
error: {
4444
name: "MissingWorker",
4545
message: "Deployment does not have a worker",

0 commit comments

Comments
 (0)