Make refreshing a task run process work correctly

Author: ericallam

packages/cli-v3/src/entryPoints/managed/taskRunProcessProvider.ts

@@ -90,13 +90,17 @@ export class TaskRunProcessProvider {
         : "keep-alive disabled",
     });
 
+    const existingPersistentProcess = this.persistentProcess;
+
     // Clean up old persistent process if it exists
-    if (this.persistentProcess) {
-      await this.cleanupPersistentProcess();
+    if (existingPersistentProcess) {
+      await this.cleanupProcess(existingPersistentProcess);
     }
 
-    const newProcess = this.createTaskRunProcess(opts);
-    return newProcess;
+    this.persistentProcess = this.createTaskRunProcess(opts);
+    this.executionCount = 0;
+
+    return this.persistentProcess;
   }
 
   /**
@@ -160,7 +164,9 @@ export class TaskRunProcessProvider {
    */
   cleanup(): void {
     if (this.persistentProcess) {
-      this.cleanupPersistentProcess();
+      this.sendDebugLog("cleanup() called");
+
+      this.cleanupProcess(this.persistentProcess);
     }
   }
 
@@ -227,14 +233,11 @@ export class TaskRunProcessProvider {
     return process.isPreparedForNextRun || process.isPreparedForNextAttempt;
   }
 
-  private async cleanupPersistentProcess(): Promise<void> {
-    if (this.persistentProcess) {
-      this.sendDebugLog("Cleaning up persistent TaskRunProcess");
+  private async cleanupProcess(taskRunProcess: TaskRunProcess): Promise<void> {
+    if (taskRunProcess) {
+      this.sendDebugLog("Cleaning up TaskRunProcess", { pid: taskRunProcess.pid });
 
-      // Don't await this - let it cleanup in the background
-      await this.persistentProcess.kill("SIGKILL").catch(() => {});
-      this.persistentProcess = null;
-      this.executionCount = 0;
+      await taskRunProcess.kill("SIGKILL").catch(() => {});
     }
   }
 

packages/cli-v3/src/executions/taskRunProcess.ts

@@ -170,6 +170,12 @@ export class TaskRunProcess {
 
     this._childPid = this._child?.pid;
 
+    logger.debug("initialized task run process", {
+      path: workerManifest.workerEntryPoint,
+      cwd,
+      pid: this._childPid,
+    });
+
     this._ipc = new ZodIpcConnection({
       listenSchema: ExecutorToWorkerMessageCatalog,
       emitSchema: WorkerToExecutorMessageCatalog,
@@ -303,7 +309,7 @@ export class TaskRunProcess {
   }
 
   async #handleExit(code: number | null, signal: NodeJS.Signals | null) {
-    logger.debug("handling child exit", { code, signal });
+    logger.debug("handling child exit", { code, signal, pid: this.pid });
 
     // Go through all the attempts currently pending and reject them
     for (const [id, status] of this._attemptStatuses.entries()) {

references/hello-world/trigger.config.ts

@@ -4,7 +4,10 @@ import { syncEnvVars } from "@trigger.dev/build/extensions/core";
 export default defineConfig({
   compatibilityFlags: ["run_engine_v2"],
   project: "proj_rrkpdguyagvsoktglnod",
-  experimental_processKeepAlive: true,
+  experimental_processKeepAlive: {
+    enabled: true,
+    maxExecutionsPerProcess: 3,
+  },
   logLevel: "log",
   maxDuration: 3600,
   retries: {