a couple of coderabbit fixes

Author: ericallam

apps/webapp/app/routes/api.v1.projects.$projectRef.dev-status.ts

@@ -1,4 +1,4 @@
-import { json, type LoaderFunctionArgs } from "@remix-run/server-runtime";
+import { json, type LoaderFunctionArgs } from "@remix-run/node";
 import { z } from "zod";
 import { prisma } from "~/db.server";
 import { devPresence } from "~/presenters/v3/DevPresence.server";
@@ -9,8 +9,6 @@ const ParamsSchema = z.object({
   projectRef: z.string(),
 });
 
-type ParamsSchema = z.infer<typeof ParamsSchema>;
-
 export async function loader({ request, params }: LoaderFunctionArgs) {
   const authenticationResult = await authenticateApiRequestWithPersonalAccessToken(request);
 

packages/cli-v3/src/mcp/context.ts

@@ -119,8 +119,8 @@ export class McpContext {
     // If cwd is a path to the actual trigger.config.ts file, then we should set the cwd to the directory of the file
     let $cwd = cwd ? (path.extname(cwd) !== "" ? path.dirname(cwd) : cwd) : undefined;
 
-    function isRelativePath(path: string) {
-      return !path.startsWith("/");
+    function isRelativePath(filePath: string) {
+      return !path.isAbsolute(filePath);
     }
 
     if (!cwd) {

packages/cli-v3/src/mcp/tools/deploys.ts

@@ -146,7 +146,11 @@ async function resolveCLIExec(context: McpContext, cwd?: string): Promise<[strin
       sdkVersion,
     });
 
-    return [process.argv[0] ?? "npx", process.argv[1] ?? "trigger.dev@latest"];
+    if (typeof process.argv[0] === "string" && typeof process.argv[1] === "string") {
+      return [process.argv[0], process.argv[1]];
+    }
+
+    return ["npx", "trigger.dev@latest"];
   }
 
   return ["npx", `trigger.dev@${sdkVersion}`];

packages/cli-v3/src/mcp/tools/orgs.ts

@@ -141,62 +141,70 @@ export const initializeProjectTool = {
   handler: toolHandler(InitializeProjectInput.shape, async (input, { ctx }) => {
     ctx.logger?.log("calling initialize_project", { input });
 
-    const cwd = input.cwd ?? (await ctx.getCwd());
+    let projectRef: string | undefined = input.projectRef;
 
-    if (!cwd) {
-      return respondWithError(
-        "No current working directory found. Please provide a projectRef or a cwd."
-      );
-    }
+    if (!projectRef) {
+      const cwd = input.cwd ?? (await ctx.getCwd());
 
-    // Try to load the config file
-    const [_, config] = await tryCatch(loadConfig({ cwd }));
-
-    if (config?.configFile) {
-      if (typeof config.project === "string" && config.project.startsWith("proj_")) {
-        ctx.logger?.log("initialize_project existing project", {
-          config,
-          projectRef: config.project,
-        });
-
-        return {
-          content: [
-            {
-              type: "text",
-              text: `We found an existing trigger.config.ts file in the current working directory. Skipping initialization.`,
-            },
-          ],
-        };
-      } else {
+      if (!cwd) {
         return respondWithError(
-          "Could not find the project ref in the config file. Please provide a projectRef."
+          "No current working directory found. Please provide a projectRef or a cwd."
         );
       }
-    }
 
-    const cliApiClient = await ctx.getCliApiClient();
+      // Try to load the config file
+      const [_, config] = await tryCatch(loadConfig({ cwd }));
+
+      if (config?.configFile) {
+        if (typeof config.project === "string" && config.project.startsWith("proj_")) {
+          ctx.logger?.log("initialize_project existing project", {
+            config,
+            projectRef: config.project,
+          });
+
+          return {
+            content: [
+              {
+                type: "text",
+                text: `We found an existing trigger.config.ts file in the current working directory. Skipping initialization.`,
+              },
+            ],
+          };
+        } else {
+          return respondWithError(
+            "Could not find the project ref in the config file. Please provide a projectRef."
+          );
+        }
+      }
 
-    const project = await cliApiClient.createProject(input.orgParam, {
-      name: input.projectName,
-    });
+      const cliApiClient = await ctx.getCliApiClient();
 
-    if (!project.success) {
-      return respondWithError(
-        `Failed to create project ${input.projectName} in organization ${input.orgParam}: ${project.error}`
-      );
+      const project = await cliApiClient.createProject(input.orgParam, {
+        name: input.projectName,
+      });
+
+      if (!project.success) {
+        return respondWithError(
+          `Failed to create project ${input.projectName} in organization ${input.orgParam}: ${project.error}`
+        );
+      }
+
+      ctx.logger?.log("initialize_project new project", {
+        project: project.data,
+      });
+
+      projectRef = project.data.externalRef;
     }
 
-    ctx.logger?.log("initialize_project new project", {
-      project: project.data,
-    });
+    const cliApiClient = await ctx.getCliApiClient();
 
     const projectEnv = await cliApiClient.getProjectEnv({
-      projectRef: project.data.externalRef,
+      projectRef: projectRef,
       env: "dev",
     });
 
     const manualSetupGuide = await getManualSetupGuide(
-      project.data.externalRef,
+      projectRef,
       projectEnv.success ? projectEnv.data.apiKey : undefined,
       projectEnv.success ? projectEnv.data.apiUrl : undefined
     );

packages/core/src/v3/schemas/api.ts

@@ -63,7 +63,11 @@ export const GetOrgsResponseBody = z.array(
 export type GetOrgsResponseBody = z.infer<typeof GetOrgsResponseBody>;
 
 export const CreateProjectRequestBody = z.object({
-  name: z.string(),
+  name: z
+    .string()
+    .trim()
+    .min(1, "Name is required")
+    .max(255, "Name must be less than 255 characters"),
 });
 
 export type CreateProjectRequestBody = z.infer<typeof CreateProjectRequestBody>;
@@ -1158,6 +1162,8 @@ const ApiDeploymentListPaginationCursor = z
 const ApiDeploymentListPaginationLimit = z.coerce
   .number()
   .describe("The number of deployments to return, defaults to 20 (max 100)")
+  .min(1, "Limit must be at least 1")
+  .max(100, "Limit must be less than 100")
   .optional();
 
 export const ApiDeploymentListParams = {