Skip to content

Commit 4070c6a

Browse files
committed
Fixed the name of the idempotencyKeyExpiresAt option and now default idempotency key TTL is 30 days, not 24 hours
1 parent 4b2932a commit 4070c6a

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

apps/webapp/app/routes/api.v1.tasks.$taskId.trigger.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ const { action, loader } = createActionApiRoute(
7474

7575
const run = await service.call(params.taskId, authentication.environment, body, {
7676
idempotencyKey: idempotencyKey ?? undefined,
77-
idempoencyKeyExpiresAt: idempotencyKeyExpiresAt,
77+
idempotencyKeyExpiresAt: idempotencyKeyExpiresAt,
7878
triggerVersion: triggerVersion ?? undefined,
7979
traceContext,
8080
spanParentAsLink: spanParentAsLink === 1,

apps/webapp/app/routes/api.v1.tasks.batch.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,9 +72,10 @@ const { action, loader } = createActionApiRoute(
7272
? { traceparent, tracestate }
7373
: undefined;
7474

75-
// By default, the idempotency key expires in 24 hours
75+
// By default, the idempotency key expires in 30 days
7676
const idempotencyKeyExpiresAt =
77-
resolveIdempotencyKeyTTL(idempotencyKeyTTL) ?? new Date(Date.now() + 24 * 60 * 60 * 1000);
77+
resolveIdempotencyKeyTTL(idempotencyKeyTTL) ??
78+
new Date(Date.now() + 24 * 60 * 60 * 1000 * 30);
7879

7980
const service = new BatchTriggerV2Service();
8081

apps/webapp/app/v3/services/triggerTask.server.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import { resolveIdempotencyKeyTTL } from "~/utils/idempotencyKeys.server";
2929

3030
export type TriggerTaskServiceOptions = {
3131
idempotencyKey?: string;
32-
idempoencyKeyExpiresAt?: Date;
32+
idempotencyKeyExpiresAt?: Date;
3333
triggerVersion?: string;
3434
traceContext?: Record<string, string | undefined>;
3535
spanParentAsLink?: boolean;
@@ -59,9 +59,9 @@ export class TriggerTaskService extends BaseService {
5959
// TODO: Add idempotency key expiring here
6060
const idempotencyKey = options.idempotencyKey ?? body.options?.idempotencyKey;
6161
const idempotencyKeyExpiresAt =
62-
options.idempoencyKeyExpiresAt ??
62+
options.idempotencyKeyExpiresAt ??
6363
resolveIdempotencyKeyTTL(body.options?.idempotencyKeyTTL) ??
64-
new Date(Date.now() + 24 * 60 * 60 * 1000);
64+
new Date(Date.now() + 24 * 60 * 60 * 1000 * 30); // 30 days
6565

6666
const delayUntil = await parseDelay(body.options?.delay);
6767

0 commit comments

Comments
 (0)