Skip to content

Commit 44d954a

Browse files
committed
Use the new batch service, and correct trigger task version
1 parent 33b7607 commit 44d954a

File tree

3 files changed

+17
-11
lines changed

3 files changed

+17
-11
lines changed

apps/webapp/app/routes/api.v1.tasks.batch.ts

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
11
import { json } from "@remix-run/server-runtime";
22
import {
3-
BatchTriggerTaskResponse,
43
BatchTriggerTaskV2RequestBody,
54
BatchTriggerTaskV2Response,
65
generateJWT,
76
} from "@trigger.dev/core/v3";
87
import { env } from "~/env.server";
8+
import { AuthenticatedEnvironment, getOneTimeUseToken } from "~/services/apiAuth.server";
9+
import { logger } from "~/services/logger.server";
910
import { createActionApiRoute } from "~/services/routeBuilders/apiBuilder.server";
10-
import { HeadersSchema } from "./api.v1.tasks.$taskId.trigger";
1111
import { resolveIdempotencyKeyTTL } from "~/utils/idempotencyKeys.server";
12+
import { determineEngineVersion } from "~/v3/engineVersion.server";
13+
import { ServiceValidationError } from "~/v3/services/baseService.server";
1214
import {
1315
BatchProcessingStrategy,
1416
BatchTriggerV2Service,
1517
} from "~/v3/services/batchTriggerV2.server";
16-
import { ServiceValidationError } from "~/v3/services/baseService.server";
18+
import { BatchTriggerV3Service } from "~/v3/services/batchTriggerV3.server";
1719
import { OutOfEntitlementError } from "~/v3/services/triggerTask.server";
18-
import { AuthenticatedEnvironment, getOneTimeUseToken } from "~/services/apiAuth.server";
19-
import { logger } from "~/services/logger.server";
20-
import { z } from "zod";
20+
import { HeadersSchema } from "./api.v1.tasks.$taskId.trigger";
2121

2222
const { action, loader } = createActionApiRoute(
2323
{
@@ -87,7 +87,11 @@ const { action, loader } = createActionApiRoute(
8787
resolveIdempotencyKeyTTL(idempotencyKeyTTL) ??
8888
new Date(Date.now() + 24 * 60 * 60 * 1000 * 30);
8989

90-
const service = new BatchTriggerV2Service(batchProcessingStrategy ?? undefined);
90+
const version = await determineEngineVersion({ environment: authentication.environment });
91+
const service =
92+
version === "V1"
93+
? new BatchTriggerV2Service(batchProcessingStrategy ?? undefined)
94+
: new BatchTriggerV3Service(batchProcessingStrategy ?? undefined);
9195

9296
try {
9397
const batch = await service.call(authentication.environment, body, {

apps/webapp/app/v3/services/batchTriggerV3.server.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -830,7 +830,8 @@ export class BatchTriggerV3Service extends WithRunEngine {
830830
batchId: batch.friendlyId,
831831
skipChecks: true,
832832
runFriendlyId: task.runFriendlyId,
833-
}
833+
},
834+
"V2"
834835
);
835836
}
836837

apps/webapp/app/v3/services/triggerTask.server.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,14 +31,15 @@ export class TriggerTaskService extends WithRunEngine {
3131
taskId: string,
3232
environment: AuthenticatedEnvironment,
3333
body: TriggerTaskRequestBody,
34-
options: TriggerTaskServiceOptions = {}
34+
options: TriggerTaskServiceOptions = {},
35+
version?: RunEngineVersion
3536
) {
3637
return await this.traceWithEnv("call()", environment, async (span) => {
3738
span.setAttribute("taskId", taskId);
3839

39-
const version = await determineEngineVersion({ environment });
40+
const v = await determineEngineVersion({ environment, version });
4041

41-
switch (version) {
42+
switch (v) {
4243
case "V1": {
4344
return await this.callV1(taskId, environment, body, options);
4445
}

0 commit comments

Comments
 (0)