Skip to content

Commit 45a829e

Browse files
committed
Debug events off by default, added an admin toggle to show them
1 parent 3e2687e commit 45a829e

File tree

1 file changed

+12
-3
lines changed
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.v3.$projectParam.runs.$runParam

1 file changed

+12
-3
lines changed

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.v3.$projectParam.runs.$runParam/route.tsx

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,6 @@ export default function Page() {
262262
function TraceView({ run, trace, maximumLiveReloadingSetting, resizable }: LoaderData) {
263263
const organization = useOrganization();
264264
const project = useProject();
265-
const isAdmin = useHasAdminAccess();
266265
const { searchParams, replaceSearchParam } = useReplaceSearchParams();
267266
const selectedSpanId = searchParams.get("span") ?? undefined;
268267

@@ -303,7 +302,7 @@ function TraceView({ run, trace, maximumLiveReloadingSetting, resizable }: Loade
303302
<TasksTreeView
304303
selectedId={selectedSpanId}
305304
key={events[0]?.id ?? "-"}
306-
events={isAdmin ? events : events.filter((event) => !event.data.isDebug)}
305+
events={events}
307306
parentRunFriendlyId={parentRunFriendlyId}
308307
onSelectedIdChanged={(selectedSpan) => {
309308
//instantly close the panel if no span is selected
@@ -463,8 +462,10 @@ function TasksTreeView({
463462
maximumLiveReloadingSetting,
464463
rootRun,
465464
}: TasksTreeViewProps) {
465+
const isAdmin = useHasAdminAccess();
466466
const [filterText, setFilterText] = useState("");
467467
const [errorsOnly, setErrorsOnly] = useState(false);
468+
const [showDebug, setShowDebug] = useState(false);
468469
const [showDurations, setShowDurations] = useState(true);
469470
const [scale, setScale] = useState(0);
470471
const parentRef = useRef<HTMLDivElement>(null);
@@ -484,7 +485,7 @@ function TasksTreeView({
484485
scrollToNode,
485486
virtualizer,
486487
} = useTree({
487-
tree: events,
488+
tree: showDebug ? events : events.filter((event) => !event.data.isDebug),
488489
selectedId,
489490
// collapsedIds,
490491
onSelectedIdChanged,
@@ -509,6 +510,14 @@ function TasksTreeView({
509510
<div className="grid h-full grid-rows-[2.5rem_1fr_3.25rem] overflow-hidden">
510511
<div className="flex items-center justify-between gap-2 border-b border-grid-dimmed px-2">
511512
<SearchField onChange={setFilterText} />
513+
{isAdmin && (
514+
<Switch
515+
variant="small"
516+
label="Debug"
517+
checked={showDebug}
518+
onCheckedChange={(e) => setShowDebug(e.valueOf())}
519+
/>
520+
)}
512521
<Switch
513522
variant="small"
514523
label="Errors only"

0 commit comments

Comments
 (0)