v4: Fix HandleErrorFunction type (#1829)

* v4: Fix HandleErrorFunction type

* Only show the catchError span if there are any catchError hooks

Author: ericallam

packages/core/src/v3/types/tasks.ts

@@ -149,11 +149,7 @@ export type HandleErrorArgs = {
   signal?: AbortSignal;
 };
 
-export type HandleErrorFunction = (
-  payload: any,
-  error: unknown,
-  params: HandleErrorArgs
-) => HandleErrorResult;
+export type HandleErrorFunction = AnyOnCatchErrorHookFunction;
 
 type CommonTaskOptions<
   TIdentifier extends string,

packages/core/src/v3/workers/taskExecutor.ts

@@ -1036,11 +1036,17 @@ export class TaskExecutor {
       return { status: "skipped" };
     }
 
+    const taskCatchErrorHook = lifecycleHooks.getTaskCatchErrorHook(this.task.id);
+    const globalCatchErrorHooks = lifecycleHooks.getGlobalCatchErrorHooks();
+
+    if (globalCatchErrorHooks.length === 0 && !taskCatchErrorHook) {
+      return { status: "noop" };
+    }
+
     return this._tracer.startActiveSpan(
       "catchError",
       async (span) => {
         // Try task-specific catch error hook first
-        const taskCatchErrorHook = lifecycleHooks.getTaskCatchErrorHook(this.task.id);
         if (taskCatchErrorHook) {
           const result = await taskCatchErrorHook({
             payload,
@@ -1060,7 +1066,6 @@ export class TaskExecutor {
         }
 
         // Try global catch error hooks in order
-        const globalCatchErrorHooks = lifecycleHooks.getGlobalCatchErrorHooks();
         for (const hook of globalCatchErrorHooks) {
           const result = await hook.fn({
             payload,