Skip to content

Commit 6b8b1c7

Browse files
committed
Added data-action tracking to all the login buttons
1 parent 0c20756 commit 6b8b1c7

File tree

2 files changed

+20
-3
lines changed

2 files changed

+20
-3
lines changed

apps/webapp/app/routes/login._index/route.tsx

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,12 +67,22 @@ export default function LoginPage() {
6767
<Fieldset>
6868
<div className="flex flex-col gap-y-2">
6969
{data.showGithubAuth && (
70-
<Button type="submit" variant="primary/large" fullWidth>
70+
<Button
71+
type="submit"
72+
variant="primary/large"
73+
fullWidth
74+
data-action="continue with github"
75+
>
7176
<NamedIcon name={"github"} className={"mr-1.5 h-4 w-4"} />
7277
Continue with GitHub
7378
</Button>
7479
)}
75-
<LinkButton to="/login/magic" variant="secondary/large" fullWidth>
80+
<LinkButton
81+
to="/login/magic"
82+
variant="secondary/large"
83+
fullWidth
84+
data-action="continue with email"
85+
>
7686
<NamedIcon
7787
name={"envelope"}
7888
className={"mr-1.5 h-4 w-4 text-dimmed transition group-hover:text-bright"}

apps/webapp/app/routes/login.magic/route.tsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,12 +101,17 @@ export default function LoginMagicLinkPage() {
101101
variant="tertiary/small"
102102
LeadingIcon="arrow-left"
103103
leadingIconClassName="text-dimmed group-hover:text-bright transition"
104+
data-action="re-enter email"
104105
>
105106
Re-enter email
106107
</Button>
107108
}
108109
confirmButton={
109-
<LinkButton to="/login" variant="tertiary/small">
110+
<LinkButton
111+
to="/login"
112+
variant="tertiary/small"
113+
data-action="log in using another option"
114+
>
110115
Log in using another option
111116
</LinkButton>
112117
}
@@ -139,6 +144,7 @@ export default function LoginMagicLinkPage() {
139144
variant="primary/medium"
140145
disabled={isLoading}
141146
fullWidth
147+
data-action="send a magic link"
142148
>
143149
<NamedIcon
144150
name={isLoading ? "spinner-white" : "envelope"}
@@ -164,6 +170,7 @@ export default function LoginMagicLinkPage() {
164170
variant={"tertiary/small"}
165171
LeadingIcon={"arrow-left"}
166172
leadingIconClassName="text-dimmed group-hover:text-bright transition"
173+
data-action="all login options"
167174
>
168175
All login options
169176
</LinkButton>

0 commit comments

Comments
 (0)