A couple of perf tweaks for enriching events

Author: ericallam

apps/webapp/app/v3/utils/enrichCreatableEvents.server.ts

@@ -1,31 +1,5 @@
 import type { CreatableEvent } from "../eventRepository.server";
 
-type StyleEnricher = {
-  name: string;
-  condition: (event: CreatableEvent) => boolean;
-  enrich: (event: CreatableEvent) => Record<string, string> | undefined;
-};
-
-// Define our style enrichers
-const styleEnrichers: StyleEnricher[] = [
-  {
-    name: "GenAI System",
-    condition: (event) => typeof event.properties["gen_ai.system"] === "string",
-    enrich: (event) => ({
-      icon: `tabler-brand-${event.properties["gen_ai.system"]}`,
-    }),
-  },
-  {
-    name: "Agent workflow",
-    condition: (event) =>
-      typeof event.properties["name"] === "string" &&
-      event.properties["name"].includes("Agent workflow"),
-    enrich: () => ({
-      icon: "tabler-brain",
-    }),
-  },
-];
-
 export function enrichCreatableEvents(events: CreatableEvent[]) {
   return events.map((event) => {
     return enrichCreatableEvent(event);
@@ -42,23 +16,22 @@ function enrichCreatableEvent(event: CreatableEvent): CreatableEvent {
 }
 
 function enrichStyle(event: CreatableEvent) {
-  // Keep existing style properties as base
   const baseStyle = event.style ?? {};
+  const props = event.properties;
 
-  // Find the first matching enricher
-  for (const enricher of styleEnrichers) {
-    if (enricher.condition(event)) {
-      const enrichedStyle = enricher.enrich(event);
-      if (enrichedStyle) {
-        return {
-          ...baseStyle,
-          ...enrichedStyle,
-        };
-      }
-    }
+  // Direct property access and early returns
+  // GenAI System check
+  const system = props["gen_ai.system"];
+  if (typeof system === "string") {
+    return { ...baseStyle, icon: `tabler-brand-${system}` };
+  }
+
+  // Agent workflow check
+  const name = props["name"];
+  if (typeof name === "string" && name.includes("Agent workflow")) {
+    return { ...baseStyle, icon: "tabler-brain" };
   }
 
-  // Return original style if no enricher matched
   return baseStyle;
 }
 
@@ -70,6 +43,16 @@ function repr(value: any): string {
 }
 
 function formatPythonStyle(template: string, values: Record<string, any>): string {
+  // Early return if template is too long
+  if (template.length >= 256) {
+    return template;
+  }
+
+  // Early return if no template variables present
+  if (!template.includes("{")) {
+    return template;
+  }
+
   return template.replace(/\{([^}]+?)(?:!r)?\}/g, (match, key) => {
     const hasRepr = match.endsWith("!r}");
     const actualKey = hasRepr ? key : key;