Allow empty payloads in test runs

Author: myftija

apps/webapp/app/components/code/codeMirrorSetup.ts

@@ -2,27 +2,41 @@ import { closeBrackets } from "@codemirror/autocomplete";
 import { indentWithTab } from "@codemirror/commands";
 import { jsonParseLinter } from "@codemirror/lang-json";
 import { bracketMatching } from "@codemirror/language";
-import { lintGutter, lintKeymap, linter } from "@codemirror/lint";
+import { type Diagnostic, linter, lintGutter, lintKeymap } from "@codemirror/lint";
 import { highlightSelectionMatches } from "@codemirror/search";
 import { Prec, type Extension } from "@codemirror/state";
 import {
   drawSelection,
   dropCursor,
+  type EditorView,
   highlightActiveLine,
   highlightActiveLineGutter,
   highlightSpecialChars,
   keymap,
   lineNumbers,
 } from "@codemirror/view";
 
+function emptyAwareJsonLinter() {
+  return (view: EditorView): Diagnostic[] => {
+    const content = view.state.doc.toString().trim();
+
+    // return no errors if content is empty
+    if (!content) {
+      return [];
+    }
+
+    return jsonParseLinter()(view);
+  };
+}
+
 export function getEditorSetup(showLineNumbers = true, showHighlights = true): Array<Extension> {
   const options = [
     drawSelection(),
     dropCursor(),
     bracketMatching(),
     closeBrackets(),
     lintGutter(),
-    linter(jsonParseLinter()),
+    linter(emptyAwareJsonLinter()),
     Prec.highest(
       keymap.of([
         {

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.test.tasks.$taskParam/route.tsx

@@ -291,7 +291,6 @@ function StandardTaskForm({ task, runs }: { task: TestTask["task"]; runs: Standa
                 }}
                 height="100%"
                 autoFocus={!tab || tab === "payload"}
-                placeholder="{ }"
                 className={cn("h-full overflow-auto", tab === "metadata" && "hidden")}
               />
               <JSONEditor

apps/webapp/app/v3/testTask.ts

@@ -4,46 +4,42 @@ export const TestTaskData = z
   .discriminatedUnion("triggerSource", [
     z.object({
       triggerSource: z.literal("STANDARD"),
-      payload: z.string().transform((payload, ctx) => {
-        try {
-          const data = JSON.parse(payload);
-          return data as any;
-        } catch (e) {
-          console.log("parsing error", e);
+      payload: z
+        .string()
+        .optional()
+        .transform((val, ctx) => {
+          if (!val) {
+            return {};
+          }
 
-          if (e instanceof Error) {
-            ctx.addIssue({
-              code: z.ZodIssueCode.custom,
-              message: e.message,
-            });
-          } else {
+          try {
+            return JSON.parse(val);
+          } catch {
             ctx.addIssue({
               code: z.ZodIssueCode.custom,
-              message: "This is invalid JSON",
+              message: "Payload must be a valid JSON string",
             });
+            return z.NEVER;
+          }
+        }),
+      metadata: z
+        .string()
+        .optional()
+        .transform((val, ctx) => {
+          if (!val) {
+            return {};
           }
-        }
-      }),
-      metadata: z.string().transform((metadata, ctx) => {
-        try {
-          const data = JSON.parse(metadata);
-          return data as any;
-        } catch (e) {
-          console.log("parsing error", e);
 
-          if (e instanceof Error) {
-            ctx.addIssue({
-              code: z.ZodIssueCode.custom,
-              message: e.message,
-            });
-          } else {
+          try {
+            return JSON.parse(val);
+          } catch {
             ctx.addIssue({
               code: z.ZodIssueCode.custom,
-              message: "This is invalid JSON",
+              message: "Metadata must be a valid JSON string",
             });
+            return z.NEVER;
           }
-        }
-      }),
+        }),
     }),
     z.object({
       triggerSource: z.literal("SCHEDULED"),