Better debug logging filtering

Author: ericallam

apps/webapp/app/v3/tracer.server.ts

@@ -130,14 +130,12 @@ function getTracer() {
   });
 
   if (env.INTERNAL_OTEL_TRACE_EXPORTER_URL) {
-    const headers = env.INTERNAL_OTEL_TRACE_EXPORTER_AUTH_HEADERS
-      ? (JSON.parse(env.INTERNAL_OTEL_TRACE_EXPORTER_AUTH_HEADERS) as Record<string, string>)
-      : undefined;
+    const headers = parseInternalTraceHeaders() ?? {};
 
     const exporter = new OTLPTraceExporter({
       url: env.INTERNAL_OTEL_TRACE_EXPORTER_URL,
       timeoutMillis: 15_000,
-      headers: headers,
+      headers,
     });
 
     provider.addSpanProcessor(
@@ -206,3 +204,13 @@ export function attributesFromAuthenticatedEnv(env: AuthenticatedEnvironment): A
     [SemanticEnvResources.USER_ID]: env.orgMember?.userId,
   };
 }
+
+function parseInternalTraceHeaders(): Record<string, string> | undefined {
+  try {
+    return env.INTERNAL_OTEL_TRACE_EXPORTER_AUTH_HEADERS
+      ? (JSON.parse(env.INTERNAL_OTEL_TRACE_EXPORTER_AUTH_HEADERS) as Record<string, string>)
+      : undefined;
+  } catch {
+    return;
+  }
+}

packages/core/src/logger.ts

@@ -109,9 +109,9 @@ export class Logger {
         currentSpan && currentSpan.isRecording() ? currentSpan?.spanContext().spanId : undefined,
     };
 
-    // If the span is not recording, and it's a debug log, don't log it
+    // If the span is not recording, and it's a debug log, mark it so we can filter it out when we forward it
     if (currentSpan && !currentSpan.isRecording() && level === "debug") {
-      return;
+      structuredLog.skipForwarding = true;
     }
 
     loggerFunction(JSON.stringify(structuredLog, this.#jsonReplacer));