File tree Expand file tree Collapse file tree 9 files changed +46
-34
lines changed Expand file tree Collapse file tree 9 files changed +46
-34
lines changed Original file line number Diff line number Diff line change @@ -33,4 +33,5 @@ dependencies:
3333  - name : minio 
3434    version : " 17.0.9" 
3535    repository : " oci://registry-1.docker.io/bitnamicharts" 
36-     condition : minio.deploy 
36+     condition : s3.deploy 
37+     alias : s3 
Original file line number Diff line number Diff line change @@ -245,11 +245,11 @@ clickhouse:
245245    size : 10Gi 
246246    storageClass : " analytics-hdd"   #  Optional: override for ClickHouse
247247
248- minio :
248+ s3 :
249249  persistence :
250250    enabled : true 
251251    size : 10Gi 
252-     storageClass : " objectstore-ssd"   #  Optional: override for MinIO 
252+     storageClass : " objectstore-ssd"   #  Optional: override for S3 
253253
254254registry :
255255  persistence :
@@ -530,7 +530,7 @@ helm upgrade --install trigger . \
530530    persistence: 
531531      size: 100Gi 
532532
533-   minio : 
533+   s3 : 
534534    persistence: 
535535      size: 200Gi 
536536
Original file line number Diff line number Diff line change @@ -78,10 +78,10 @@ Configuration:
7878{{- else }}
7979- Using external ClickHouse at {{ .Values.clickhouse.external.host }}:{{ .Values.clickhouse.external.httpPort | default 8123 }}
8080{{- end }}
81- {{- if .Values.minio .deploy }}
82- - Using internal MinIO  object storage
81+ {{- if .Values.s3 .deploy }}
82+ - Using internal S3-compatible  object storage (MinIO) 
8383{{- else }}
84- - Using external MinIO  object storage at {{ .Values.minio .external.endpoint }}
84+ - Using external S3-compatible  object storage at {{ .Values.s3 .external.endpoint }}
8585{{- end }}
8686{{- if .Values.registry.deploy }}
8787- Using internal Docker registry
Original file line number Diff line number Diff line change @@ -177,21 +177,32 @@ http://{{ .Values.clickhouse.auth.username }}:{{ .Values.clickhouse.auth.passwor
177177{ {- end }  }
178178
179179{ {/*
180- MinIO  hostname
180+ S3  hostname
181181*/}  }
182- { {- define " trigger-v4.minio .hostname"   -}  }
183- { {- if  .Values.minio .endpoint }  }
184- { {- .Values.minio .endpoint }  }
185- { {- else  if  .Values.minio .deploy }  }
182+ { {- define " trigger-v4.s3 .hostname"   -}  }
183+ { {- if  .Values.s3.external .endpoint }  }
184+ { {- .Values.s3.external .endpoint }  }
185+ { {- else  if  .Values.s3 .deploy }  }
186186{ {- printf " http://%s-minio:9000"   .Release.Name }  }
187187{ {- end }  }
188188{ {- end }  }
189189
190190{ {/*
191- MinIO connection details 
191+ S3 connection details 
192+ */}  }
193+ { {- define " trigger-v4.s3.url"   -}  }
194+ { {- include  " trigger-v4.s3.hostname"   . }  }
195+ { {- end }  }
196+ 
197+ { {/*
198+ Backward compatibility - MinIO helpers (deprecated) 
192199*/}  }
200+ { {- define " trigger-v4.minio.hostname"   -}  }
201+ { {- include  " trigger-v4.s3.hostname"   . }  }
202+ { {- end }  }
203+ 
193204{ {- define " trigger-v4.minio.url"   -}  }
194- { {- include  " trigger-v4.minio.hostname "   . }  }
205+ { {- include  " trigger-v4.s3.url "   . }  }
195206{ {- end }  }
196207
197208{ {/*
Original file line number Diff line number Diff line change 1- {{- if .Values.minio .deploy }} 
1+ {{- if .Values.s3 .deploy }} 
22apiVersion : v1 
33kind : Pod 
44metadata :
5-   name : " {{ include " trigger-v4.fullname" . }}-test-minio " 
5+   name : " {{ include " trigger-v4.fullname" . }}-test-s3 " 
66  labels :
77    {{- include "trigger-v4.labels" . | nindent 4 }} 
88  annotations :
99    " helm.sh/hook "  : test 
1010spec :
1111  restartPolicy : Never 
1212  containers :
13-     - name : test-minio  
13+     - name : test-s3  
1414      image : curlimages/curl:8.14.1 
1515      command : ['sh', '-c'] 
1616      args :
1717        - | 
18-           echo "Testing MinIO health endpoint..." 
19-           curl -f http://{{ include "trigger-v4.fullname" . }}-minio:{{ .Values.minio.service.ports.api }} /minio/health/live 
20-           echo "MinIO  test completed successfully" 
18+           echo "Testing S3 ( MinIO)  health endpoint..." 
19+           curl -f http://{{ include "trigger-v4.fullname" . }}-minio:9000 /minio/health/live 
20+           echo "S3  test completed successfully" 
2121{{- end }} 
Original file line number Diff line number Diff line change @@ -20,9 +20,9 @@ This template will fail the Helm deployment if external config is missing for re
2020{{- end }} 
2121{{- end }} 
2222
23- {{- if not .Values.minio .deploy }} 
24- {{- if or (not .Values.minio .external.endpoint) (not .Values.minio .external.accessKeyId) }} 
25- {{- fail "MinIO  external configuration is required when minio .deploy=false. Please provide minio .external.endpoint and minio .external.accessKeyId" }} 
23+ {{- if not .Values.s3 .deploy }} 
24+ {{- if or (not .Values.s3 .external.endpoint) (not .Values.s3 .external.accessKeyId) }} 
25+ {{- fail "S3  external configuration is required when s3 .deploy=false. Please provide s3 .external.endpoint and s3 .external.accessKeyId" }} 
2626{{- end }} 
2727{{- end }} 
2828
Original file line number Diff line number Diff line change 9797            - name : DEPLOY_REGISTRY_NAMESPACE 
9898              value : {{ .Values.registry.repositoryNamespace | quote }} 
9999            - name : OBJECT_STORE_BASE_URL 
100-               value : {{ include "trigger-v4.minio .url" . | quote }} 
100+               value : {{ include "trigger-v4.s3 .url" . | quote }} 
101101            - name : GRACEFUL_SHUTDOWN_TIMEOUT 
102102              value : {{ .Values.webapp.gracefulShutdownTimeout | quote }} 
103103            {{- if .Values.webapp.bootstrap.enabled }} 
Original file line number Diff line number Diff line change @@ -91,11 +91,11 @@ clickhouse:
9191      cpu : 500m 
9292      memory : 1Gi 
9393
94- #  Production MinIO (or use external S3) 
95- minio :
94+ #  Production S3-compatible object storage 
95+ s3 :
9696  auth :
9797    rootUser : " admin" 
98-     rootPassword : " your-strong-minio -password" 
98+     rootPassword : " your-strong-s3 -password" 
9999  persistence :
100100    enabled : true 
101101    size : 500Gi 
Original file line number Diff line number Diff line change @@ -391,14 +391,14 @@ clickhouse:
391391        </profiles> 
392392      </clickhouse> 
393393
394- #  MinIO configuration
395- minio :
396-   deploy : true  #  Set to false to use external S3-compatible storage
394+ #  S3-compatible object storage configuration
395+ s3 :
396+   #  Set to false to use external S3-compatible storage
397+   #  Set to true to deploy internal MinIO (default)
398+   deploy : true 
397399
398400  #  Bitnami MinIO chart configuration (when deploy: true)
399-   #  WARNING: This sets the root user and password on first startup and MUST be changed via the dashboard.
400-   #  - Don't forget to update secrets.objectStore if you intend to use the root credentials.
401-   #  - You should instead create a new non-root user and update the secrets.objectStore with the new credentials.
401+   #  MinIO provides S3-compatible storage when deployed internally
402402  auth :
403403    rootUser : " admin" 
404404    rootPassword : " very-safe-password" 
@@ -408,7 +408,7 @@ minio:
408408    size : 10Gi 
409409  resources : {} 
410410
411-   #  External MinIO/ S3 connection (when deploy: false)
411+   #  External S3 connection (when deploy: false)
412412  external :
413413    endpoint : " "   #  e.g., "https://s3.amazonaws.com" or "https://your-minio.com:9000"
414414    accessKeyId : " " 
    
 
   
 
     
   
   
          
     
  
    
     
 
    
      
     
 
     
    You can’t perform that action at this time.
  
 
    
  
     
    
      
        
     
 
       
      
     
   
 
    
    
  
 
  
 
     
    
0 commit comments