Skip to content

Commit 864dfb5

Browse files
myftijamyftija
committed
Add missing field descriptions
1 parent 6171349 commit 864dfb5

File tree

1 file changed

+22
-9
lines changed
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.test.tasks.$taskParam

1 file changed

+22
-9
lines changed

‎apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.test.tasks.$taskParam/route.tsx‎

Lines changed: 22 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -417,6 +417,7 @@ function StandardTaskForm({
417417
<InputGroup>
418418
<Label variant="small">Delay</Label>
419419
<DurationPicker name={delaySeconds.name} id={delaySeconds.id} />
420+
<Hint>The run will be delayed by the specified duration.</Hint>
420421
<FormError id={delaySeconds.errorId}>{delaySeconds.error}</FormError>
421422
</InputGroup>
422423
<InputGroup>
@@ -446,6 +447,7 @@ function StandardTaskForm({
446447
name={queue.name}
447448
id={queue.id}
448449
placeholder="Select queue"
450+
heading="Filter queues"
449451
variant="tertiary/small"
450452
dropdownIcon
451453
items={queueItems}
@@ -480,6 +482,7 @@ function StandardTaskForm({
480482
}
481483
</Select>
482484
)}
485+
<Hint>The run will be assigned to the selected queue.</Hint>
483486
<FormError id={queue.errorId}>{queue.error}</FormError>
484487
</InputGroup>
485488
<InputGroup>
@@ -522,6 +525,7 @@ function StandardTaskForm({
522525
}
523526
}}
524527
/>
528+
<Hint>Failed runs will be retried up to the specified number of attempts.</Hint>
525529
<FormError id={maxAttempts.errorId}>{maxAttempts.error}</FormError>
526530
</InputGroup>
527531
<InputGroup>
@@ -532,6 +536,7 @@ function StandardTaskForm({
532536
value={maxDurationValue}
533537
onChange={setMaxDurationValue}
534538
/>
539+
<Hint>Override the maximum compute time limit for the run.</Hint>
535540
<FormError id={maxDurationSeconds.errorId}>{maxDurationSeconds.error}</FormError>
536541
</InputGroup>
537542
<InputGroup>
@@ -551,7 +556,7 @@ function StandardTaskForm({
551556
name={idempotencyKeyTTLSeconds.name}
552557
id={idempotencyKeyTTLSeconds.id}
553558
/>
554-
<Hint>By default, idempotency keys expire after 30 days.</Hint>
559+
<Hint>Keys expire after 30 days by default.</Hint>
555560
<FormError id={idempotencyKeyTTLSeconds.errorId}>
556561
{idempotencyKeyTTLSeconds.error}
557562
</FormError>
@@ -567,7 +572,7 @@ function StandardTaskForm({
567572
onChange={(e) => setConcurrencyKeyValue(e.target.value)}
568573
/>
569574
<Hint>
570-
Concurrency keys enable you limit concurrency by creating a separate queue for
575+
Concurrency keys enable you to limit concurrency by creating a separate queue for
571576
each value of the key.
572577
</Hint>
573578
<FormError id={concurrencyKey.errorId}>{concurrencyKey.error}</FormError>
@@ -595,7 +600,7 @@ function StandardTaskForm({
595600
</SelectItem>
596601
))}
597602
</Select>
598-
<Hint>This lets you override the machine preset specified in the task.</Hint>
603+
<Hint>Override the machine preset specified in the task.</Hint>
599604
<FormError id={machine.errorId}>{machine.error}</FormError>
600605
</InputGroup>
601606
<InputGroup>
@@ -616,8 +621,10 @@ function StandardTaskForm({
616621
</SelectItem>
617622
))}
618623
</Select>
619-
{disableVersionSelection && (
624+
{disableVersionSelection ? (
620625
<Hint>Only the latest version is available in the development environment.</Hint>
626+
) : (
627+
<Hint>Select a specific version of the task.</Hint>
621628
)}
622629
<FormError id={version.errorId}>{version.error}</FormError>
623630
</InputGroup>
@@ -868,7 +875,7 @@ function ScheduledTaskForm({
868875
</Hint>
869876
<FormError id={externalId.errorId}>{externalId.error}</FormError>
870877
</InputGroup>
871-
<div className="w-full border-b border-grid-bright"></div>
878+
<div className="w-full border-b border-grid-bright" />
872879
<InputGroup>
873880
<Label htmlFor={ttlSeconds.id} variant="small">
874881
TTL
@@ -898,6 +905,7 @@ function ScheduledTaskForm({
898905
name={queue.name}
899906
id={queue.id}
900907
placeholder="Select queue"
908+
heading="Filter queues"
901909
variant="tertiary/small"
902910
dropdownIcon
903911
items={queueItems}
@@ -932,6 +940,7 @@ function ScheduledTaskForm({
932940
}
933941
</Select>
934942
)}
943+
<Hint>The run will be assigned to the selected queue.</Hint>
935944
<FormError id={queue.errorId}>{queue.error}</FormError>
936945
</InputGroup>
937946
<InputGroup>
@@ -974,6 +983,7 @@ function ScheduledTaskForm({
974983
}
975984
}}
976985
/>
986+
<Hint>Failed runs will be retried up to the specified number of attempts.</Hint>
977987
<FormError id={maxAttempts.errorId}>{maxAttempts.error}</FormError>
978988
</InputGroup>
979989
<InputGroup>
@@ -986,6 +996,7 @@ function ScheduledTaskForm({
986996
value={maxDurationValue}
987997
onChange={setMaxDurationValue}
988998
/>
999+
<Hint>Override the maximum compute time limit for the run.</Hint>
9891000
<FormError id={maxDurationSeconds.errorId}>{maxDurationSeconds.error}</FormError>
9901001
</InputGroup>
9911002
<InputGroup>
@@ -1004,7 +1015,7 @@ function ScheduledTaskForm({
10041015
Idempotency key TTL
10051016
</Label>
10061017
<DurationPicker name={idempotencyKeyTTLSeconds.name} id={idempotencyKeyTTLSeconds.id} />
1007-
<Hint>By default, idempotency keys expire after 30 days.</Hint>
1018+
<Hint>Keys expire after 30 days by default.</Hint>
10081019
<FormError id={idempotencyKeyTTLSeconds.errorId}>
10091020
{idempotencyKeyTTLSeconds.error}
10101021
</FormError>
@@ -1020,7 +1031,7 @@ function ScheduledTaskForm({
10201031
onChange={(e) => setConcurrencyKeyValue(e.target.value)}
10211032
/>
10221033
<Hint>
1023-
Concurrency keys enable you limit concurrency by creating a separate queue for each
1034+
Concurrency keys enable you to limit concurrency by creating a separate queue for each
10241035
value of the key.
10251036
</Hint>
10261037
<FormError id={concurrencyKey.errorId}>{concurrencyKey.error}</FormError>
@@ -1048,7 +1059,7 @@ function ScheduledTaskForm({
10481059
</SelectItem>
10491060
))}
10501061
</Select>
1051-
<Hint>This lets you override the machine preset specified in the task.</Hint>
1062+
<Hint>Override the machine preset specified in the task.</Hint>
10521063
<FormError id={machine.errorId}>{machine.error}</FormError>
10531064
</InputGroup>
10541065
<InputGroup>
@@ -1069,8 +1080,10 @@ function ScheduledTaskForm({
10691080
</SelectItem>
10701081
))}
10711082
</Select>
1072-
{disableVersionSelection && (
1083+
{disableVersionSelection ? (
10731084
<Hint>Only the latest version is available in the development environment.</Hint>
1085+
) : (
1086+
<Hint>Select a specific version of the task.</Hint>
10741087
)}
10751088
<FormError id={version.errorId}>{version.error}</FormError>
10761089
</InputGroup>

0 commit comments

Comments
 (0)