Skip to content

Commit 87c21ab

Browse files
authored
feat: enable overriding run options when replaying (#2260)
* Rearrange the layout of the replay modal * Add run options to the replay modal * Handle payload and metadata correctly in the shared json editor * Apply run options in replays * Fix clear button issue in json editor Memoization of the clear function caused some problems. Removing it should not cause performance issues. * Update replay modal hint * Move machine and version fields to the top for visibility * Use the same field ordering in the test page * Reload queues and versions on env override * Adapt json editor to fill full height * Clean up a few excessive ternaries * Avoid ui jump on env selection * Switch to sexy scrollbars for scheduled tasks in the test page
1 parent 4c635f7 commit 87c21ab

File tree

7 files changed

+911
-358
lines changed

7 files changed

+911
-358
lines changed

apps/webapp/app/components/code/JSONEditor.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,13 +125,13 @@ export function JSONEditor(opts: JSONEditorProps) {
125125
}
126126
}, [defaultValue, view]);
127127

128-
const clear = useCallback(() => {
128+
const clear = () => {
129129
if (view === undefined) return;
130130
view.dispatch({
131131
changes: { from: 0, to: view.state.doc.length, insert: undefined },
132132
});
133133
onChange?.("");
134-
}, [view]);
134+
};
135135

136136
const copy = useCallback(() => {
137137
if (view === undefined) return;

0 commit comments

Comments
 (0)