Skip to content

Commit 8a814d4

Browse files
samejrsamejr
committed
Adds to={path} to the TableRow only
1 parent b239474 commit 8a814d4

File tree

2 files changed

+24
-32
lines changed

2 files changed

+24
-32
lines changed

‎apps/webapp/app/components/runs/v3/TaskRunsTable.tsx‎

Lines changed: 16 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ export function TaskRunsTable({
283283
runs.map((run, index) => {
284284
const path = v3RunSpanPath(organization, project, run, { spanId: run.spanId });
285285
return (
286-
<TableRow key={run.id}>
286+
<TableRow to={path} key={run.id}>
287287
{allowSelection && (
288288
<TableCell className="pl-3 pr-0">
289289
<Checkbox
@@ -298,33 +298,29 @@ export function TaskRunsTable({
298298
/>
299299
</TableCell>
300300
)}
301-
<TableCell to={path} alignment="right">
302-
{formatNumber(run.number)}
303-
</TableCell>
304-
<TableCell to={path}>
301+
<TableCell alignment="right">{formatNumber(run.number)}</TableCell>
302+
<TableCell>
305303
<EnvironmentLabel
306304
environment={run.environment}
307305
userName={run.environment.userName}
308306
/>
309307
</TableCell>
310-
<TableCell to={path}>
308+
<TableCell>
311309
<span className="flex items-center gap-x-1">
312310
{run.taskIdentifier}
313311
{run.rootTaskRunId === null ? <Badge variant="extra-small">Root</Badge> : null}
314312
</span>
315313
</TableCell>
316-
<TableCell to={path}>{run.version ?? "–"}</TableCell>
317-
<TableCell to={path}>
314+
<TableCell>{run.version ?? "–"}</TableCell>
315+
<TableCell>
318316
<SimpleTooltip
319317
content={descriptionForTaskRunStatus(run.status)}
320318
disableHoverableContent
321319
button={<TaskRunStatusCombo status={run.status} />}
322320
/>
323321
</TableCell>
324-
<TableCell to={path}>
325-
{run.startedAt ? <DateTime date={run.startedAt} /> : "–"}
326-
</TableCell>
327-
<TableCell to={path} className="w-[1%]" actionClassName="pr-0 tabular-nums">
322+
<TableCell>{run.startedAt ? <DateTime date={run.startedAt} /> : "–"}</TableCell>
323+
<TableCell className="w-[1%]" actionClassName="pr-0 tabular-nums">
328324
<div className="flex items-center gap-1">
329325
<RectangleStackIcon className="size-4 text-text-dimmed" />
330326
{run.startedAt ? (
@@ -340,7 +336,7 @@ export function TaskRunsTable({
340336
)}
341337
</div>
342338
</TableCell>
343-
<TableCell to={path} className="w-[1%]" actionClassName="px-4 tabular-nums">
339+
<TableCell className="w-[1%]" actionClassName="px-4 tabular-nums">
344340
<div className="flex items-center gap-1">
345341
<ClockIcon className="size-4 text-blue-500" />
346342
{run.startedAt && run.finishedAt ? (
@@ -354,7 +350,7 @@ export function TaskRunsTable({
354350
)}
355351
</div>
356352
</TableCell>
357-
<TableCell to={path} actionClassName="pl-0 tabular-nums">
353+
<TableCell actionClassName="pl-0 tabular-nums">
358354
<div className="flex items-center gap-1">
359355
<CpuChipIcon className="size-4 text-success" />
360356
{run.usageDurationMs > 0
@@ -365,21 +361,17 @@ export function TaskRunsTable({
365361
</div>
366362
</TableCell>
367363
{showCompute && (
368-
<TableCell to={path} className="tabular-nums">
364+
<TableCell className="tabular-nums">
369365
{run.costInCents > 0 ? formatCurrencyAccurate(run.costInCents / 100) : "–"}
370366
</TableCell>
371367
)}
372-
<TableCell to={path}>
368+
<TableCell>
373369
{run.isTest ? <CheckIcon className="size-4 text-charcoal-400" /> : "–"}
374370
</TableCell>
375-
<TableCell to={path}>
376-
{run.createdAt ? <DateTime date={run.createdAt} /> : "–"}
377-
</TableCell>
378-
<TableCell to={path}>
379-
{run.delayUntil ? <DateTime date={run.delayUntil} /> : "–"}
380-
</TableCell>
381-
<TableCell to={path}>{run.ttl ?? "–"}</TableCell>
382-
<TableCell to={path} actionClassName="py-1">
371+
<TableCell>{run.createdAt ? <DateTime date={run.createdAt} /> : "–"}</TableCell>
372+
<TableCell>{run.delayUntil ? <DateTime date={run.delayUntil} /> : "–"}</TableCell>
373+
<TableCell>{run.ttl ?? "–"}</TableCell>
374+
<TableCell actionClassName="py-1">
383375
<div className="flex gap-1">
384376
{run.tags.map((tag) => <RunTag key={tag} tag={tag} />) || "–"}
385377
</div>

‎apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.v3.$projectParam._index/route.tsx‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -279,8 +279,8 @@ export default function Page() {
279279
: v3TestPath(organization, project);
280280

281281
return (
282-
<TableRow key={task.slug} className="group">
283-
<TableCell to={path}>
282+
<TableRow to={path} key={task.slug} className="group">
283+
<TableCell>
284284
<div className="flex items-center gap-2">
285285
<SimpleTooltip
286286
button={<TaskTriggerSourceIcon source={task.triggerSource} />}
@@ -289,13 +289,13 @@ export default function Page() {
289289
<span>{task.slug}</span>
290290
</div>
291291
</TableCell>
292-
<TableCell to={path}>
292+
<TableCell>
293293
<TaskFunctionName
294294
functionName={task.exportName}
295295
variant="extra-extra-small"
296296
/>
297297
</TableCell>
298-
<TableCell to={path}>
298+
<TableCell>
299299
<Suspense
300300
fallback={
301301
<>
@@ -311,7 +311,7 @@ export default function Page() {
311311
</TypedAwait>
312312
</Suspense>
313313
</TableCell>
314-
<TableCell to={path}>
314+
<TableCell>
315315
<Suspense fallback={<></>}>
316316
<TypedAwait resolve={runningStats}>
317317
{(data) => {
@@ -321,7 +321,7 @@ export default function Page() {
321321
</TypedAwait>
322322
</Suspense>
323323
</TableCell>
324-
<TableCell to={path}>
324+
<TableCell>
325325
<Suspense fallback={<TaskActivityBlankState />}>
326326
<TypedAwait resolve={activity}>
327327
{(data) => {
@@ -341,7 +341,7 @@ export default function Page() {
341341
</TypedAwait>
342342
</Suspense>
343343
</TableCell>
344-
<TableCell to={path}>
344+
<TableCell>
345345
<Suspense fallback={<></>}>
346346
<TypedAwait resolve={durations}>
347347
{(data) => {
@@ -355,7 +355,7 @@ export default function Page() {
355355
</TypedAwait>
356356
</Suspense>
357357
</TableCell>
358-
<TableCell to={path}>
358+
<TableCell>
359359
<EnvironmentLabels environments={task.environments} />
360360
</TableCell>
361361
<TableCellMenu

0 commit comments

Comments
 (0)