Skip to content

Commit 8b47126

Browse files
committed
Adjust the page layout to make it clear which task is currently selected
1 parent cd0738f commit 8b47126

File tree

2 files changed

+42
-31
lines changed
  • apps/webapp/app/routes
    • _app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.test.tasks.$taskParam
    • _app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.test

2 files changed

+42
-31
lines changed

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.test.tasks.$taskParam/route.tsx

Lines changed: 41 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ import { DateTime } from "~/components/primitives/DateTime";
5959
import { TaskRunStatusCombo } from "~/components/runs/v3/TaskRunStatus";
6060
import { ClockRotateLeftIcon } from "~/assets/icons/ClockRotateLeftIcon";
6161
import { MachinePresetName } from "@trigger.dev/core/v3";
62+
import { TaskTriggerSourceIcon } from "~/components/runs/v3/TaskTriggerSource";
6263

6364
export const loader = async ({ request, params }: LoaderFunctionArgs) => {
6465
const userId = await requireUserId(request);
@@ -337,29 +338,14 @@ function StandardTaskForm({
337338
<input {...conform.input(taskIdentifier, { type: "hidden" })} value={task.taskIdentifier} />
338339
<input {...conform.input(environmentId, { type: "hidden" })} value={environment.id} />
339340
<input {...conform.input(triggerSource, { type: "hidden" })} value={"STANDARD"} />
340-
<TabContainer className="flex items-baseline justify-between pl-3 pr-2 pt-1.5">
341-
<div className="flex gap-5">
342-
<TabButton
343-
isActive={!tab || tab === "payload"}
344-
layoutId="test-editor"
345-
onClick={() => {
346-
replace({ tab: "payload" });
347-
}}
348-
>
349-
Payload
350-
</TabButton>
351-
352-
<TabButton
353-
isActive={tab === "metadata"}
354-
layoutId="test-editor"
355-
onClick={() => {
356-
replace({ tab: "metadata" });
357-
}}
358-
>
359-
Metadata
360-
</TabButton>
341+
<div className="flex items-center justify-between gap-1.5 border-b border-grid-bright p-2">
342+
<div className="flex items-center gap-1.5">
343+
<TaskTriggerSourceIcon source={"STANDARD"} />
344+
<Paragraph variant="extra-small" className="text-text-dimmed">
345+
{task.taskIdentifier}
346+
</Paragraph>
361347
</div>
362-
<div className="flex items-center gap-3">
348+
<div className="flex items-center gap-1.5">
363349
<RecentRunsPopover
364350
runs={runs}
365351
onRunSelected={(run) => {
@@ -375,10 +361,34 @@ function StandardTaskForm({
375361
}}
376362
/>
377363
</div>
378-
</TabContainer>
364+
</div>
365+
379366
<ResizablePanelGroup orientation="horizontal" className="grow">
380367
<ResizablePanel id="test-task-main" min="300px">
381368
<div className="flex h-full flex-col overflow-hidden bg-charcoal-900">
369+
<TabContainer className="flex items-baseline justify-between pl-3 pr-2 pt-1.5">
370+
<div className="flex gap-5">
371+
<TabButton
372+
isActive={!tab || tab === "payload"}
373+
layoutId="test-editor"
374+
onClick={() => {
375+
replace({ tab: "payload" });
376+
}}
377+
>
378+
Payload
379+
</TabButton>
380+
381+
<TabButton
382+
isActive={tab === "metadata"}
383+
layoutId="test-editor"
384+
onClick={() => {
385+
replace({ tab: "metadata" });
386+
}}
387+
>
388+
Metadata
389+
</TabButton>
390+
</div>
391+
</TabContainer>
382392
<div className="flex-1 overflow-hidden">
383393
<JSONEditor
384394
defaultValue={defaultPayloadJson}
@@ -746,13 +756,14 @@ function ScheduledTaskForm({
746756
{...conform.input(environmentId, { type: "hidden" })}
747757
value={environment.id}
748758
/>
749-
<TabContainer className="flex items-baseline justify-between pl-3 pr-2 pt-1.5">
750-
<div className="flex gap-5">
751-
<TabButton isActive={true} layoutId="scheduled-task-options">
752-
Options
753-
</TabButton>
759+
<div className="flex items-center justify-between gap-1.5 border-b border-grid-bright p-2">
760+
<div className="flex items-center gap-1.5">
761+
<TaskTriggerSourceIcon source={"SCHEDULED"} />
762+
<Paragraph variant="extra-small" className="text-text-dimmed">
763+
{task.taskIdentifier}
764+
</Paragraph>
754765
</div>
755-
<div className="flex items-center gap-3">
766+
<div className="flex items-center gap-1.5">
756767
<RecentRunsPopover
757768
runs={runs}
758769
onRunSelected={(run) => {
@@ -770,7 +781,7 @@ function ScheduledTaskForm({
770781
}}
771782
/>
772783
</div>
773-
</TabContainer>
784+
</div>
774785
<div className="grow overflow-y-scroll p-3">
775786
<Fieldset>
776787
<InputGroup>

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.test/route.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ function TaskSelector({
138138
<div className="p-2">
139139
<Input
140140
placeholder="Search tasks"
141-
variant="medium"
141+
variant="small"
142142
icon={MagnifyingGlassIcon}
143143
fullWidth={true}
144144
value={filterText}

0 commit comments

Comments
 (0)