Skip to content

Commit 975c5f1

Browse files
Rutam21ericallam
andauthored
[TRI-1333] : Upgrade all packages to use Node18 and use fetch instead node-fetch (#581)
* [TRI-1333] : Upgrade all packages to use Node18 and use fetch instead of node-fetch * Changeset Added * Update pnpm-lock to compatible pnpm v7.18.1 * Restored pnpm-lock to the last known good point compatible with pnpm v7.18.1 * Update chilled-plants-exercise.md --------- Co-authored-by: Eric Allam <[email protected]>
1 parent 916ed4e commit 975c5f1

File tree

14 files changed

+26
-38
lines changed

14 files changed

+26
-38
lines changed

.changeset/chilled-plants-exercise.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
---
2+
"@trigger.dev/integration-kit": minor
3+
"@trigger.dev/eslint-plugin": minor
4+
"@trigger.dev/sdk": minor
5+
"@trigger.dev/sveltekit": minor
6+
"@trigger.dev/express": minor
7+
"@trigger.dev/nestjs": minor
8+
"@trigger.dev/nextjs": minor
9+
"@trigger.dev/astro": minor
10+
"@trigger.dev/core": minor
11+
"@trigger.dev/cli": minor
12+
---
13+
14+
Drop support for Node v16, require Node >= 18. This allows us to use native fetch in our SDK which paves the way for multi-platform support.

packages/astro/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
"typescript": "^4.8.4"
3434
},
3535
"engines": {
36-
"node": ">=16.8.0"
36+
"node": ">=18.0.0"
3737
},
3838
"license": "MIT",
3939
"publishConfig": {

packages/cli/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,6 @@
8484
"zod": "3.22.3"
8585
},
8686
"engines": {
87-
"node": ">=16.8.0"
87+
"node": ">=18.0.0"
8888
}
8989
}

packages/core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,6 @@
4242
"typescript": "^4.9.4"
4343
},
4444
"engines": {
45-
"node": ">=16.8.0"
45+
"node": ">=18.0.0"
4646
}
4747
}

packages/eslint-plugin/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
"npm-run-all": "^4.1.5"
3030
},
3131
"engines": {
32-
"node": "^14.17.0 || ^16.0.0 || >= 18.0.0"
32+
"node": ">=18.0.0"
3333
},
3434
"peerDependencies": {
3535
"eslint": ">=7"

packages/express/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,6 @@
4141
"express": "^4.18.2"
4242
},
4343
"engines": {
44-
"node": ">=16.8.0"
44+
"node": ">=18.0.0"
4545
}
4646
}

packages/integration-kit/package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
"devDependencies": {
2222
"@trigger.dev/tsconfig": "workspace:*",
2323
"@types/node": "18",
24-
"@types/node-fetch": "2.6.x",
2524
"@types/uuid": "^9.0.0",
2625
"rimraf": "^3.0.2",
2726
"tsup": "^6.5.0",
@@ -35,10 +34,9 @@
3534
"typecheck": "tsup --dts-resolve --no-dts"
3635
},
3736
"dependencies": {
38-
"node-fetch": "2.6.x",
3937
"uuid": "^9.0.0"
4038
},
4139
"engines": {
42-
"node": ">=16.8.0"
40+
"node": ">=18.0.0"
4341
}
4442
}

packages/integration-kit/src/file.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import fs, { promises } from "fs";
22
import path from "path";
33
import { v4 as uuidv4 } from "uuid";
4-
import fetch from "node-fetch";
54

65
export async function fileFromString(contents: string | Buffer, fileName: string): Promise<File> {
76
const directory = path.join("tmp", uuidv4());
@@ -13,7 +12,8 @@ export async function fileFromString(contents: string | Buffer, fileName: string
1312

1413
export async function fileFromUrl(url: string) {
1514
const response = await fetch(url);
16-
const content = await response.buffer();
15+
const arrayBuffer = await response.arrayBuffer();
16+
const content = Buffer.from(arrayBuffer);
1717
const fileName = path.basename(url);
1818

1919
return fileFromString(content, fileName);

packages/nestjs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,6 @@
4343
"debug": "^4.3.4"
4444
},
4545
"engines": {
46-
"node": ">=16.8.0"
46+
"node": ">=18.0.0"
4747
}
4848
}

packages/nextjs/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,6 @@
4141
"debug": "^4.3.4"
4242
},
4343
"engines": {
44-
"node": ">=16.8.0"
44+
"node": ">=18.0.0"
4545
}
4646
}

0 commit comments

Comments
 (0)