Skip to content

Commit 9edd0e2

Browse files
committed
Adds isTabbableCell to each table
1 parent 17302b8 commit 9edd0e2

File tree

7 files changed

+11
-10
lines changed
  • apps/webapp/app
    • components/runs/v3
    • routes
      • _app.orgs.$organizationSlug.projects.v3.$projectParam._index
      • _app.orgs.$organizationSlug.projects.v3.$projectParam.batches
      • _app.orgs.$organizationSlug.projects.v3.$projectParam.deployments.$deploymentParam
      • _app.orgs.$organizationSlug.projects.v3.$projectParam.deployments
      • _app.orgs.$organizationSlug.projects.v3.$projectParam.schedules
      • _app.orgs.$organizationSlug.projects.v3.$projectParam.test

7 files changed

+11
-10
lines changed

apps/webapp/app/components/runs/v3/TaskRunsTable.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,7 @@ export function TaskRunsTable({
298298
/>
299299
</TableCell>
300300
)}
301-
<TableCell to={path} alignment="right">
301+
<TableCell to={path} alignment="right" isTabbableCell>
302302
{formatNumber(run.number)}
303303
</TableCell>
304304
<TableCell to={path}>

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.v3.$projectParam._index/route.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ export default function Page() {
280280

281281
return (
282282
<TableRow key={task.slug} className="group">
283-
<TableCell to={path}>
283+
<TableCell to={path} isTabbableCell>
284284
<div className="flex items-center gap-2">
285285
<SimpleTooltip
286286
button={<TaskTriggerSourceIcon source={task.triggerSource} />}

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.v3.$projectParam.batches/route.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,9 @@ function BatchesTable({ batches, hasFilters, filters }: BatchList) {
185185
const path = v3BatchRunsPath(organization, project, batch);
186186
return (
187187
<TableRow key={batch.id}>
188-
<TableCell to={path}>{batch.friendlyId}</TableCell>
188+
<TableCell to={path} isTabbableCell>
189+
{batch.friendlyId}
190+
</TableCell>
189191
<TableCell to={path}>
190192
<EnvironmentLabel
191193
environment={batch.environment}
@@ -199,7 +201,7 @@ function BatchesTable({ batches, hasFilters, filters }: BatchList) {
199201
disableHoverableContent
200202
button={
201203
<span className="flex items-center gap-1">
202-
<ExclamationCircleIcon className="size-4 text-slate-500" />
204+
<ExclamationCircleIcon className="size-4 text-text-dimmed" />
203205
<span>Legacy batch</span>
204206
</span>
205207
}

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.v3.$projectParam.deployments.$deploymentParam/route.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -210,10 +210,8 @@ export default function Page() {
210210
<div className="divide-y divide-charcoal-800 overflow-y-auto scrollbar-thin scrollbar-track-transparent scrollbar-thumb-charcoal-600">
211211
<Table>
212212
<TableHeader>
213-
<TableRow>
214-
<TableHeaderCell className="px-2">Task</TableHeaderCell>
215-
<TableHeaderCell className="px-2">File path</TableHeaderCell>
216-
</TableRow>
213+
<TableHeaderCell className="px-2">Task</TableHeaderCell>
214+
<TableHeaderCell className="px-2">File path</TableHeaderCell>
217215
</TableHeader>
218216
<TableBody>
219217
{deployment.tasks.map((t) => {

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.v3.$projectParam.deployments/route.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ export default function Page() {
168168
const isSelected = deploymentParam === deployment.shortCode;
169169
return (
170170
<TableRow key={deployment.id} className="group" isSelected={isSelected}>
171-
<TableCell to={path} isSelected={isSelected}>
171+
<TableCell to={path} isTabbableCell isSelected={isSelected}>
172172
<div className="flex items-center gap-2">
173173
<Paragraph variant="extra-small">{deployment.shortCode}</Paragraph>
174174
{deployment.label && (

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.v3.$projectParam.schedules/route.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,7 @@ function SchedulesTable({
452452
const cellClass = schedule.active ? "" : "opacity-50";
453453
return (
454454
<TableRow key={schedule.id} className={isSelected ? "bg-grid-dimmed" : undefined}>
455-
<TableCell to={path} className={cellClass}>
455+
<TableCell to={path} isTabbableCell className={cellClass}>
456456
{schedule.friendlyId}
457457
</TableCell>
458458
<TableCell to={path} className={cellClass}>

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.v3.$projectParam.test/route.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -264,6 +264,7 @@ function TaskRow({ task, environmentSlug }: { task: TaskListItem; environmentSlu
264264
</TableCell>
265265
<TableCell
266266
to={path}
267+
isTabbableCell
267268
actionClassName="pl-1 pr-2 py-1.5"
268269
className={cn((isActive || isPending) && "group-hover/table-row:bg-indigo-500/5")}
269270
>

0 commit comments

Comments
 (0)