Skip to content

Commit a20136e

Browse files
committed
Made the icons bright on hover
1 parent bf9115d commit a20136e

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

apps/webapp/app/components/primitives/Table.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,10 @@ export const TableCellMenu = forwardRef<
289289
{/* Always visible popover with ellipsis trigger */}
290290
{popoverContent && (
291291
<Popover onOpenChange={(open) => setIsOpen(open)}>
292-
<PopoverVerticalEllipseTrigger isOpen={isOpen} />
292+
<PopoverVerticalEllipseTrigger
293+
isOpen={isOpen}
294+
className="duration-0 group-hover/table-row:text-text-bright"
295+
/>
293296
<PopoverContent
294297
className="min-w-[10rem] max-w-[20rem] overflow-y-auto p-0 scrollbar-thin scrollbar-track-transparent scrollbar-thumb-charcoal-600"
295298
align="end"

apps/webapp/app/components/runs/v3/TaskRunsTable.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -420,7 +420,7 @@ function RunActionsCell({ run, path }: { run: RunListItem; path: string }) {
420420
leadingIconClassName="text-blue-500"
421421
title="View run"
422422
/>
423-
{!run.isCancellable && (
423+
{run.isCancellable && (
424424
<Dialog>
425425
<DialogTrigger
426426
asChild
@@ -470,13 +470,13 @@ function RunActionsCell({ run, path }: { run: RunListItem; path: string }) {
470470
}
471471
hiddenButtons={
472472
<div className="flex items-center">
473-
{!run.isCancellable && (
473+
{run.isCancellable && (
474474
<SimpleTooltip
475475
button={
476476
<Dialog>
477477
<DialogTrigger
478478
asChild
479-
className="size-6 rounded-sm p-1 text-text-dimmed transition hover:bg-charcoal-700 hover:text-text-bright"
479+
className="size-6 rounded-sm p-1 text-text-bright transition hover:bg-charcoal-700"
480480
>
481481
<NoSymbolIcon className="size-3" />
482482
</DialogTrigger>
@@ -491,7 +491,7 @@ function RunActionsCell({ run, path }: { run: RunListItem; path: string }) {
491491
disableHoverableContent
492492
/>
493493
)}
494-
{!run.isCancellable && run.isReplayable && (
494+
{run.isCancellable && run.isReplayable && (
495495
<div className="mx-0.5 h-6 w-px bg-grid-dimmed" />
496496
)}
497497
{run.isReplayable && (
@@ -500,7 +500,7 @@ function RunActionsCell({ run, path }: { run: RunListItem; path: string }) {
500500
<Dialog>
501501
<DialogTrigger
502502
asChild
503-
className="h-6 w-6 rounded-sm p-1 text-text-dimmed transition hover:bg-charcoal-700 hover:text-text-bright"
503+
className="h-6 w-6 rounded-sm p-1 text-text-bright transition hover:bg-charcoal-700"
504504
>
505505
<ArrowPathIcon className="size-3" />
506506
</DialogTrigger>

0 commit comments

Comments
 (0)