large outputs now get unique keys again

Author: nicktrn

packages/core/src/v3/idempotencyKeys.ts

@@ -105,7 +105,7 @@ function injectScope(scope: "run" | "attempt" | "global"): string[] {
     }
     case "attempt": {
       if (taskContext?.ctx) {
-        return [taskContext.ctx.attempt.id];
+        return [taskContext.ctx.run.id, taskContext.ctx.attempt.number.toString()];
       }
       break;
     }
@@ -125,3 +125,17 @@ async function generateIdempotencyKey(keyMaterial: string[]) {
     .map((byte) => byte.toString(16).padStart(2, "0"))
     .join("");
 }
+
+type AttemptKeyMaterial = {
+  run: {
+    id: string;
+  };
+  attempt: {
+    number: number;
+  };
+};
+
+/** Creates a unique key for each attempt. */
+export function attemptKey(ctx: AttemptKeyMaterial): string {
+  return `${ctx.run.id}-${ctx.attempt.number}`;
+}

packages/core/src/v3/workers/taskExecutor.ts

@@ -12,6 +12,7 @@ import {
 } from "../errors.js";
 import {
   accessoryAttributes,
+  attemptKey,
   flattenAttributes,
   lifecycleHooks,
   runMetadata,
@@ -235,7 +236,7 @@ export class TaskExecutor {
             const [exportError, finalOutput] = await tryCatch(
               conditionallyExportPacket(
                 stringifiedOutput,
-                `${execution.attempt.id}/output`,
+                `${attemptKey(ctx)}/output`,
                 this._tracer
               )
             );