Skip to content

Commit a98a803

Browse files
committed
Fix a few coderabbit comments
1 parent 2515fd5 commit a98a803

File tree

4 files changed

+5
-7
lines changed

4 files changed

+5
-7
lines changed

apps/webapp/app/eventLoopMonitor.server.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,6 @@ function after(asyncId: number) {
6565
cached.parentCtx
6666
);
6767

68-
console.log("🥸 Event loop blocked", { asyncType: cached.type, time });
69-
7068
newSpan.end();
7169
}
7270
}

apps/webapp/app/v3/eventRepository/clickhouseEventRepositoryInstance.server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ function initializeClickhouseRepository() {
3030
},
3131
logLevel: env.EVENTS_CLICKHOUSE_LOG_LEVEL,
3232
compression: {
33-
request: true,
33+
request: env.EVENTS_CLICKHOUSE_COMPRESSION_REQUEST === "1",
3434
},
3535
maxOpenConnections: env.EVENTS_CLICKHOUSE_MAX_OPEN_CONNECTIONS,
3636
});

internal-packages/clickhouse/schema/008_add_task_events_v1_mvs.sql

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ GROUP BY organization_id, project_id, environment_id, bucket_start;
4949

5050

5151
-- +goose Down
52-
DROP TABLE IF EXISTS trigger_dev.task_event_usage_by_hour_v1;
53-
DROP TABLE IF EXISTS trigger_dev.task_event_usage_by_minute_v1;
5452
DROP MATERIALIZED VIEW IF EXISTS trigger_dev.mv_task_event_usage_by_minute_v1;
55-
DROP MATERIALIZED VIEW IF EXISTS trigger_dev.mv_task_event_usage_by_hour_v1;
53+
DROP MATERIALIZED VIEW IF EXISTS trigger_dev.mv_task_event_usage_by_hour_v1;
54+
DROP TABLE IF EXISTS trigger_dev.task_event_usage_by_hour_v1;
55+
DROP TABLE IF EXISTS trigger_dev.task_event_usage_by_minute_v1;

packages/cli-v3/src/rules/manifest.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ export class GithubRulesManifestLoader implements RulesManifestLoader {
116116
const response = await fetch(
117117
`https://raw.githubusercontent.com/triggerdotdev/trigger.dev/refs/heads/${this.branch}/rules/manifest.json`,
118118
{
119-
signal: AbortSignal.timeout(2000),
119+
signal: AbortSignal.timeout(5000),
120120
}
121121
);
122122

0 commit comments

Comments
 (0)