fix runs.retrieve when the payload or output has unstringifiable JSON

Author: ericallam

apps/webapp/app/presenters/v3/ApiRetrieveRunPresenter.server.ts

@@ -7,8 +7,8 @@ import {
   conditionallyImportPacket,
   createJsonErrorObject,
   logger,
-  parsePacket,
 } from "@trigger.dev/core/v3";
+import { parsePacketAsJson } from "@trigger.dev/core/v3/utils/ioSerialization";
 import { Prisma, TaskRunAttemptStatus, TaskRunStatus } from "@trigger.dev/database";
 import assertNever from "assert-never";
 import { API_VERSIONS, CURRENT_API_VERSION, RunStatusUnspecifiedApiVersion } from "~/api/versions";
@@ -133,7 +133,7 @@ export class ApiRetrieveRunPresenter {
           });
         }
       } else {
-        $payload = await parsePacket(payloadPacket);
+        $payload = await parsePacketAsJson(payloadPacket);
       }
 
       if (taskRun.status === "COMPLETED_SUCCESSFULLY") {
@@ -162,7 +162,7 @@ export class ApiRetrieveRunPresenter {
             });
           }
         } else {
-          $output = await parsePacket(outputPacket);
+          $output = await parsePacketAsJson(outputPacket);
         }
       }
 
@@ -433,7 +433,7 @@ async function resolveSchedule(run: CommonRelatedRun) {
 }
 
 async function createCommonRunStructure(run: CommonRelatedRun, apiVersion: API_VERSIONS) {
-  const metadata = await parsePacket({
+  const metadata = await parsePacketAsJson({
     data: run.metadata ?? undefined,
     dataType: run.metadataType,
   });

references/hello-world/src/trigger/example.ts

@@ -58,7 +58,7 @@ export const parentTask = task({
   machine: "medium-1x",
   run: async (payload: any, { ctx }) => {
     logger.log("Hello, world from the parent", { payload });
-    await childTask.triggerAndWait({ message: "Hello, world!" });
+    await childTask.triggerAndWait({ message: "Hello, world!", aReallyBigInt: BigInt(10000) });
   },
 });
 
@@ -103,10 +103,11 @@ export const childTask = task({
       message,
       failureChance = 0.3,
       duration = 3_000,
-    }: { message?: string; failureChance?: number; duration?: number },
+      aReallyBigInt,
+    }: { message?: string; failureChance?: number; duration?: number; aReallyBigInt?: bigint },
     { ctx }
   ) => {
-    logger.info("Hello, world from the child", { message, failureChance });
+    logger.info("Hello, world from the child", { message, failureChance, aReallyBigInt });
 
     if (Math.random() < failureChance) {
       throw new Error("Random error at start");