WIP

Author: ericallam

apps/webapp/app/components/runs/v3/RunInspector.tsx

@@ -324,6 +324,12 @@ export function RunInspector({
                     </Property.Value>
                   </Property.Item>
                 )}
+                <Property.Item>
+                  <Property.Label>Max duration</Property.Label>
+                  <Property.Value>
+                    {run.maxDurationInSeconds ? `${run.maxDurationInSeconds}s` : "–"}
+                  </Property.Value>
+                </Property.Item>
                 <Property.Item>
                   <Property.Label>Run invocation cost</Property.Label>
                   <Property.Value>

apps/webapp/app/components/runs/v3/TaskRunStatus.tsx

@@ -8,6 +8,7 @@ import {
   NoSymbolIcon,
   PauseCircleIcon,
   RectangleStackIcon,
+  StopIcon,
   TrashIcon,
   XCircleIcon,
 } from "@heroicons/react/20/solid";
@@ -65,6 +66,7 @@ const taskRunStatusDescriptions: Record<TaskRunStatus, string> = {
   PAUSED: "Task has been paused by the user",
   CRASHED: "Task has crashed and won't be retried",
   EXPIRED: "Task has surpassed its ttl and won't be executed",
+  TIMED_OUT: "Task has reached it's maxDuration and has been stopped",
 };
 
 export const QUEUED_STATUSES = [
@@ -140,6 +142,8 @@ export function TaskRunStatusIcon({
       return <FireIcon className={cn(runStatusClassNameColor(status), className)} />;
     case "EXPIRED":
       return <TrashIcon className={cn(runStatusClassNameColor(status), className)} />;
+    case "TIMED_OUT":
+      return <StopIcon className={cn(runStatusClassNameColor(status), className)} />;
 
     default: {
       assertNever(status);
@@ -174,6 +178,8 @@ export function runStatusClassNameColor(status: TaskRunStatus): string {
       return "text-error";
     case "CRASHED":
       return "text-error";
+    case "TIMED_OUT":
+      return "text-error";
     default: {
       assertNever(status);
     }
@@ -210,6 +216,8 @@ export function runStatusTitle(status: TaskRunStatus): string {
       return "Crashed";
     case "EXPIRED":
       return "Expired";
+    case "TIMED_OUT":
+      return "Timed out";
     default: {
       assertNever(status);
     }

apps/webapp/app/database-types.ts

@@ -42,6 +42,7 @@ export const TaskRunStatus = {
   CRASHED: "CRASHED",
   DELAYED: "DELAYED",
   EXPIRED: "EXPIRED",
+  TIMED_OUT: "TIMED_OUT",
 } as const satisfies Record<TaskRunStatusType, TaskRunStatusType>;
 
 export const JobRunStatus = {

apps/webapp/app/models/taskRun.server.ts

@@ -119,6 +119,7 @@ export function batchTaskRunItemStatusForRunStatus(
     case TaskRunStatus.SYSTEM_FAILURE:
     case TaskRunStatus.CRASHED:
     case TaskRunStatus.EXPIRED:
+    case TaskRunStatus.TIMED_OUT:
       return BatchTaskRunItemStatus.FAILED;
     case TaskRunStatus.PENDING:
     case TaskRunStatus.WAITING_FOR_DEPLOY:

apps/webapp/app/presenters/v3/ApiRetrieveRunPresenter.server.ts

@@ -270,6 +270,9 @@ export class ApiRetrieveRunPresenter extends BasePresenter {
       case "EXPIRED": {
         return "EXPIRED";
       }
+      case "TIMED_OUT": {
+        return "TIMED_OUT";
+      }
       default: {
         assertNever(status);
       }

apps/webapp/app/presenters/v3/ApiRunListPresenter.server.ts

@@ -310,6 +310,9 @@ export class ApiRunListPresenter extends BasePresenter {
       case "EXPIRED": {
         return "EXPIRED";
       }
+      case "TIMED_OUT": {
+        return "TIMED_OUT";
+      }
       default: {
         assertNever(status);
       }

apps/webapp/app/presenters/v3/SpanPresenter.server.ts

@@ -69,6 +69,7 @@ export class SpanPresenter extends BasePresenter {
         taskIdentifier: true,
         friendlyId: true,
         isTest: true,
+        maxDurationInSeconds: true,
         tags: {
           select: {
             name: true,
@@ -229,6 +230,7 @@ export class SpanPresenter extends BasePresenter {
         baseCostInCents: run.baseCostInCents,
         maxAttempts: run.maxAttempts ?? undefined,
         version: run.lockedToVersion?.version,
+        maxDuration: run.maxDurationInSeconds ?? undefined,
       },
       queue: {
         name: run.queue,
@@ -307,6 +309,7 @@ export class SpanPresenter extends BasePresenter {
       },
       context: JSON.stringify(context, null, 2),
       metadata,
+      maxDurationInSeconds: run.maxDurationInSeconds,
     };
   }
 

apps/webapp/app/routes/resources.orgs.$organizationSlug.projects.v3.$projectParam.runs.$runParam.spans.$spanParam/route.tsx

@@ -677,7 +677,12 @@ function RunBody({
                     )}
                   </Property.Value>
                 </Property.Item>
-
+                <Property.Item>
+                  <Property.Label>Max duration</Property.Label>
+                  <Property.Value>
+                    {run.maxDurationInSeconds ? `${run.maxDurationInSeconds}s` : "–"}
+                  </Property.Value>
+                </Property.Item>
                 <Property.Item>
                   <Property.Label>Run invocation cost</Property.Label>
                   <Property.Value>

apps/webapp/app/v3/marqs/devQueueConsumer.server.ts

@@ -378,6 +378,8 @@ export class DevQueueConsumer {
         status: "EXECUTING",
         lockedToVersionId: backgroundWorker.id,
         startedAt: existingTaskRun.startedAt ?? new Date(),
+        maxDurationInSeconds:
+          existingTaskRun.maxDurationInSeconds ?? backgroundTask.maxDurationInSeconds,
       },
       include: {
         attempts: {

apps/webapp/app/v3/requeueTaskRun.server.ts

@@ -70,6 +70,7 @@ export class RequeueTaskRunService extends BaseService {
       case "COMPLETED_WITH_ERRORS":
       case "COMPLETED_SUCCESSFULLY":
       case "EXPIRED":
+      case "TIMED_OUT":
       case "CANCELED": {
         logger.debug("[RequeueTaskRunService] Task run is completed", { taskRun });