Skip to content

Commit b6915d4

Browse files
committed
undo some unrelated changes
1 parent 20d22ea commit b6915d4

File tree

3 files changed

+4
-29
lines changed

3 files changed

+4
-29
lines changed

apps/webapp/app/presenters/v3/TaskListPresenter.server.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import {
1212
type DailyTaskActivity,
1313
type EnvironmentMetricsRepository,
1414
} from "~/services/environmentMetricsRepository.server";
15-
import { singleton } from "~/utils/singleton";
1615
import { findCurrentWorkerFromEnvironment } from "~/v3/models/workerDeployment.server";
1716

1817
export type TaskListItem = {
@@ -106,9 +105,7 @@ export class TaskListPresenter {
106105
}
107106
}
108107

109-
export const taskListPresenter = singleton("taskListPresenter", setupTaskListPresenter);
110-
111-
function setupTaskListPresenter() {
108+
export function getTaskListPresenter() {
112109
const environmentMetricsRepository = new ClickHouseEnvironmentMetricsRepository({
113110
clickhouse: clickhouseClient,
114111
});

apps/webapp/app/routes/admin.api.v1.snapshot.ts

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -24,25 +24,6 @@ function formatDate(date: Date) {
2424
.padStart(2, "0")}_${milliseconds.toString().padStart(3, "0")}`;
2525
}
2626

27-
// Force consistent garbage collection before taking heap snapshot
28-
async function forceConsistentGC(rounds = 5): Promise<void> {
29-
if (typeof global.gc !== "function") {
30-
console.warn("⚠️ global.gc not available - heap snapshots may be inconsistent");
31-
return;
32-
}
33-
34-
// Force multiple GC rounds to ensure consistent state
35-
for (let i = 0; i < rounds; i++) {
36-
global.gc(); // Major GC
37-
if (i < rounds - 1) {
38-
await new Promise((resolve) => setTimeout(resolve, 50));
39-
}
40-
}
41-
42-
// Final wait for any pending cleanup
43-
await new Promise((resolve) => setTimeout(resolve, 200));
44-
}
45-
4627
export async function loader({ request }: DataFunctionArgs) {
4728
const authenticationResult = await authenticateApiRequestWithPersonalAccessToken(request);
4829

@@ -60,9 +41,6 @@ export async function loader({ request }: DataFunctionArgs) {
6041
throw new Response("You must be an admin to perform this action", { status: 403 });
6142
}
6243

63-
// Force consistent GC state before taking snapshot
64-
await forceConsistentGC();
65-
6644
const tempDir = os.tmpdir();
6745
const filepath = path.join(
6846
tempDir,

apps/webapp/app/v3/scheduleEngine.server.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,9 @@ async function isDevEnvironmentConnectedHandler(environmentId: string) {
4747
return v4Connected;
4848
}
4949

50+
// This will trigger either v1 or v2 depending on the engine of the project
51+
const triggerService = new TriggerTaskService();
52+
5053
function createScheduleEngine() {
5154
const engine = new ScheduleEngine({
5255
prisma,
@@ -82,9 +85,6 @@ function createScheduleEngine() {
8285
exactScheduleTime,
8386
}) => {
8487
try {
85-
// This will trigger either v1 or v2 depending on the engine of the project
86-
const triggerService = new TriggerTaskService();
87-
8888
const payloadPacket = await stringifyIO(payload);
8989

9090
logger.debug("Triggering scheduled task", {

0 commit comments

Comments
 (0)