cleanup

Author: mpcgrid

apps/webapp/app/components/logs/LogDetailView.tsx

@@ -1,10 +1,10 @@
-import { XMarkIcon, ArrowTopRightOnSquareIcon, CheckIcon, ClockIcon } from "@heroicons/react/20/solid";
+import { XMarkIcon, ArrowTopRightOnSquareIcon, CheckIcon } from "@heroicons/react/20/solid";
 import { Link } from "@remix-run/react";
 import {
   type MachinePresetName,
   formatDurationMilliseconds,
 } from "@trigger.dev/core/v3";
-import { useEffect, useState, type ReactNode } from "react";
+import { useEffect, useState } from "react";
 import { useTypedFetcher } from "remix-typedjson";
 import { cn } from "~/utils/cn";
 import { Button } from "~/components/primitives/Buttons";
@@ -22,7 +22,7 @@ import { useOrganization } from "~/hooks/useOrganizations";
 import { useProject } from "~/hooks/useProject";
 import type { LogEntry } from "~/presenters/v3/LogsListPresenter.server";
 import { getLevelColor } from "~/utils/logUtils";
-import { v3RunSpanPath, v3RunsPath, v3BatchPath, v3RunPath, v3DeploymentVersionPath } from "~/utils/pathBuilder";
+import { v3RunSpanPath, v3RunsPath, v3DeploymentVersionPath } from "~/utils/pathBuilder";
 import type { loader as logDetailLoader } from "~/routes/resources.orgs.$organizationSlug.projects.$projectParam.env.$envParam.logs.$logId";
 import { TaskRunStatusCombo, descriptionForTaskRunStatus } from "~/components/runs/v3/TaskRunStatus";
 import { MachineLabelCombo } from "~/components/MachineLabelCombo";
@@ -48,6 +48,12 @@ type LogDetailViewProps = {
 
 type TabType = "details" | "run";
 
+type LogAttributes = Record<string, unknown> & {
+  error?: {
+    message?: string;
+  };
+};
+
 // Event kind badge color styles
 function getKindColor(kind: string): string {
   if (kind === "SPAN") {
@@ -109,6 +115,7 @@ export function LogDetailView({ logId, initialLog, onClose, searchTerm }: LogDet
     fetcher.load(
       `/resources/orgs/${organization.slug}/projects/${project.slug}/env/${environment.slug}/logs/${encodeURIComponent(logId)}`
     );
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [organization.slug, project.slug, environment.slug, logId]);
 
   const isLoading = fetcher.state === "loading";
@@ -226,7 +233,7 @@ export function LogDetailView({ logId, initialLog, onClose, searchTerm }: LogDet
 
 function DetailsTab({ log, runPath, searchTerm }: { log: LogEntry; runPath: string; searchTerm?: string }) {
   const logWithExtras = log as LogEntry & {
-    attributes?: Record<string, unknown>;
+    attributes?: LogAttributes;
   };
 
 
@@ -242,7 +249,7 @@ function DetailsTab({ log, runPath, searchTerm }: { log: LogEntry; runPath: stri
   // Determine message to show
   let message = log.message ?? "";
   if (log.level === "ERROR") {
-    const maybeErrorMessage = (logWithExtras.attributes as any)?.error?.message;
+    const maybeErrorMessage = logWithExtras.attributes?.error?.message;
     if (typeof maybeErrorMessage === "string" && maybeErrorMessage.length > 0) {
       message = maybeErrorMessage;
     }
@@ -298,6 +305,7 @@ function RunTab({ log, runPath }: { log: LogEntry; runPath: string }) {
     fetcher.load(
       `/resources/orgs/${organization.slug}/projects/${project.slug}/env/${environment.slug}/logs/${encodeURIComponent(log.id)}/run?runId=${encodeURIComponent(log.runId)}`
     );
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [organization.slug, project.slug, environment.slug, log.id, log.runId]);
 
   const isLoading = !requested || fetcher.state === "loading";

apps/webapp/app/components/logs/LogsSearchInput.tsx

@@ -25,6 +25,7 @@ export function LogsSearchInput() {
     if (urlSearch !== text && !isFocused) {
       setText(urlSearch);
     }
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [location.search]);
 
   const handleSubmit = useCallback(() => {

apps/webapp/app/components/logs/LogsTable.tsx

@@ -1,6 +1,5 @@
 import { ArrowPathIcon, ArrowTopRightOnSquareIcon } from "@heroicons/react/20/solid";
-import { formatDurationNanoseconds } from "@trigger.dev/core/v3";
-import { type ReactNode, useEffect, useRef, useState } from "react";
+import { useEffect, useRef, useState } from "react";
 import { cn } from "~/utils/cn";
 import { Button } from "~/components/primitives/Buttons";
 import { useEnvironment } from "~/hooks/useEnvironment";

apps/webapp/app/presenters/v3/LogsListPresenter.server.ts

@@ -110,6 +110,19 @@ function convertDateToNanoseconds(date: Date): bigint {
   return BigInt(date.getTime()) * 1_000_000n;
 }
 
+function formatNanosecondsForClickhouse(ns: bigint): string {
+  const nsString = ns.toString();
+  // Handle negative numbers (dates before 1970-01-01)
+  if (nsString.startsWith("-")) {
+    const absString = nsString.slice(1);
+    const padded = absString.padStart(19, "0");
+    return "-" + padded.slice(0, 10) + "." + padded.slice(10);
+  }
+  // Pad positive numbers to 19 digits to ensure correct slicing
+  const padded = nsString.padStart(19, "0");
+  return padded.slice(0, 10) + "." + padded.slice(10);
+}
+
 export class LogsListPresenter {
   constructor(
     private readonly replica: PrismaClientOrTransaction,
@@ -324,23 +337,23 @@ export class LogsListPresenter {
 
     // Time filters - inserted_at in PREWHERE for partition pruning, start_time in WHERE
     if (effectiveFrom) {
-      const fromNs = convertDateToNanoseconds(effectiveFrom).toString();
+      const fromNs = convertDateToNanoseconds(effectiveFrom);
       queryBuilder.prewhere("inserted_at >= {insertedAtStart: DateTime64(3)}", {
         insertedAtStart: convertDateToClickhouseDateTime(effectiveFrom),
       });
       queryBuilder.where("start_time >= {fromTime: String}", {
-        fromTime: fromNs.slice(0, 10) + "." + fromNs.slice(10),
+        fromTime: formatNanosecondsForClickhouse(fromNs),
       });
     }
 
     if (effectiveTo) {
       const clampedTo = effectiveTo > new Date() ? new Date() : effectiveTo;
-      const toNs = convertDateToNanoseconds(clampedTo).toString();
+      const toNs = convertDateToNanoseconds(clampedTo);
       queryBuilder.prewhere("inserted_at <= {insertedAtEnd: DateTime64(3)}", {
         insertedAtEnd: convertDateToClickhouseDateTime(clampedTo),
       });
       queryBuilder.where("start_time <= {toTime: String}", {
-        toTime: toNs.slice(0, 10) + "." + toNs.slice(10),
+        toTime: formatNanosecondsForClickhouse(toNs),
       });
     }
 

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.logs/route.tsx

@@ -26,7 +26,6 @@ import { Suspense, useCallback, useEffect, useMemo, useState, useTransition } fr
 import { Spinner } from "~/components/primitives/Spinner";
 import { Paragraph } from "~/components/primitives/Paragraph";
 import { Callout } from "~/components/primitives/Callout";
-import type { TaskRunListSearchFilters } from "~/components/runs/v3/RunFilters";
 import { RunsFilters } from "~/components/runs/v3/RunFilters";
 import { LogsTable } from "~/components/logs/LogsTable";
 import type { LogEntry } from "~/presenters/v3/LogsListPresenter.server";
@@ -39,7 +38,6 @@ import {
   ResizablePanelGroup,
 } from "~/components/primitives/Resizable";
 import { Switch } from "~/components/primitives/Switch";
-import { getUserById } from "~/models/user.server";
 
 // Valid log levels for filtering
 const validLevels: LogLevel[] = ["TRACE", "DEBUG", "INFO", "WARN", "ERROR", "CANCELLED"];