fix PR review issues

Author: ericallam

apps/webapp/app/routes/api.v1.projects.$projectRef.$env.ts

@@ -129,13 +129,6 @@ export async function getEnvironmentFromEnv({
   }
 
   if (slug === "preview") {
-    if (!branch) {
-      return {
-        success: false,
-        error: "Preview environment requires a branch. Please set the x-trigger-branch header.",
-      };
-    }
-
     const previewEnvironment = await prisma.runtimeEnvironment.findFirst({
       where: {
         projectId,
@@ -150,6 +143,14 @@ export async function getEnvironmentFromEnv({
       };
     }
 
+    // If no branch is provided, just return the parent preview environment
+    if (!branch) {
+      return {
+        success: true,
+        environment: previewEnvironment,
+      };
+    }
+
     const branchEnvironment = await prisma.runtimeEnvironment.findFirst({
       where: {
         parentEnvironmentId: previewEnvironment.id,

packages/core/src/v3/schemas/api.ts

@@ -1225,30 +1225,6 @@ export const ApiBranchListResponseBody = z.object({
 
 export type ApiBranchListResponseBody = z.infer<typeof ApiBranchListResponseBody>;
 
-// export type SpanDetailedSummary = {
-//   id: string;
-//   parentId: string | undefined;
-//   message: string;
-//   data: {
-//     runId: string;
-//     taskSlug?: string;
-//     taskPath?: string;
-//     events: SpanEvents;
-//     startTime: Date;
-//     duration: number;
-//     isError: boolean;
-//     isPartial: boolean;
-//     isCancelled: boolean;
-//     level: NonNullable<CreatableEvent["level"]>;
-//     environmentType: CreatableEventEnvironmentType;
-//     workerVersion?: string;
-//     queueName?: string;
-//     machinePreset?: string;
-//     properties?: Attributes;
-//     output?: Attributes;
-//   };
-//   children: Array<SpanDetailedSummary>;
-// };
 export const RetrieveRunTraceSpanSchema = z.object({
   id: z.string(),
   parentId: z.string().optional(),