review changes

Author: mpcgrid

apps/webapp/app/presenters/v3/LogDetailPresenter.server.ts

@@ -70,18 +70,10 @@ export class LogDetailPresenter {
 
     const log = records[0];
 
-    // Parse metadata and attributes
-    let parsedMetadata: Record<string, unknown> = {};
+
     let parsedAttributes: Record<string, unknown> = {};
     let rawAttributesString = "";
 
-    try {
-      if (log.metadata) {
-        parsedMetadata = JSON.parse(log.metadata) as Record<string, unknown>;
-      }
-    } catch {
-      // Ignore parse errors
-    }
 
     try {
       // Handle attributes_text which is a string
@@ -107,10 +99,8 @@ export class LogDetailPresenter {
       status: log.status,
       duration: typeof log.duration === "number" ? log.duration : Number(log.duration),
       level: kindToLevel(log.kind, log.status),
-      metadata: parsedMetadata,
       attributes: parsedAttributes,
       // Raw strings for display
-      rawMetadata: log.metadata,
       rawAttributes: rawAttributesString,
     };
   }

apps/webapp/app/presenters/v3/LogsListPresenter.server.ts

@@ -544,7 +544,7 @@ export class LogsListPresenter extends BasePresenter {
       // For error logs with status ERROR, try to extract error message from attributes
       if (log.status === "ERROR" && log.attributes_text) {
         try {
-          let attributes = JSON.parse(log.attributes_text) as ErrorAttributes;
+          const attributes = JSON.parse(log.attributes_text) as ErrorAttributes;
 
           if (attributes?.error?.message && typeof attributes.error.message === "string") {
             displayMessage = attributes.error.message;

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.logs/route.tsx

@@ -98,12 +98,20 @@ export const loader = async ({ request, params }: LoaderFunctionArgs) => {
   const userId = user.id;
   const isAdmin = user.admin || user.isImpersonating;
 
-  if (!isAdmin) {
-    throw redirect("/");
-  }
 
   const { projectParam, organizationSlug, envParam } = EnvironmentParamSchema.parse(params);
 
+  const canAccess = await hasLogsPageAccess(
+    userId,
+    user.admin,
+    user.isImpersonating,
+    organizationSlug
+  );
+
+  if(!canAccess) {
+    throw redirect("/");
+  }
+
   const project = await findProjectBySlug(organizationSlug, projectParam, userId);
   if (!project) {
     throw new Response("Project not found", { status: 404 });