Deal with old batches: “Legacy batch”

Author: matt-aitken

apps/webapp/app/presenters/v3/BatchListPresenter.server.ts

@@ -96,6 +96,7 @@ export class BatchListPresenter extends BasePresenter {
         createdAt: Date;
         updatedAt: Date;
         runCount: BigInt;
+        batchVersion: string;
       }[]
     >`
     SELECT
@@ -105,7 +106,8 @@ export class BatchListPresenter extends BasePresenter {
     b.status,
     b."createdAt",
     b."updatedAt",
-    b."runCount"
+    b."runCount",
+    b."batchVersion"
 FROM
     ${sqlDatabaseSchema}."BatchTaskRun" b
 WHERE
@@ -123,7 +125,9 @@ WHERE
     ${friendlyId ? Prisma.sql`AND b."friendlyId" = ${friendlyId}` : Prisma.empty}
     ${
       statuses && statuses.length > 0
-        ? Prisma.sql`AND b.status = ANY(ARRAY[${Prisma.join(statuses)}]::"BatchTaskRunStatus"[])`
+        ? Prisma.sql`AND b.status = ANY(ARRAY[${Prisma.join(
+            statuses
+          )}]::"BatchTaskRunStatus"[]) AND b.version <> 'v1'`
         : Prisma.empty
     }
     ${
@@ -191,6 +195,7 @@ WHERE
           status: batch.status,
           environment: displayableEnvironment(environment, userId),
           runCount: Number(batch.runCount),
+          batchVersion: batch.batchVersion,
         };
       }),
       pagination: {

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.v3.$projectParam.batches/route.tsx

@@ -1,4 +1,9 @@
-import { CheckCircleIcon, ClockIcon, RectangleGroupIcon } from "@heroicons/react/20/solid";
+import {
+  CheckCircleIcon,
+  ClockIcon,
+  ExclamationCircleIcon,
+  RectangleGroupIcon,
+} from "@heroicons/react/20/solid";
 import { ArrowUpCircleIcon } from "@heroicons/react/24/outline";
 import { BookOpenIcon } from "@heroicons/react/24/solid";
 import { Outlet, useLocation, useNavigation, useParams } from "@remix-run/react";
@@ -208,11 +213,24 @@ function BatchesTable({ batches, hasFilters, filters }: BatchList) {
                   />
                 </TableCell>
                 <TableCell to={path}>
-                  <SimpleTooltip
-                    content={descriptionForBatchStatus(batch.status)}
-                    disableHoverableContent
-                    button={<BatchStatusCombo status={batch.status} />}
-                  />
+                  {batch.batchVersion === "v1" ? (
+                    <SimpleTooltip
+                      content="Upgrade to the latest SDK for batch statuses to appear."
+                      disableHoverableContent
+                      button={
+                        <span className="flex items-center gap-1">
+                          <ExclamationCircleIcon className="size-4 text-slate-500" />
+                          <span>Legacy batch</span>
+                        </span>
+                      }
+                    />
+                  ) : (
+                    <SimpleTooltip
+                      content={descriptionForBatchStatus(batch.status)}
+                      disableHoverableContent
+                      button={<BatchStatusCombo status={batch.status} />}
+                    />
+                  )}
                 </TableCell>
                 <TableCell to={path}>{batch.runCount}</TableCell>
                 <TableCell to={path} className="w-[1%]" actionClassName="pr-0 tabular-nums">