Skip to content

Commit eaacf63

Browse files
committed
fix postgres and redis external config, incl redis tls
1 parent e02c90a commit eaacf63

File tree

3 files changed

+39
-11
lines changed

3 files changed

+39
-11
lines changed

hosting/k8s/helm/templates/_helpers.tpl

Lines changed: 32 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,8 @@ Get the full image name for supervisor
9999
PostgreSQL hostname
100100
*/}}
101101
{{- define "trigger-v4.postgres.hostname" -}}
102-
{{- if .Values.postgres.host }}
103-
{{- .Values.postgres.host }}
102+
{{- if .Values.postgres.external.host }}
103+
{{- .Values.postgres.external.host }}
104104
{{- else if .Values.postgres.deploy }}
105105
{{- printf "%s-postgres" .Release.Name }}
106106
{{- end }}
@@ -110,8 +110,8 @@ PostgreSQL hostname
110110
PostgreSQL connection string
111111
*/}}
112112
{{- define "trigger-v4.postgres.connectionString" -}}
113-
{{- if .Values.postgres.host -}}
114-
postgresql://{{ .Values.postgres.username }}:{{ .Values.postgres.password }}@{{ .Values.postgres.host }}:{{ .Values.postgres.port | default 5432 }}/{{ .Values.postgres.database }}?schema={{ .Values.postgres.schema | default "public" }}&sslmode={{ .Values.postgres.sslMode | default "prefer" }}
113+
{{- if .Values.postgres.external.host -}}
114+
postgresql://{{ .Values.postgres.external.username }}:{{ .Values.postgres.external.password }}@{{ .Values.postgres.external.host }}:{{ .Values.postgres.external.port | default 5432 }}/{{ .Values.postgres.external.database }}?schema={{ .Values.postgres.connection.schema | default "public" }}&sslmode={{ .Values.postgres.connection.sslMode | default "prefer" }}
115115
{{- else if .Values.postgres.deploy -}}
116116
postgresql://{{ .Values.postgres.auth.username }}:{{ .Values.postgres.auth.password }}@{{ include "trigger-v4.postgres.hostname" . }}:5432/{{ .Values.postgres.auth.database }}?schema={{ .Values.postgres.connection.schema | default "public" }}&sslmode={{ .Values.postgres.connection.sslMode | default "prefer" }}
117117
{{- end -}}
@@ -121,8 +121,8 @@ postgresql://{{ .Values.postgres.auth.username }}:{{ .Values.postgres.auth.passw
121121
Redis hostname
122122
*/}}
123123
{{- define "trigger-v4.redis.hostname" -}}
124-
{{- if .Values.redis.host }}
125-
{{- .Values.redis.host }}
124+
{{- if .Values.redis.external.host }}
125+
{{- .Values.redis.external.host }}
126126
{{- else if .Values.redis.deploy }}
127127
{{- printf "%s-redis-master" .Release.Name }}
128128
{{- end }}
@@ -136,13 +136,35 @@ Redis connection details
136136
{{- end }}
137137

138138
{{- define "trigger-v4.redis.port" -}}
139-
{{- if .Values.redis.host -}}
140-
{{ .Values.redis.port | default 6379 }}
139+
{{- if .Values.redis.external.host -}}
140+
{{ .Values.redis.external.port | default 6379 }}
141141
{{- else if .Values.redis.deploy -}}
142142
6379
143143
{{- end -}}
144144
{{- end }}
145145

146+
{{/*
147+
Redis password
148+
*/}}
149+
{{- define "trigger-v4.redis.password" -}}
150+
{{- if .Values.redis.external.host -}}
151+
{{ .Values.redis.external.password }}
152+
{{- else if .Values.redis.deploy -}}
153+
{{ .Values.redis.auth.password }}
154+
{{- end -}}
155+
{{- end }}
156+
157+
{{/*
158+
Redis TLS disabled setting
159+
*/}}
160+
{{- define "trigger-v4.redis.tlsDisabled" -}}
161+
{{- if .Values.redis.external.host -}}
162+
{{ not (.Values.redis.external.tls.enabled | default false) }}
163+
{{- else -}}
164+
{{- true -}}
165+
{{- end -}}
166+
{{- end }}
167+
146168
{{/*
147169
Electric service URL
148170
*/}}
@@ -248,8 +270,8 @@ Registry connection details
248270
PostgreSQL host (for wait-for-it script)
249271
*/}}
250272
{{- define "trigger-v4.postgres.host" -}}
251-
{{- if .Values.postgres.host -}}
252-
{{ .Values.postgres.host }}:{{ .Values.postgres.port | default 5432 }}
273+
{{- if .Values.postgres.external.host -}}
274+
{{ .Values.postgres.external.host }}:{{ .Values.postgres.external.port | default 5432 }}
253275
{{- else if .Values.postgres.deploy -}}
254276
{{ include "trigger-v4.postgres.hostname" . }}:5432
255277
{{- end -}}

hosting/k8s/helm/templates/webapp.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,8 +190,12 @@ spec:
190190
value: {{ include "trigger-v4.redis.host" . | quote }}
191191
- name: REDIS_PORT
192192
value: {{ include "trigger-v4.redis.port" . | quote }}
193+
{{- if include "trigger-v4.redis.password" . }}
194+
- name: REDIS_PASSWORD
195+
value: {{ include "trigger-v4.redis.password" . | quote }}
196+
{{- end }}
193197
- name: REDIS_TLS_DISABLED
194-
value: "true"
198+
value: {{ include "trigger-v4.redis.tlsDisabled" . | quote }}
195199
- name: APP_LOG_LEVEL
196200
value: {{ .Values.webapp.logLevel | quote }}
197201
- name: DEV_OTEL_EXPORTER_OTLP_ENDPOINT

hosting/k8s/helm/values.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -395,6 +395,8 @@ redis:
395395
host: ""
396396
port: 6379
397397
password: ""
398+
tls:
399+
enabled: false # Set to true for Redis instances requiring TLS (e.g., AWS ElastiCache)
398400

399401
# Electric configuration
400402
electric:

0 commit comments

Comments
 (0)