Skip to content

Commit f710326

Browse files
committed
all non-final statuses should be failable
1 parent 0c37df7 commit f710326

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

apps/webapp/app/v3/taskStatus.ts

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -55,12 +55,7 @@ export const CANCELLABLE_ATTEMPT_STATUSES = NON_FINAL_ATTEMPT_STATUSES;
5555
export const CRASHABLE_RUN_STATUSES = NON_FINAL_RUN_STATUSES;
5656
export const CRASHABLE_ATTEMPT_STATUSES = NON_FINAL_ATTEMPT_STATUSES;
5757

58-
export const FAILABLE_RUN_STATUSES = [
59-
"EXECUTING",
60-
"PENDING",
61-
"WAITING_FOR_DEPLOY",
62-
"RETRYING_AFTER_FAILURE",
63-
] satisfies TaskRunStatus[];
58+
export const FAILABLE_RUN_STATUSES = NON_FINAL_RUN_STATUSES;
6459

6560
export const FREEZABLE_RUN_STATUSES: TaskRunStatus[] = ["EXECUTING", "RETRYING_AFTER_FAILURE"];
6661
export const FREEZABLE_ATTEMPT_STATUSES: TaskRunAttemptStatus[] = ["EXECUTING", "FAILED"];
@@ -75,6 +70,10 @@ export function isFinalAttemptStatus(status: TaskRunAttemptStatus): boolean {
7570
return FINAL_ATTEMPT_STATUSES.includes(status);
7671
}
7772

73+
export function isFailedRunStatus(status: TaskRunStatus): boolean {
74+
return FAILED_RUN_STATUSES.includes(status);
75+
}
76+
7877
export function isCancellableRunStatus(status: TaskRunStatus): boolean {
7978
return CANCELLABLE_RUN_STATUSES.includes(status);
8079
}
@@ -102,7 +101,3 @@ export function isRestorableRunStatus(status: TaskRunStatus): boolean {
102101
export function isRestorableAttemptStatus(status: TaskRunAttemptStatus): boolean {
103102
return RESTORABLE_ATTEMPT_STATUSES.includes(status);
104103
}
105-
106-
export function isFailedRunStatus(status: TaskRunStatus): boolean {
107-
return FAILED_RUN_STATUSES.includes(status);
108-
}

0 commit comments

Comments
 (0)