Skip to content

Commit fb433de

Browse files
committed
Added notes back in
1 parent f1e2736 commit fb433de

File tree

1 file changed

+20
-0
lines changed

1 file changed

+20
-0
lines changed

apps/webapp/app/v3/services/triggerTask.server.ts

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,26 @@ export class TriggerTaskService extends WithRunEngine {
5252
return await this.callV1(taskId, environment, body, options);
5353
}
5454

55+
//todo Additional checks
56+
/*
57+
- If the `triggerVersion` is 3.2 or higher AND the project has engine V2, we will use the run engine.
58+
- Add an `engine` column to `Project` in the database.
59+
60+
Add `engine` to the trigger.config file. It would default to "V1" for now, but you can set it to V2.
61+
62+
You run `npx trigger.dev@latest deploy` with config v2.
63+
- Create BackgroundWorker with `engine`: `v2`.
64+
- Set the `project` `engine` column to `v2`.
65+
66+
You run `npx trigger.dev@latest dev` with config v2
67+
- Create BackgroundWorker with `engine`: `v2`.
68+
- Set the `project` `engine` column to `v2`.
69+
70+
When triggering
71+
- triggerAndWait we can lookup the BackgroundWorker easily, and get the engine.
72+
- No locked version: lookup the BackgroundWorker via the Deployment/latest dev BW
73+
*/
74+
5575
return await this.callV2(taskId, environment, body, options);
5676
});
5777
}

0 commit comments

Comments
 (0)